Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Jerry.Ray@microchip.com>
To:     <kuba@kernel.org>
CC:     <andrew@lunn.ch>, <f.fainelli@gmail.com>, <olteanv@gmail.com>,
        <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net-next v3] dsa: lan9303: Add 3 ethtool stats
Thread-Topic: [PATCH net-next v3] dsa: lan9303: Add 3 ethtool stats
Thread-Index: AQHZA2vPxK4eDIuP5kOkg3W32g1dkK5U+YSAgAKmf0A=
Date:   Wed, 30 Nov 2022 15:51:44 +0000
Message-ID: <MWHPR11MB1693E002721F0696949C5DCBEF159@MWHPR11MB1693.namprd11.prod.outlook.com>
References: <20221128205521.32116-1-jerry.ray@microchip.com>
 <20221128152145.486c6e4b@kernel.org>
In-Reply-To: <20221128152145.486c6e4b@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?w7hFu9DeKn/WWL47n7GfS8DqZMXB5qUCq2iUkLo904JrnDQaQmw+TWy6NG+x?=
 =?us-ascii?Q?N4JpDJeAae9raZ2Dvtm8/IFAcAJyI1DQDcGz9hsoFeGputpw2NO58FLXeTA8?=
 =?us-ascii?Q?NeVfyXRXxMtZzBTPFvxdt/LjUbV0XR7/4dWPlLOxzl4cYlD9z/EfWY68/7wt?=
 =?us-ascii?Q?FAc1BwInxdzuIh858eTOpQUmgkN3IcViyF0WcNUjW/UHNqJkvHRwd8yfUmlC?=
 =?us-ascii?Q?f8gnmAHl92H9l+itWRxvZu5NOZHEiw6RJ7mAZ8XIF38Wdxss25gK4zlFv2rT?=
 =?us-ascii?Q?9BltsiMEQwdcLS1K5kLKLnZ3aVfC6XqvsbeB68WL9h04moSIh0Krn6VbXSQr?=
 =?us-ascii?Q?JjPJ8qMNKSKlOtrLtL7xr/JcBrZ9VhH7c71owOqDqPk8dJU+61k9M+5vN+BK?=
 =?us-ascii?Q?vjNwlgQFZdPXJJqsiipbWFSHaNQQJS66hqTa00JVXv3lb+DxVi5ivE0VLcUA?=
 =?us-ascii?Q?8qBR3BlcpIK9qPZbOAqJvGYluTMIewG3qADewNpEfHD5+5NBN1oXnu5/z2a0?=
 =?us-ascii?Q?4ccLKyFeICKYMaNI55bvAVk0J1aleil2nKHw5kbIj2DfTT79cI70pVCwk177?=
 =?us-ascii?Q?dobebPXl++WVKNIXvK8lu65IQ9lZOaveR2bQw0X+olPWigatKoGyh0iQZyDV?=
 =?us-ascii?Q?g+8ghehbyG9ZhgCNL11lQbiZkyjrBtnp4wkho1un/xe3pksv9kmQN6/OYyfh?=
 =?us-ascii?Q?faLXZdmBmiolAVHG/fSZLd+Aa6sAs6RSRe3o+bPjzsv/ZMFhu90r/btM+v3y?=
 =?us-ascii?Q?arwgZfgV7kidSgiwlp8YAcSREw1Plq8uV94f3wWhP+45OlxlChdxu6OdvWG/?=
 =?us-ascii?Q?ZAuozS+3bfb9eVUIvK3rAm3jyKv4K+qICJd9tIqrK96eg1Nw2zZr7z3mzAsk?=
 =?us-ascii?Q?Ycr8Qd6l5tZyZxbTXi+qDVl6pbU2GnmsHFOnLvd2HCSamAdNB1qbsfCbQHik?=
 =?us-ascii?Q?/IIyFzumW1DEDARB0fMMxakZWKUy2jiT194DGTb0ibabm9qqeN34DTBixcRg?=
 =?us-ascii?Q?WakC0CwspaAihLGhSNCL65gMQnWU03KYx0BfkTkkgNSxLRN+h835bkIZhxoC?=
 =?us-ascii?Q?uWdIlRSU48B+m1/z5i8pMmKqFaJw3u0KWwqmha/KLx2Er0TmjyP+9vF9TppD?=
 =?us-ascii?Q?hoKEPPXNrhEdDOoiSbxXroEw9J4iffJgWdJnGcD+RXBTA2TrDYPpvIIWpJB5?=
 =?us-ascii?Q?WAIx/tw3bsK4LbbS46Tjdi3xMFtkUiM8vWBFdggDb/6+wUr/sttHCoZpA7ur?=
 =?us-ascii?Q?EVIiQb7VkGUIfs0D6V9BTmJgYkyM7UcDbj5nAE7LHcd/lyg3Zm2M8SpSIVKJ?=
 =?us-ascii?Q?Zl82d2OvvlAPArRJvPfUdAIypXpSeQPOCGWV5tFXPI2z9otYmKbWAJitc3pr?=
 =?us-ascii?Q?1T9Jf5tuwJGyABk0AvjImz0KWeWF3MCT3v0o+QUG26skOrau3vhq5XH0fstY?=
 =?us-ascii?Q?lpLRuxVGW2hci81QCiJ+PfuZ3SGdG9zOybfUKdC+aneMZbWYBaYl81MFC7Ng?=
 =?us-ascii?Q?CWupW5Y4bKYWwfz4wsQ0AYNhQok5FXyjshVHjjZ0LYZABRjTLpIXkQu2kxwd?=
 =?us-ascii?Q?oU9YrUWH6sEHmAeiGFnson0p13XLGQikEpl2HTQK?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1693.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 52b909fb-0bde-4dfc-7c85-08dad2eac7d7
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Nov 2022 15:51:44.3002
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: eIubp9ni6C1WDs//R5PS2HWG56BlN5pu5e7L7BRARc+liKYTPLDWidrVRRbMVpO0Y4KAQ0qYrkINaDD5OmUYPQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6547
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>On Mon, 28 Nov 2022 14:55:21 -0600 Jerry Ray wrote:
>> These statistics are maintained by the switch and count the packets
>> dropped due to buffer limits. Note that the rtnl_link_stats: rx_dropped
>> statistic does not include dropped packets due to buffer exhaustion and =
as
>> such, part of this counter would more appropriately fall under the
>> rx_missed_errors.
>
>Why not add them there as well?
>
>Are these drops accounted for in any drop / error statistics within
>rtnl_link_stats?
>
>It's okay to provide implementation specific breakdown via ethtool -S
>but user must be able to notice that there are some drops / errors in
>the system by looking at standard stats.
>

The idea here is to provide the statistics as documented in the part
datasheet.  In the future, I'll be looking to add support for the stats64
API and will deal with appropriately sorting the available hardware stats
into the rtnl_link_stats buckets.

Regards,
Jerry.