Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 30 Nov 2022 17:00:41 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Jerry.Ray@microchip.com
Cc:     olteanv@gmail.com, f.fainelli@gmail.com, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3] dsa: lan9303: Add 3 ethtool stats
Message-ID: <Y4d+KcqQQzKBpo8z@lunn.ch>
References: <20221128205521.32116-1-jerry.ray@microchip.com>
 <20221128210515.kqvdshlh3phmdpxx@skbuf>
 <MWHPR11MB1693C29AFEAE5386D0EE3AEFEF159@MWHPR11MB1693.namprd11.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <MWHPR11MB1693C29AFEAE5386D0EE3AEFEF159@MWHPR11MB1693.namprd11.prod.outlook.com>
Precedence: bulk

On Wed, Nov 30, 2022 at 03:57:35PM +0000, Jerry.Ray@microchip.com wrote:
> >>  static void lan9303_get_ethtool_stats(struct dsa_switch *ds, int port,
> >>                                     uint64_t *data)
> >>  {
> >>       struct lan9303 *chip = ds->priv;
> >> -     unsigned int u;
> >> +     unsigned int i, u;
> >>
> >>       for (u = 0; u < ARRAY_SIZE(lan9303_mib); u++) {
> >>               u32 reg;
> >>               int ret;
> >>
> >> -             ret = lan9303_read_switch_port(
> >> -                     chip, port, lan9303_mib[u].offset, &reg);
> >> -
> >> +             /* Read Port-based MIB stats. */
> >> +             ret = lan9303_read_switch_port(chip, port,
> >> +                                            lan9303_mib[u].offset,
> >> +                                            &reg);
> >
> >Speaking of unrelated changes...
> >
> 
> Cleaning up a warning generated from checkpatch

Cleanups a good, but please put them in a patch of their own.

https://www.kernel.org/doc/html/v4.10/process/submitting-patches.html#separate-your-changes

   3) Separate your changes

   Separate each logical change into a separate patch.

Andrew