Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Veerasenareddy Burru <vburru@marvell.com>
To:     Leon Romanovsky <leon@kernel.org>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Liron Himi <lironh@marvell.com>,
        Abhijit Ayarekar <aayarekar@marvell.com>,
        Sathesh B Edara <sedara@marvell.com>,
        Satananda Burla <sburla@marvell.com>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
Subject: RE: [EXT] Re: [PATCH net-next v2 2/9] octeon_ep: poll for control
 messages
Thread-Topic: [EXT] Re: [PATCH net-next v2 2/9] octeon_ep: poll for control
 messages
Thread-Index: AQHZA/PZs+9RX6z1+0m5ZGIy8eBWva5XNNSAgABoFsA=
Date:   Wed, 30 Nov 2022 15:44:30 +0000
Message-ID: <BYAPR18MB242397C352B0086140106A46CC159@BYAPR18MB2423.namprd18.prod.outlook.com>
References: <20221129130933.25231-1-vburru@marvell.com>
 <20221129130933.25231-3-vburru@marvell.com> <Y4cirWdJipOxmNaT@unreal>
In-Reply-To: <Y4cirWdJipOxmNaT@unreal>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kbooCD5D9XhEwh9Ghb1ZK4Zk/HoYrzBKnry1ZxO5xXcETWDRZ1micNbgpfuO?=
 =?us-ascii?Q?Fymp1BwYHb3muETy2nKwDVcC/w57F31abnAclr/d+VeyTcv+EIDIGENke83w?=
 =?us-ascii?Q?SmpRE1Pd5n0AagMicY2V0u64uaASWByUom2LHuIfU59SD+QwECT4bjOrbQWR?=
 =?us-ascii?Q?wgouTR56rbySww3eBXOfgASV/l0vNhzLZZfJCGSchyOz18JmZg4N/KKNwM4x?=
 =?us-ascii?Q?fE562m8yncLUrnpYoetuu7P+eJzjD4TfraVBgJCiGorCeeRtGcnh2dyww98H?=
 =?us-ascii?Q?Ex13Rwd24fSGU3IwIsqwumc30TNyDGP16+qxtDGSlbj1IGu5wCtK00NG/zD1?=
 =?us-ascii?Q?B8bYscnCyrfB9XJxuewwCVIuItDRc4ekta4mX5NJ8elruDDaXqhNlkpodk/1?=
 =?us-ascii?Q?4a8Irh3l7sGrJiayh4sSB9XUG+HMGbug4ms5pQvi/fbjSyz0nAWVcsTOstd8?=
 =?us-ascii?Q?3OdZ6Sg0e/6chHawP7DUtu/weJyaRWtpscVIJYHYOhhg/gsyc0p1ZK3BsDk5?=
 =?us-ascii?Q?rgeP6hFhiqdHIKUy680V32VgHLNWdJIogKlNDyyXBtEg9G8ewmSoQRNGk5Ao?=
 =?us-ascii?Q?IeMub7q7b0Ps9qw79LolQ+U78+eoCl9F5RMwQ+kI7nagSnkBaJlMAicj0aVb?=
 =?us-ascii?Q?lqWudI+Bmz6oADamhzQxKUERZohT4GsJ2Jodl+zPMwueJDcKU2A5aO4LN3aP?=
 =?us-ascii?Q?Dcm2zQQotPxta+V1MgpGmaTb/UFMfdWEkkR+F2Nk7YyB48arvpEo9PyTk8H4?=
 =?us-ascii?Q?dgCP/x/zGnXYBf1CbpWIhf6ioZp3xGx+PQzczUDWHOZqLK4vO3Cp30tiYdxp?=
 =?us-ascii?Q?CXQEs/De2H0QeqU/zzQDyavTzZHeODY8ya9OKdOp8/bwuvsQF5uQmpINBkuF?=
 =?us-ascii?Q?EPZrnm9LJew0K2n8RbYeLTci3vJmbbh9XLl4ukefbI35havlsa5Tw12tPtPF?=
 =?us-ascii?Q?WG4V/LRTd8TCo9xOkSqrZSgNqCJzP1nHVDfZ/LO4vWRXuTmJ4g1NIJf3lEjB?=
 =?us-ascii?Q?vIDGQFRIm/pNrcLaHqofVFilc/+4rsXxodOwAZMHf2GtO4ejhWuE3mESFygk?=
 =?us-ascii?Q?/nzxonxqzxrQAtX1UHpB41V7yEZ+3+mrlRnk6C4yx98gJRbiAgXJApBSTrmO?=
 =?us-ascii?Q?8Fb8My1FT0/8pehkJ7InXAdB0kcwNq0ktp4yaxEZp/rCuN8zrUHxHq6mWjTF?=
 =?us-ascii?Q?5kOCZW/PBG0N7b62KiJ+m7XvbCZJYlXh0Mnk3Ot1377hIJtO4lqEHy2W+G6R?=
 =?us-ascii?Q?y389WJYRXt4V0YrT+q6rCwDTOWLCuJsHVznqFKgU98n6qDxfxGQsZ9RA9QDu?=
 =?us-ascii?Q?ewLXDttWlNfQ9EUrfcMcL9IGK4kyhcUDryJoQJibRlh257ximJgRd3N/+P/7?=
 =?us-ascii?Q?kfN5iU0RsjPgy9qQMojoOwwetBPB+pB2fRraSJKXHoVIsjnRAWdyUls9X9Xm?=
 =?us-ascii?Q?jFHIZPT7GOuvxiLSmFeoNGRUvTY+dkkf+gBhK8H9khzk4+lmk9YaD3Qqiwba?=
 =?us-ascii?Q?AQbYsR3jV+v/HRHbF0+fD0SZRbocv21Yx1v9rWYv8ZUx7ZeDS93CR92p2ZWB?=
 =?us-ascii?Q?CbK538q7/VBKomGTCTU=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR18MB2423.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9bb74de6-9233-4a76-3809-08dad2e9c58c
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Nov 2022 15:44:30.9547
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: qTHI9H9dcCw4YlCUNcB/xCW1fECeErc+/bAwXxm5xksGo6DKm2j+DUeinXf3XrgDQ7zKQm8ObVPpNtU6/hOtzA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB4781
X-Proofpoint-ORIG-GUID: KCNp_7rpFVMTpKVn-f23M6m7ucqu-MSH
X-Proofpoint-GUID: KCNp_7rpFVMTpKVn-f23M6m7ucqu-MSH
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-30_04,2022-11-30_02,2022-06-22_01
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Leon Romanovsky <leon@kernel.org>
> Sent: Wednesday, November 30, 2022 1:30 AM
> To: Veerasenareddy Burru <vburru@marvell.com>
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Liron Himi
> <lironh@marvell.com>; Abhijit Ayarekar <aayarekar@marvell.com>; Sathesh
> B Edara <sedara@marvell.com>; Satananda Burla <sburla@marvell.com>;
> linux-doc@vger.kernel.org; David S. Miller <davem@davemloft.net>; Eric
> Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>;
> Paolo Abeni <pabeni@redhat.com>
> Subject: [EXT] Re: [PATCH net-next v2 2/9] octeon_ep: poll for control
> messages
>=20
> External Email
>=20
> ----------------------------------------------------------------------
> On Tue, Nov 29, 2022 at 05:09:25AM -0800, Veerasenareddy Burru wrote:
> > Poll for control messages until interrupts are enabled.
> > All the interrupts are enabled in ndo_open().
>=20
> So what are you saying if I have your device and didn't enable network
> device, you will poll forever?
Yes, Leon. It will poll periodically until network interface is enabled.
>=20
> > Add ability to listen for notifications from firmware before ndo_open()=
.
> > Once interrupts are enabled, this polling is disabled and all the
> > messages are processed by bottom half of interrupt handler.
> >
> > Signed-off-by: Veerasenareddy Burru <vburru@marvell.com>
> > Signed-off-by: Abhijit Ayarekar <aayarekar@marvell.com>
> > ---
> > v1 -> v2:
> >  * removed device status oct->status, as it is not required with the
> >    modified implementation in 0001-xxxx.patch
> >
> >  .../marvell/octeon_ep/octep_cn9k_pf.c         | 49 +++++++++----------
> >  .../ethernet/marvell/octeon_ep/octep_main.c   | 35 +++++++++++++
> >  .../ethernet/marvell/octeon_ep/octep_main.h   | 11 ++++-
> >  .../marvell/octeon_ep/octep_regs_cn9k_pf.h    |  4 ++
> >  4 files changed, 71 insertions(+), 28 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_cn9k_pf.c
> > b/drivers/net/ethernet/marvell/octeon_ep/octep_cn9k_pf.c
> > index 6ad88d0fe43f..ace2dfd1e918 100644
> > --- a/drivers/net/ethernet/marvell/octeon_ep/octep_cn9k_pf.c
> > +++ b/drivers/net/ethernet/marvell/octeon_ep/octep_cn9k_pf.c
> > @@ -352,27 +352,36 @@ static void
> octep_setup_mbox_regs_cn93_pf(struct octep_device *oct, int q_no)
> >  	mbox->mbox_read_reg =3D oct->mmio[0].hw_addr +
> > CN93_SDP_R_MBOX_VF_PF_DATA(q_no);  }
> >
> > -/* Mailbox Interrupt handler */
> > -static void cn93_handle_pf_mbox_intr(struct octep_device *oct)
> > +/* Process non-ioq interrupts required to keep pf interface running.
> > + * OEI_RINT is needed for control mailbox  */ static int
> > +octep_poll_non_ioq_interrupts_cn93_pf(struct octep_device *oct)
> >  {
> > -	u64 mbox_int_val =3D 0ULL, val =3D 0ULL, qno =3D 0ULL;
> > +	u64 reg0;
> > +	int handled =3D 0;
>=20
> Reversed Christmas tree.
Thanks for the feedback. Will revise the patch.
>=20
> Thanks