Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 30 Nov 2022 18:21:00 +0100
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Markus Schneider-Pargmann <msp@baylibre.com>
Cc:     Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
        Wolfgang Grandegger <wg@grandegger.com>,
        linux-can@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/15] can: m_can: Wakeup net queue once tx was issued
Message-ID: <20221130172100.ef4xn6j6kzrymdyn@pengutronix.de>
References: <20221116205308.2996556-1-msp@baylibre.com>
 <20221116205308.2996556-3-msp@baylibre.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ywc2a6fjnuomftcw"
Content-Disposition: inline
In-Reply-To: <20221116205308.2996556-3-msp@baylibre.com>
Precedence: bulk


--ywc2a6fjnuomftcw
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 16.11.2022 21:52:55, Markus Schneider-Pargmann wrote:
> Currently the driver waits to wakeup the queue until the interrupt for
> the transmit event is received and acknowledged. If we want to use the
> hardware FIFO, this is too late.
>=20
> Instead release the queue as soon as the transmit was transferred into
> the hardware FIFO. We are then ready for the next transmit to be
> transferred.

If you want to really speed up the TX path, remove the worker and use
the spi_async() API from the xmit callback, see mcp251xfd_start_xmit().

Extra bonus if you implement xmit_more() and transfer more than 1 skb
per SPI transfer.

Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--ywc2a6fjnuomftcw
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmOHkPoACgkQrX5LkNig
011ZaQf/T1Ml8VqPmN3bD3/UOmPiK48QEwmTT3LsUIiKljMGDhar4ApPMhBCtJH4
GL/SYMkFpB/PmS+I80sL4FtCRoqqsP5wURI4BsWvrfboZU4ZyT7507fwP4bNFT7g
ikyy9j7HWuU/kbyWPpkpK70LPWEC3EHzR9c/g6S0EwFzbHWAJNmyV87BUu2KRSUB
ohMgWjno+q/b/3p0bus+Cus5P0aDv4Q7kz6H8qulESQq9Yx+am1MkxeB+7xyDY9e
u9MnFnZuVNJ4FUiZEfky9e/rk1CbY2YPm3tpJvYlXx+zfgTm0ApwvYgeQ57u0irT
0lyiUXHvhMej67pscPNrxTcEQRc5fg==
=QDMo
-----END PGP SIGNATURE-----

--ywc2a6fjnuomftcw--