Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ce549bc3-7e54-b1d3-7ec5-4cde66bd468f@intel.com>
Date:   Wed, 30 Nov 2022 08:33:51 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.5.0
Subject: Re: [PATCH v4 4/5] selftests/resctrl: Cleanup properly when an error
 occurs in CAT test
Content-Language: en-US
To:     "Shaopeng Tan (Fujitsu)" <tan.shaopeng@fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Shuah Khan <shuah@kernel.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "Shuah Khan" <skhan@linuxfoundation.org>
References: <20221117010541.1014481-1-tan.shaopeng@jp.fujitsu.com>
 <20221117010541.1014481-5-tan.shaopeng@jp.fujitsu.com>
 <af1b4e59-2b4b-ddbb-2218-0e2808b718a3@intel.com>
 <TYAPR01MB6330CDB2C59C58EE77B912538B0F9@TYAPR01MB6330.jpnprd01.prod.outlook.com>
 <ba5a9ef2-b4ca-5c90-cc03-2296586455a6@intel.com>
 <TYAPR01MB63300F91A0755310E78D98308B159@TYAPR01MB6330.jpnprd01.prod.outlook.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <TYAPR01MB63300F91A0755310E78D98308B159@TYAPR01MB6330.jpnprd01.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SGNLOEZuQzBqS3BTR0hlbFdOQ1gvdkwzU2tMTFl1a2NMUG42c3ZkK0o1Rkw2?=
 =?utf-8?B?QTVheXBMTHFPckRJMUZDc01ndHd6cHY3QllLT2t6K0tJeGlyc01UL2ZEcGVi?=
 =?utf-8?B?c2IyRERUVjJXY1lCOXhJQzNxblRxS2Z2Uld5LzA5ci95U3NGYWZIM1JDdVZQ?=
 =?utf-8?B?cTVyRkNLVHRLS1dUdVVreG1tMDc3bnltY2IwUzJDcE1paW8wZzV1UW9zTzha?=
 =?utf-8?B?clNtUUpnSUp2UnFGVUVtcXVrRUVRTGMrUi90YkRMdUU3VVZoRUxuV2U4M0xP?=
 =?utf-8?B?SUxpZElzQmg5WDJLNFM4elBZNE8vK1g3VlRKL2xPa2x5eTFiSzQvVmRxYVpU?=
 =?utf-8?B?azIxSE9aQkNtRFkwWXovWFQ1Nmk5cFEvS25vN3czV21tRFRnOTA5bmdraC9Z?=
 =?utf-8?B?VEd2QkFIa1ZUUkEzbHJGbU16Qjg4eWhkRHZCWW1KUmJFVUhXMDluVGRmTnRq?=
 =?utf-8?B?a0VGUmhkd3UwTG1pT1J6cDB5a3RJL1NtVmxIY3hxVEJFbU5FWHVIZ3cwMHIv?=
 =?utf-8?B?SFhQOHpseGFTQ3lvN0pLM1hRNVNJdDBROWlhbExHOFlaVlJFUTJOTk5TMTYz?=
 =?utf-8?B?d1oyM0pyb0VtZ2prOUViWVhZUTZZS0hOM0lsbUlkdjhKOHhnOE5VM1d6c215?=
 =?utf-8?B?WEc5MEc2TzJKQ1BNM2c0K29XYVo3Y3YyWVc2bGFQUklVRU1uY2RSaEtmS3hv?=
 =?utf-8?B?TWhXS3FuUFpLQzlicFR6UEE5enJpZTFmU1FJV3JiK25xNy8wYTRYNGpVaHlN?=
 =?utf-8?B?OERBQmhXb0tQcW50elRKMHUrMnNxOEFEQ1VWQTVkRGwwQXRPQVdod0diM3Bs?=
 =?utf-8?B?dE5CTEFzSVZxRTUrZW8xbWhELzM1TlVZM2dTcjVyOExNS3dTN2I1aE45Y1pG?=
 =?utf-8?B?c2FGQmNWa2xDQjduSXQvUDZObFFoQXpjWE5QV2hiY0w0YjN3Qm12UXVweFBT?=
 =?utf-8?B?OUYvNDM1V1M1LzBJWHk0amFVOUVUMEZwTm9UMUQ1UVNOaDhkL1NJdHEvdUg2?=
 =?utf-8?B?emJ4V3NHSFY1TGExczkxQ2RwaGFFS2ZzRlpqOTRiSXhybWl5akg2d2x2ODNv?=
 =?utf-8?B?bVhKaHVBdFhaVmcva0NSQnF3NnBlY2x1OENJMFEzN0xCd2ljeHlxU2c0NHRm?=
 =?utf-8?B?RXdrQ0FvcThUNEVXWGg3UUVXTzhIZGZ6eWRkTDFnOTl0N052d2xFc09FdzNV?=
 =?utf-8?B?UTdWdTJjZDhwVnhYTStyVlJDSnFHa2QzdGN6by9hZ1ZsaERnalBqK2hnMndX?=
 =?utf-8?B?ZTdaRGt2eUlBRmJCYTVVY0Q4RzFpVndNajNKYlloU3FyRkFQcW9BOGI0OXVu?=
 =?utf-8?B?blo5Wndwa0ZSNyt6TXI0d3FZQlA3Wlk3NlVOMDExYnJRQXFQeG5vRUNpNGJo?=
 =?utf-8?B?eCtKOWUydFNwS2YyNUJVcEtPRWRGMDZpUGZ3aHVpSVNZMVpzb0ZjMGdoTXlz?=
 =?utf-8?B?N2pZT0N1Uis3MEFpMFpCb2FTSmVSYyt4SzVjRk41Z2xQVWJ5V2Vsa1lvVGNB?=
 =?utf-8?B?NjYyQzlneUtTbGtnK28rYWNPb1NjanNDdHFXU3lBOW1yTVdQWENlcWVwaDZC?=
 =?utf-8?B?a0JSOUNQZzd1M0xiYUlpK3ZSNlNIRjdiTFFsazQ4V1lmQllndEJVaW5MS3dr?=
 =?utf-8?B?ZW83M0cvdld3ckJOOHJNNElXZjN5OURNQU0wYVRuaHpTUnRLVnZjdW9QMkRF?=
 =?utf-8?B?TUNEK3FzWW9GRFBEUHowUEZzbCtTRFlPSmpjK2xjTFhMOExHcWI1cllqQXRq?=
 =?utf-8?B?ZmMyOTlYby9YRVJ6SVBIVDJWb0x2RVQ4TnpFWmJzZHVhaUpPMmhWZlF3UmZ6?=
 =?utf-8?B?S3FkU1k5QlJrS2J1Nm9mOEVJL2pkUDlUZjArT0E4T0VJRUxpNXk0czlRR1Bp?=
 =?utf-8?B?NHBFZXM0b1hIaWt3THdBRXdKUnlrOGcrV3JQZ3l0WEZCRkU3anRKaGl5eFh3?=
 =?utf-8?B?eXhIc1RxWGRZbjExQ0lVQzQ4dEN2ODhlUWxCOHBaNURBRjRkYktyeENYWWg5?=
 =?utf-8?B?Y3AvcjZtc1ViUk1pKzhoMVF2alFFQjNiRkJ1L01aMTEvc3Y1T29BUzhsNjBX?=
 =?utf-8?B?TE9QTFJhbkFTYjNJRHBJenM1YlhiMDJLMFc1SkRqT1g2VnFESGZoTXRJK2J4?=
 =?utf-8?B?SGlNWmx2WWQrUE5Qdk9GVWJVSExZRVJEREtiTy9WZ3VTT2tCWUFuazVEakFT?=
 =?utf-8?B?SGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a760945c-8353-42d1-89c5-08dad2f0ab61
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2022 16:33:53.7657
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8f6MlLO49Ybry+vKUYDmIlRet9b6D8BYPtMhWE+e7i0YaoHsWW6YLJ+EjQwcYqM3xCI3ZcLUu6HvaI5m2wH35nkp0awSkIMeWglpTqLcTXA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7688
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Shaopeng,

On 11/30/2022 12:32 AM, Shaopeng Tan (Fujitsu) wrote:
 
> Removing ctrl_handler() is only part of the fix in the next version(v5).
> All fixes as follows.
> 
> --- a/tools/testing/selftests/resctrl/cat_test.c
> +++ b/tools/testing/selftests/resctrl/cat_test.c
> @@ -98,12 +98,17 @@ void cat_test_cleanup(void)
>         remove(RESULT_FILE_NAME2);
>  }
> 
> +static void ctrlc_handler_child(int signum, siginfo_t *info, void *ptr)
> +{
> +       exit(EXIT_SUCCESS);
> +}
> +

Could you please elaborate why this is necessary?

Reinette