Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 30 Nov 2022 17:16:11 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Matthias Kaehlcke <mka@chromium.org>
Cc:     Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>,
        agross@kernel.org, andersson@kernel.org, lgirdwood@gmail.com,
        robh+dt@kernel.org, quic_plai@quicinc.com, bgoswami@quicinc.com,
        perex@perex.cz, tiwai@suse.com, srinivas.kandagatla@linaro.org,
        quic_rohkumar@quicinc.com, linux-arm-msm@vger.kernel.org,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
        swboyd@chromium.org, judyhsiao@chromium.org,
        devicetree@vger.kernel.org
Subject: Re: [PATCH] ASoC: qcom: lpass-sc7180: Add maybe_unused tag for
 system PM ops
Message-ID: <Y4eP2yFKsmxzyX/4@sirena.org.uk>
References: <1669726428-3140-1-git-send-email-quic_srivasam@quicinc.com>
 <Y4eN4utrDnEnKu/8@google.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="6SJAvmLG8+E8QRmv"
Content-Disposition: inline
In-Reply-To: <Y4eN4utrDnEnKu/8@google.com>
Precedence: bulk


--6SJAvmLG8+E8QRmv
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Nov 30, 2022 at 05:07:46PM +0000, Matthias Kaehlcke wrote:
> On Tue, Nov 29, 2022 at 06:23:48PM +0530, Srinivasa Rao Mandadapu wrote:

> > Add __maybe_unused tag for system PM ops suspend and resume.
> > This is required to fix allmodconfig compilation issue.
> > Fixes: c3bf7699747c ("ASoC: qcom: lpass-sc7280: Add system suspend/resume PM ops")

> This is incorrect, it should be '2d68148f8f85 ("ASoC: qcom: lpass-sc7180: Add
> system suspend/resume PM ops")'. I see you fixed that in v2, but this patch
> has already been applied ...

with the fixes tag already updated as I was applying it.

> Mark, I appreciate you being responsive and picking patches quickly, it might
> help though to leave 'external' reviewers at least some time to provide their
> feedback :)

There's a balance with hanging on for utterly trivial patches to get
reviewed, especially in areas where reviews aren't relaible or
consistent.

--6SJAvmLG8+E8QRmv
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmOHj9oACgkQJNaLcl1U
h9CVTgf/Yk6JQALmBhkO871ntVkBaSxGqlp+3vln0kZMki5ZCf9OWnSUtXUmaUk/
Vmk6rTe1hZ7fKFIcV1q1D6y8OnlRPFTBbCZl8OwPBESHXxFm3kWkiBpReuEr4Lzl
x9H399V3j+XaqQH2a7a08ls4Xr+L7pcnP6jIqmTp2H0axiGSWoxxBbIBeNO/BSoF
nYuaDojavoLEjR4LOyCgzGu1+E+NFeqrE2lkdlhc9KWObJ5a2iaRgCkXq6SdYJmH
wcqu9ldjoiWBJElKShLPW/2OKS2ADP7IVNi8QngsYt6iYO8p58lCOnfI58vhpdwR
/LsOtpk0Wtk94W2lYsNxwf3TYWQQbg==
=0l3+
-----END PGP SIGNATURE-----

--6SJAvmLG8+E8QRmv--