Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2738676rwb; Wed, 30 Nov 2022 10:10:49 -0800 (PST) X-Google-Smtp-Source: AA0mqf5Tsa5IATsCA8qfdQCdOry0OMDu0J8jZhtNrMg3MrqSEc0R+Koj+0ij6/erIMoof9KGV7kw X-Received: by 2002:a05:6402:4028:b0:467:c33e:edd6 with SMTP id d40-20020a056402402800b00467c33eedd6mr4099984eda.146.1669831849601; Wed, 30 Nov 2022 10:10:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669831849; cv=none; d=google.com; s=arc-20160816; b=YGdv4+5HUuoffy906eLfWgQb93ch1RIT/OEj77nRq8++0f4nGtW7fKFWIoGTaO205g YsJz70IXxyBBVwRKTlQMBhDltwZWmoRocMqdJg0j9JFjUaDmbTAHs9D4fJ1mRYFQjtsd oUhD2nPBbQqnp12/j1icvufOk33F/nDFYTs9Xs2WkPbfiLI9L6XSk5/R+HOoE0NhkNnT J3WxzcW1OEg7JVrZ642OaZy7993neihuKb04IRM5maHspLO1LUrl9XXtRLpgJeJXwHZX BTUY9bbqy9+LgzDFF5JTBUzp8uwwM41/YRh6j1EFL0/jAFUgd8r+Oqb/v95KOlZ7fc5D Hsow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=gYhV1pkLE7/VIfbsCrMpLxmO+6AVZfk0sX0HWTswr9o=; b=YBpa8KsgOOZcYfAjO+n3hemFV9XyC4iyhKmbvskkoJtsFtt67rnRlb9n9sRF36LDgH ZU19GElip6x+qHSvFewXKhdIprhB1jJGsGW/isXWxGCN34xbhTob8deNXYD5L6KRJN6s ZM45pUo+LMcyXfssLScxTIF8lexLwgEq64sn2htEkzQAqvALtC0PAKdVtQNjo3++YYsh 22Yi0C9uqU6tw1jpP6U/eqF7fvdBINDbFIArSkyf2hfSFwWLaRvbnGSqDt7fsYlaFtEl IO2WY6UR6vrX4VGi33iFaF9MjjRJaC6059FuKOKXRi9JXK7VCz3A/eFRx8+u8//xRyvh A9Fg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=X0wlVpFP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k3-20020a05640212c300b0046b2327bf88si1742400edx.76.2022.11.30.10.10.24; Wed, 30 Nov 2022 10:10:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=X0wlVpFP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230190AbiK3QZo (ORCPT + 83 others); Wed, 30 Nov 2022 11:25:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230187AbiK3QZk (ORCPT ); Wed, 30 Nov 2022 11:25:40 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A9F04E40D; Wed, 30 Nov 2022 08:25:38 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id C7819CE198B; Wed, 30 Nov 2022 16:25:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9D79C433D6; Wed, 30 Nov 2022 16:25:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669825535; bh=gYhV1pkLE7/VIfbsCrMpLxmO+6AVZfk0sX0HWTswr9o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=X0wlVpFPVP0ol2aYDuQx4iWJYMPUnIKVkbZCcBNN8Ei1KO3mY5lNAEya9x/IJvBrI IARieiF9iuNj+Svo9Ye8cUMe3U8OHhsWy+pYB7koqszORtkyWJfl/h7crGMulduePP 6GnqZVs5UZcPwrDIPvvq51sXzXkB5ujA0r+tufMm6XuGh6SAGiUww3qBCihZBVHp1U lRMfS0/LgyW/MLKI/Ltez4pM9gF9TIgfndwFf1STaNCgJK+K96JJt9tIxCSBdj9aQk 3oIOFma3ml6dFybTmhjvfylkvdP/OOio8YwpVRpgVH2FPTU8YxnSLGTQAm/VTHjxrK 1Ncvd4Vyw8CJg== Date: Wed, 30 Nov 2022 16:25:30 +0000 From: Mark Brown To: "Sverdlin, Alexander" Cc: "linux-spi@vger.kernel.org" , "lukas@wunner.de" , "linux-kernel@vger.kernel.org" , "linus.walleij@linaro.org" Subject: Re: [PATCH] spi: spidev: mask SPI_CS_HIGH in SPI_IOC_RD_MODE Message-ID: References: <20221130143948.426640-1-alexander.sverdlin@siemens.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="l3vPnKV0AbSKgmyt" Content-Disposition: inline In-Reply-To: X-Cookie: Jesus is my POSTMASTER GENERAL ... X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --l3vPnKV0AbSKgmyt Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 30, 2022 at 03:43:27PM +0000, Sverdlin, Alexander wrote: > On Wed, 2022-11-30 at 14:57 +0000, Mark Brown wrote: > > What about SPI_IOC_RD_MODE_32?=A0 On the write path the code is > > shared... > you are right, thanks for this hint! > I'll re-send if there are no objections to this approach in general. Should be fine. --l3vPnKV0AbSKgmyt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmOHg/kACgkQJNaLcl1U h9Aq2wf/QCWJZdoTNM9hzI08RKkd1miDHyWm4pNK9rXWBaAeLoSTAh5R4U7UDrIX 4Sr6ZZOLQ0IBFKrU/GjXLKwuVDahyW9c3C83PQn1X2p9Wmo04kmMlFiJ/0QdA3ze mDDPscWEu42prsyJb3eOdEcAiNZaHoVoovuLoIJCBMhv9BvjTDwdXq97pDtp7eha lhP/q2+nh6EA/j7z/WCeyjWU0SUIUj1C8BR6qgxcWOMpuzKhzYZD/VfV+2oKyTTo /lVdf+ixeWlJcN625yRxbtSUiUX+ltWEN68cUJTRGL9ulKblOBc3eT0XvhoMgoGF kQ88HasF+TrEWogPEai3k3Ra5TM2sA== =C5Ue -----END PGP SIGNATURE----- --l3vPnKV0AbSKgmyt--