Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2761675rwb; Wed, 30 Nov 2022 10:29:10 -0800 (PST) X-Google-Smtp-Source: AA0mqf4YbwqsnWFuIbfEsG7Zjyfg6Aq8CMfmuV5InnEHI0/nd1MEtNE0n6F0IwumT68dggoLJLOp X-Received: by 2002:a05:6402:3719:b0:461:4f34:d8f4 with SMTP id ek25-20020a056402371900b004614f34d8f4mr58360628edb.144.1669832950736; Wed, 30 Nov 2022 10:29:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669832950; cv=none; d=google.com; s=arc-20160816; b=lXxRhJVoFGuwrkyXNPtPFlGrV+EERy6eahfVi7UUmtB6y1JCpfh1hcTO+i8eTNVVbG idl+Ee7e81X7kmaNQavZqhAYbhzPCB7UTqgRkLugfBsucMaznoqhW8MemCi+zi7erVCN Ng5ogF1S8wUNHRukRYBXmzzoLeM8HHlcPFDuAOvPj8j6dxUJ2ZJwLqiLQZe8hpKNmw2R hmoROUvroTYMsReUUGa4RaCgZ6zxwwEhFh10uZX+lOR7n6WpgI7noG4h8hlnVAhcxssD 43MB8O3JPHphVFYYsLo176Hq7Lh2Co10AEq3aYuF93goKCWH53YmbHxqAeJ6BdVAr6nk lLEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=qYl9eamrN/o9V2phN9Tz5nOT280TdKaFY7cXZJlG/KU=; b=ZmKB3NnXW2nppJCr6/s10wI3HUSRjsbtDUtuFKVGd3ZUSh8gu4os5p4A1WH0tLQf20 yt+wu8rG9DrNeFWq/6v08yy4kDYvOmdkjC11wCkrr7h2dJIE9c1NALtmHrHtGFl7MR1l 0SWoPVKxbfcIPHtA1HZc/YNJnNcCWHLe44/lrMaB0+8otplrZf4OLDUuKlQKJFmdRAR7 CC8FUKMNguub3qX6duW7XczVh7TMlH5BDnvMEcoO9mC8EA2roc8ftbB8QWzQO94CCizf 5kx83YcgxEGpPEjR5gsoyggtGpjEsYEAbqA5mIHVTUM9Eq8VMlOuAalbx/mWPsZNSdud o1eQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=PKSNyHkb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p20-20020a1709060dd400b007ae6e307f60si1471758eji.323.2022.11.30.10.28.49; Wed, 30 Nov 2022 10:29:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=PKSNyHkb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230087AbiK3SRX (ORCPT + 83 others); Wed, 30 Nov 2022 13:17:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230018AbiK3SRC (ORCPT ); Wed, 30 Nov 2022 13:17:02 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E3139490C; Wed, 30 Nov 2022 10:15:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=qYl9eamrN/o9V2phN9Tz5nOT280TdKaFY7cXZJlG/KU=; b=PKSNyHkbpvE6kXeKbpHRWRzOIS Dk1jm4LTrZONw89eTbTe+U2JRFro9tEYC4aFbeEyNBTNqolJjFILGnm/VrW/9wsCkHIRFt2GWr10G /nB+cVXO/alzyt2e+88/D/fvDfQ8elKnEpqwKDh2c1VyaK1XfvJaLhli+T5h+cq419ng=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1p0Raw-003zGD-KQ; Wed, 30 Nov 2022 19:14:06 +0100 Date: Wed, 30 Nov 2022 19:14:06 +0100 From: Andrew Lunn To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: Krzysztof Kozlowski , Chester Lin , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Jan Petrous , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , netdev@vger.kernel.org, s32@nxp.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Matthias Brugger Subject: Re: [PATCH v2 2/5] dt-bindings: net: add schema for NXP S32CC dwmac glue driver Message-ID: References: <20221128054920.2113-1-clin@suse.com> <20221128054920.2113-3-clin@suse.com> <4a7a9bf7-f831-e1c1-0a31-8afcf92ae84c@linaro.org> <560c38a5-318a-7a72-dc5f-8b79afb664ca@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <560c38a5-318a-7a72-dc5f-8b79afb664ca@suse.de> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Please compare v1: There is no Linux-driven clock controller here but rather > a fluid SCMI firmware interface. Work towards getting clocks into a > kernel-hosted .dtsi was halted in favor of (downstream) TF-A, which also > explains the ugly examples here and for pinctrl. > > Logically there are only 5 input clocks; however due to SCMI not supporting > re-parenting today, some clocks got duplicated at SCMI level. Andrew > appeared to approve of that approach. I still dislike it but don't have a > better proposal that would work today. So the two values above indeed seem > wrong and should be 11 rather than 5. Just be aware, you are setting an ABI here. So your fluid SCMI firmware interface must forever support this. Andrew