Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Jerry.Ray@microchip.com>
To:     <kuba@kernel.org>
CC:     <andrew@lunn.ch>, <f.fainelli@gmail.com>, <olteanv@gmail.com>,
        <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net-next v3] dsa: lan9303: Add 3 ethtool stats
Thread-Topic: [PATCH net-next v3] dsa: lan9303: Add 3 ethtool stats
Thread-Index: AQHZA2vPxK4eDIuP5kOkg3W32g1dkK5U+YSAgAKmf0CAABFlAIAAFinA
Date:   Wed, 30 Nov 2022 18:12:54 +0000
Message-ID: <MWHPR11MB1693909B5E06A7791F0FD079EF159@MWHPR11MB1693.namprd11.prod.outlook.com>
References: <20221128205521.32116-1-jerry.ray@microchip.com>
        <20221128152145.486c6e4b@kernel.org>
        <MWHPR11MB1693E002721F0696949C5DCBEF159@MWHPR11MB1693.namprd11.prod.outlook.com>
 <20221130085226.16c1ffc3@kernel.org>
In-Reply-To: <20221130085226.16c1ffc3@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?llgqfZTp65sow6o4xNeh6gOBeq3iqDGmHI/5e6hk6VAA+1sJP4gHwJjhinPV?=
 =?us-ascii?Q?IvyvYyfH7m8jOWz8RBt0ZTqOxG9FGrwfWmuJ329hjDEE1VWBCQY1wVFNdjX2?=
 =?us-ascii?Q?jMyLQwMzxFgW70/6V0l0kYZAY2Xswk6DIQQQtgqiVj4olTA485sPEplAyBO3?=
 =?us-ascii?Q?IFNljLNzm/qwDOOmLMcQt9UKiC553D2yIlGakU1861JZHm9ugFwd++u3AVP/?=
 =?us-ascii?Q?axjEWtR9UiexjguO/LP46Sb9yn57TelG3O5nRCYXv0vAo4AkX5Ow12HWRDK2?=
 =?us-ascii?Q?9g+b/YchJsWzkHzUIJLgq/oJnYKRWPJRDbc6EXpt0/EWRCwkuEv5n+T846uC?=
 =?us-ascii?Q?NL2510hFg44qtH/aHYmgqHy9QJWLnz6bE5iHaTVWY+RLEBA6g3L1vPzroZkg?=
 =?us-ascii?Q?GLWH/928KVWbr1kszcJEAdIYWnxFP2LS3L9vPiac95tyPDS8vOuMp0wqXtbQ?=
 =?us-ascii?Q?yrzad5zHZJe7uCupB0c9LFCs2wHPaGPdS633/3ZxhTICcWAcZBqoh0U10SWB?=
 =?us-ascii?Q?hlo4vCwdGHWdyBr1BwhhJaUVQPx1Rn/IsojD3UUFFQOWvsAz+A5DlTwr2gjs?=
 =?us-ascii?Q?KGrXLvslljxukxHPUIXSy9NNE8O7JXMPWSfjTwON75/vCNJw8GnO3eUjamLM?=
 =?us-ascii?Q?auAQ3sDcQl37XFC+gI2Xtr2jtqTrrdnV0i3WG1ar6+/HAJEmJ7bMvVY9e7Qg?=
 =?us-ascii?Q?wC/ZupQtHnU5wZ76qhs5/CWjACe0oF2xGMzfX4SwXu6NNmlEFCbUYSr5M4tm?=
 =?us-ascii?Q?l4/GQYz21nTFBGPh5kzklu4XxTXIhVSJaelrECK3S6gdYwua0Rv/rh644gvV?=
 =?us-ascii?Q?/c/QUXe+bNATbTIkZwlYArcbMymwthC1SIro+FRZ70o5ijQLwk+fwc1iHZbs?=
 =?us-ascii?Q?9cLapi+kYujq0d0YAeYpx/TVrkRFlYko3OhFoIJ6IM3mPd8giokECkfeCTq2?=
 =?us-ascii?Q?TZzKzb+Ym1jSublI3SH/qq29F7Tn1awwqmXlY+mxxP9NSLLSSiqO1Em5eV82?=
 =?us-ascii?Q?DpfY4c3/Os8LTuISlhioIG3/33llvXk13mybtQHW05QDw+oIbnyjHFsRUNX0?=
 =?us-ascii?Q?BrISjeZhEEJjhlhSc00GJB2df2llg2rFSe/CYKVK+wjh2nvwdzoctF8rD9Ao?=
 =?us-ascii?Q?Q/vQ2VA5K53Bik66wunSAmhk98YKvWITajXQwI+pj947DVpFnjT8DY7QryJe?=
 =?us-ascii?Q?48oVCurf6HP9JiS+2iizjG22mBG/B2KCbPfNdl2SrbMi4Ph+vPksdD+c0pVJ?=
 =?us-ascii?Q?MtalGBgTL2YlJOUgSte77eHMBlVnUVUQcfsF7zUXgAi6eIgvyGG8M93fBSw8?=
 =?us-ascii?Q?gJ/3HYloVW83AzqJl8FBk4jB1TbUx7jBEdaf0/XsLUD1GrXGzoj8PfHbqmvc?=
 =?us-ascii?Q?yFMDFrL1jUUbdx5PpP2bYHMLDWaOYv/aOwFrTcEDwaS7+H8IpWHO3qDkZhs/?=
 =?us-ascii?Q?NdNWH2JLufQ4WXm9Vymx133HZC5swTksWoP2oSh5BEuf7h/zPe1j69M6ByP9?=
 =?us-ascii?Q?Gz4Tgbaoq04WVU6VDXTHvCQ1FUbCydtL/ciwWjigC8WiUQ9aeXJOUQfYAHeC?=
 =?us-ascii?Q?9uxdC0f5uJEIj39u2PKZUfLPuPJI9ptZ73RcNB+1?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1693.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e442a461-4f5b-44ff-2304-08dad2fe8078
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Nov 2022 18:12:54.4917
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 8I6Pq+32qpTdkmABTyte6ohIye8+5i9YUSfoEygokBmOa7dsVZAfDNPDZr8SOhYvN+9XF5bHYkbSvorttCg0tQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6382
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>>> Why not add them there as well?
>>>
>>> Are these drops accounted for in any drop / error statistics within
>>> rtnl_link_stats?
>>>
>>> It's okay to provide implementation specific breakdown via ethtool -S
>>> but user must be able to notice that there are some drops / errors in
>>> the system by looking at standard stats.
>>
>> The idea here is to provide the statistics as documented in the part
>> datasheet.  In the future, I'll be looking to add support for the stats6=
4
>> API and will deal with appropriately sorting the available hardware stat=
s
>> into the rtnl_link_stats buckets.
>
>Upstream we care about providing reasonably uniform experience across
>drivers and vendors. Because I don't know you and therefore don't trust
>you to follow up you must do the standard thing in the same patch set,
>pretty please.
>

Won't be able to get to stats64 this cycle.  Looking to migrate to phylink
first.  This is a pretty old driver.

Understand you don't know me - yet. =20

Regards,
Jerry.