Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 30 Nov 2022 13:19:05 -0600
From:   Rob Herring <robh@kernel.org>
To:     Marek Vasut <marex@denx.de>
Cc:     Pavel Machek <pavel@ucw.cz>,
        Christoph Niedermaier <cniedermaier@dh-electronics.com>,
        linux-kernel@vger.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Jacek Anaszewski <jacek.anaszewski@gmail.com>,
        kernel@dh-electronics.com, linux-leds@vger.kernel.org,
        devicetree@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: leds: Mark label property as deprecated
Message-ID: <20221130191905.GA2631320-robh@kernel.org>
References: <20221122111124.6828-1-cniedermaier@dh-electronics.com>
 <Y3y/S5COG7VPbsqL@duo.ucw.cz>
 <3f4c89a3-8955-ce41-ac2a-cee9b0ed5210@denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3f4c89a3-8955-ce41-ac2a-cee9b0ed5210@denx.de>
Precedence: bulk

On Fri, Nov 25, 2022 at 10:26:30PM +0100, Marek Vasut wrote:
> On 11/22/22 13:23, Pavel Machek wrote:
> > Hi!
> 
> Hi,
> 
> > > Mark the label property as deprecated as it is mentioned
> > > in the description.
> > 
> > Lets do it the other way around. Functions (etc) don't really provide
> > good enough description of LED, and label is still needed.
> 
> Can you please provide a clear explanation which property or approach is the
> correct one for new DTs ?
> 
> So far, the documentation states that "label" is deprecated, and users
> should replace it with "function" and "color".

'function' is what activity/operation the LED is associated with. It is 
a fixed set of strings which s/w may use. It is a replacement for 
'linux,default-trigger'.

'label' is what is printed next to the LED for a human to read. 'label' 
can be anything and the OS shouldn't care what it is.


They serve 2 different purposes.

Rob