Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2920488rwb; Wed, 30 Nov 2022 12:45:09 -0800 (PST) X-Google-Smtp-Source: AA0mqf7QCKlLFz+IUAiOdaAa5VT6c9zHCZ6Ga54XoSivuas715MABgjUvTM6VXAdHw7+Evm63Lun X-Received: by 2002:a17:906:8465:b0:7bd:7253:457a with SMTP id hx5-20020a170906846500b007bd7253457amr20912240ejc.81.1669841109009; Wed, 30 Nov 2022 12:45:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669841109; cv=none; d=google.com; s=arc-20160816; b=cJiH9wu0d8EwyOhq4i1W4wTPGbYUTlQ1zk+ZhmUpu/ZGX4U8+L5D9c1BMPJAqBLnqJ zLnWLAqkI4w5BeSISp+MStQPT/y+IvXpS0nAVgGMoe7/qwKVeg++j95+RXf+tVEQIaVi YmMPg0S0yly9sVOOdHD5XixysMb9BqGa8XE4FEimr4Gz7vak3Q886an3HlJTr8ASVjmC MyXu7QAsIvyOdwDw/XUNTmuofIjrB21PxxCA8Upl5izdXH0LnXgoG4mEX5bzRPLdTmwl 5zwJ7Ndbxr6ToSLo3HM1JzY7WxksuThB1w7UaoDNwXIrQTbqG8Fr3hGRIP05cdISUm4S 9/5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=s+f73qQSWaZWQn5PMXIm5ddroitzO0fXj2VGSW5dgd4=; b=QaemuSMYBIXcdcrcbumjDo2tLrEomuDCZDyouV1cLY2w0RrckJjg7bar0zAUhcsIlS 2lhdyIafILFgyXmXA1i/Zwaz3IbgNJ5e1ljCLegf2EUmT8gFvoMA/SgorprQh3k0mGUt Vz08TgZHPdVUhD4fbmiLwr2hV9eBgbziILjezYjyfvmcJi/uXTvtQ84Fwi8i2Nk/mcY6 S1e7VUSoaHTfAG6VRlJynMmctbMm8ogLCqoOtLOY0f4jpZFb47CX6siPerSne9hCb/SN GXAkxCbwrpSW4GDZuzRDnrEUDl0AE/RDXRb58ZfHlXe5xYe0S0LerZVLYQtZERtpaSjQ TLew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=BGROMH3G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id wy1-20020a170906fe0100b007ba713e241dsi2044170ejb.894.2022.11.30.12.44.47; Wed, 30 Nov 2022 12:45:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=BGROMH3G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229532AbiK3Udn (ORCPT + 83 others); Wed, 30 Nov 2022 15:33:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229640AbiK3Ud0 (ORCPT ); Wed, 30 Nov 2022 15:33:26 -0500 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C4F88E5B7; Wed, 30 Nov 2022 12:32:21 -0800 (PST) Received: by mail-pj1-x1032.google.com with SMTP id v3-20020a17090ac90300b00218441ac0f6so2728489pjt.0; Wed, 30 Nov 2022 12:32:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=s+f73qQSWaZWQn5PMXIm5ddroitzO0fXj2VGSW5dgd4=; b=BGROMH3G14bf8t+5QZBF8EIw7DJlp2M69BITlayk5RGIWu5mNUNjLIwEntSuAXgoGO P87aZf2H9okTAtAvyUGhhYTXP1R1c0HvcGtF6oOmpH/AsjC2ZnLAUM+ZDFG50EtBaeM5 KGLxpgoe1IdmVLAWtMdASGG8Y3NNnio4jdbNm5Jbz8nofwg0orveW/0yTrYkaCQgsF+J kmWIYEdlCmYOvqZCmsZDw8NVEZcFR7/wa0FmfXM7HlJWFPXVTu95gDNR/uE6f8xdr5YO d7vb4ikzLzG+TKHr2tWloyVj9jbP7mTm2qutSQ17RdzICHvycDY59fIM+h5QlDG8du51 19ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=s+f73qQSWaZWQn5PMXIm5ddroitzO0fXj2VGSW5dgd4=; b=1cHyU0YoaHmzn97ZUIiHaackhSkGGGTfmPyUtglhkahfA+Ma8q/Ba3Jy8Ynyqsr5oq os4ONU6wqSZyN9wsyaxOby9crbbAtjmtUo8sW4Y97WPBKHaodPrBCl8MgFQfceXU1hN1 ct/RW+4SfBCxZyg+3TOiR+y86uwkr2C047ViVD9868bEw+OWMHjc9/6LwtGN4RTYImGD ZdGqU233a1JsmmyCt562wql0bI67A+9Bit7gRug2l8uRP33jA+22zRJEXr7H9ovaSj3Y vvzX54oqAFyDEpifyh5lT85Ap6GxXMnV7iMANUz1kuGxKM1FuD6QA2FwQe+f4HKo6agf +lDQ== X-Gm-Message-State: ANoB5pnFVxxpE8szki+n8rqqbH6pxXyQGkBknbpOvlyQcQUizUpO/CYO 4BIskiEHnsK/EXZdD3LAaMk= X-Received: by 2002:a17:902:ef4c:b0:189:8b14:55bd with SMTP id e12-20020a170902ef4c00b001898b1455bdmr17163554plx.25.1669840340739; Wed, 30 Nov 2022 12:32:20 -0800 (PST) Received: from localhost (2603-800c-1a02-1bae-a7fa-157f-969a-4cde.res6.spectrum.com. [2603:800c:1a02:1bae:a7fa:157f:969a:4cde]) by smtp.gmail.com with ESMTPSA id c30-20020a056a00009e00b0056be1581126sm1849972pfj.143.2022.11.30.12.32.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Nov 2022 12:32:20 -0800 (PST) Sender: Tejun Heo Date: Wed, 30 Nov 2022 10:32:19 -1000 From: Tejun Heo To: Li Nan Cc: josef@toxicpanda.com, axboe@kernel.dk, cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yukuai3@huawei.com, yi.zhang@huawei.com Subject: Re: [PATCH -next v2 2/9] blk-iocost: improve hanlder of match_u64() Message-ID: References: <20221130132156.2836184-1-linan122@huawei.com> <20221130132156.2836184-3-linan122@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221130132156.2836184-3-linan122@huawei.com> X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 30, 2022 at 09:21:49PM +0800, Li Nan wrote: > From: Yu Kuai > > 1) There are one place that return value of match_u64() is not checked. > 2) If match_u64() failed, return value is set to -EINVAL despite that > there are other possible errnos. Ditto. Does this matter? -- tejun