Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 30 Nov 2022 22:32:54 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Brian Masney <bmasney@redhat.com>
Cc:     irusskikh@marvell.com, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, cth451@gmail.com
Subject: Re: [PATCH] net: atlantic: fix check for invalid ethernet addresses
Message-ID: <Y4fMBl6sv+SUyt9Z@lunn.ch>
References: <20221130174259.1591567-1-bmasney@redhat.com>
 <Y4ex6WqiY8IdwfHe@lunn.ch>
 <Y4fGORYQRfYTabH1@x1>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y4fGORYQRfYTabH1@x1>
Precedence: bulk

> > > -	return !(addr[0] == 0 && addr[1] == 0 && addr[2] == 0);
> > > +	return !(addr[0] == 0 && addr[1] == 0 && addr[2] == 0) &&
> > > +		!(addr[3] == 0 && addr[4] == 0 && addr[5] == 0);
> > 
> > Hi Brian
> > 
> > is_valid_ether_addr()
> 
> aq_nic_ndev_register() already calls is_valid_ether_addr():
> 
> 	if (is_valid_ether_addr(addr) &&
> 	    aq_nic_is_valid_ether_addr(addr)) {
> 		(self->ndev, addr);
> 	} else {
> 		...
> 	}
> 
> That won't work for this board since that function only checks that the
> MAC "is not 00:00:00:00:00:00, is not a multicast address, and is not
> FF:FF:FF:FF:FF:FF." The MAC address that we get on all of our boards is
> 00:17:b6:00:00:00.

Which is a valid MAC address. So i don't see why the kernel should
reject it and use a random one.

Maybe you should talk to Marvell about how you can program the
e-fuses. You can then use MAC addresses from A8-97-DC etc.

	 Andrew