Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp3016458rwb; Wed, 30 Nov 2022 14:12:04 -0800 (PST) X-Google-Smtp-Source: AA0mqf5RVyBygyJ8wKu+SKKPWxb3NnzAZNKnIFUH73mYsgjQYkcVxittNHBDkn7pSJK401ere1MG X-Received: by 2002:a17:90a:307:b0:213:dce7:e1fe with SMTP id 7-20020a17090a030700b00213dce7e1femr74287345pje.110.1669846324016; Wed, 30 Nov 2022 14:12:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669846324; cv=none; d=google.com; s=arc-20160816; b=ALlgReev7ytAEH5I0XfCganC3FoRgjFV/sgHx0lhjT44NFoDlrUenL/0QV0crCx0Bw 3d//3RdXnhl86Gwh+v6gdS+qjKKdT1I47WRqAtNwRfXdH+3Yn5+dSec4pHBVNpKgLXsM yk+z8aDJcZeknud3nueL64hcYcwZM5qQg5HS/pPHaA9YhTbCBYHoj79h44ki0kOOiAzM pxqPUu2m2OpC4yaXwM2dG8kO+/J0318G+u98xD3JUh8Xub9f5AeV3Mu73lJlOeiDl/6k l+lpL7+h8voesnx9GLpmlGoHJKM7wL8ND/nbyltNC1lj8GOnJO3w2egwMMfkC0cARxCf iCNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=fS2issW/mFWwGANGJdFnyr1+cpB0LvMK/13BpKDeJx4=; b=rwd244dPjsaNprb+zvTw6keGtW+OgEzVj8BR9ZscNXty45To74kvGeJwGF7dVKwbY6 0kX9FpNAeVzGBW/PeBdECus3cBXYvn2Ykpjz6DEQrGXCiHcYJX6mwawLeFkrQKOTMbvg ng3gwAyVSnonGYdYWkx1iUwEAMeygfih4/uS5DNG1BVU3eBDZzVhGC021v2jhgcxMrCp tnSqSKdPbKdeaUVxIx/fOD9tVkj3i4Gkum50fFxSLinmVqCLIitBhm4Dz44RFlkourbe ckiJXm5pqC73J2JlsbQQs+1bqMB334RJrcH06q4M66BdBAcELNZfSSUQBn9wDqFAlWdY IoKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="VF3vM0r/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v10-20020a63610a000000b0047865d67fb6si1807118pgb.220.2022.11.30.14.11.53; Wed, 30 Nov 2022 14:12:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="VF3vM0r/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229675AbiK3Vnb (ORCPT + 84 others); Wed, 30 Nov 2022 16:43:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229472AbiK3Vna (ORCPT ); Wed, 30 Nov 2022 16:43:30 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2D51769FD; Wed, 30 Nov 2022 13:43:29 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2980761E05; Wed, 30 Nov 2022 21:43:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D9A1C433D7; Wed, 30 Nov 2022 21:43:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669844608; bh=d+XZQFsoyZn0bNyAsgJB+8TgIz28In9nJ8iHQfRcRYg=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=VF3vM0r/sflL3CIjAmqERb8k1Tq4IXO9IEyOq1g3+o4Fzebw+En7brY7ummjpjZC8 oSB/Y8bHHxsye8Mqst4A4BKk/inirFjstR3Vzpl5XSsnroqcTaeGR0Pstjna21ogyc 0WC025Ql1GdumPJbt5FZ0dmz8qLL4b+5dLYT89pdaTGpzsygNMHZWdimi7V8XxHiMz 3ei6s2HMGRfF90sMa7/WrXZ2hgiUTZVFDIFwQEi4ulmdNm2QCXrwocWD8fQpPQyyeF S3M1YBLKgToZJzy7v0P9oP1s1Tu8mZC6jIAGhJQ85b1ZwvjmRE5bGOH7Dt2/hDv3PW Vt2IYcpmtez/w== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id E9D785C051C; Wed, 30 Nov 2022 13:43:27 -0800 (PST) Date: Wed, 30 Nov 2022 13:43:27 -0800 From: "Paul E. McKenney" To: Joel Fernandes Cc: David Howells , rcu@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, rostedt@goodmis.org, Marc Dionne , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-afs@lists.infradead.org, netdev@vger.kernel.org Subject: Re: [PATCH rcu 14/16] rxrpc: Use call_rcu_hurry() instead of call_rcu() Message-ID: <20221130214327.GU4001@paulmck-ThinkPad-P17-Gen-1> Reply-To: paulmck@kernel.org References: <639433.1669835344@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 30, 2022 at 02:20:52PM -0500, Joel Fernandes wrote: > > > > On Nov 30, 2022, at 2:09 PM, David Howells wrote: > > > > Note that this conflicts with my patch: > > Oh. I don’t see any review or Ack tags on it. Is it still under review? So what I have done is to drop this patch from the series, but to also preserve it for posterity at -rcu branch lazy-obsolete.2022.11.30a. It looks like that wakeup is still delayed, but I could easily be missing something. Joel, could you please test the effects of having the current lazy branch, but also David Howells's patch? That way, if there is an issue, we can work it sooner rather than later, and if it all works fine, we can stop worrying about it. ;-) Thanx, Paul > Thanks, > > - Joel > > > > > > > rxrpc: Don't hold a ref for connection workqueue > > https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/commit/?h=rxrpc-next&id=450b00011290660127c2d76f5c5ed264126eb229 > > > > which should render it unnecessary. It's a little ahead of yours in the > > net-next queue, if that means anything. > > > > David > >