Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp3031942rwb; Wed, 30 Nov 2022 14:26:39 -0800 (PST) X-Google-Smtp-Source: AA0mqf7yD0IGF5fHGgP8/9tXlyK7eWwGRsrDRyHVNXjroZEiAO2uEqz70P4I41bzrsfAnUIlLqj6 X-Received: by 2002:a17:902:bcc7:b0:188:f42e:6a90 with SMTP id o7-20020a170902bcc700b00188f42e6a90mr48680672pls.127.1669847199328; Wed, 30 Nov 2022 14:26:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669847199; cv=none; d=google.com; s=arc-20160816; b=fLw5b+VH6UAIhuurJAeKYfWOTCezWLw1pUXFeCQvZAGn3KHlpaNqdfHdlkErgV8kKp bgqaNnQzz3VTuKjlvxlQ9OlTLHdJ6uPXXMbgwEakbU+2v4dUr6H02IbSoDcTlYy8dhBv 8OqZ/sbWI8O2fJGpJBqZwKyEEHtNTEjxuE78gZgAE/w4OMi9x5/wt2xmvnAI73v9zkUG CBlY3XK7NwXMh/x5A37+imUdV7uLXrVgmNkK8lkA2uTYBvzY9Ute5qNQyd1B+rmyx9ws OwkYp6E6sHchRP3zFlkqHW4oA8E/X4M64500H3J94ER3WLIYa4+z5yhU42LNnhDmIFmm wHyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=OQaaCYRaH7FJdGcFxn1nAT6sve1WgBKeRZDBUjitAtQ=; b=DiWsEQFjq8hrnxQDNOmwW24STJ8oV7APUhdDspo1z2l+ErfMAUgT57hnE3je1tsF+C yHR+u2+1YuoU7f9l4V/Sngmm3OI+9LO4BmkNd+AGI1CSNx4IVW88Ek027kZWHRG+ElAN Cupgd5jMUZ/XqUn9WMGsA0ufDWid+smX0f7xALQVbJDqnMU4lDaXrEPbM339lS29gFH4 bl0y54/tGqCJ97aX70eCXPqHKLOaMHNz4dauf7uJ7mcj3vo+IwH92u6K3PgPqSNJKn2T TnykVD8XcEF3hqgj/qrRy85wklrhZ3UkM7llUiR7DwyEGn/ozMurFballPsSw1UMlRvB hEdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=ICKSZlXz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q20-20020a170902789400b001899008803esi2217390pll.370.2022.11.30.14.26.25; Wed, 30 Nov 2022 14:26:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=ICKSZlXz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229617AbiK3VeW (ORCPT + 83 others); Wed, 30 Nov 2022 16:34:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229559AbiK3VeV (ORCPT ); Wed, 30 Nov 2022 16:34:21 -0500 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB482900D3; Wed, 30 Nov 2022 13:34:20 -0800 (PST) Received: by mail-pl1-x62e.google.com with SMTP id y4so18003629plb.2; Wed, 30 Nov 2022 13:34:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=OQaaCYRaH7FJdGcFxn1nAT6sve1WgBKeRZDBUjitAtQ=; b=ICKSZlXzxHqwLEwTb9STGr6dg5avLp4EIUiAtituFWz/GyAFIn0+Qxc2/p8Yn8Ti0w qs/34+Z6bPZG0earjXXvVoArsdkTrneZawYVPCK4ojZNhgZ0y3yoHXs63HZWl2r3RxSH nHWRT8dXAyaq373nWvTQD11RbltKqYaa2oRi1sWIErvMVX1Cen6SgXpST7DSvqHdW8nr k/7RUgeZJg0I/xx1pudIDUibzZxggIZ/vtcuCJCKdui658FAFlCLQ3Pqdy5t9MsQ/e+c LCcREScegfNOrfO3UMD3+lCJzKXLXcyE3LMJTK0pDDsTKP0WkaPIdRy3PJ7fVun9Mfv1 hd3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OQaaCYRaH7FJdGcFxn1nAT6sve1WgBKeRZDBUjitAtQ=; b=SF1dCeTCSNiMBmC6v493hV7iUC96U2raCixHdVC+FcZwggTSpJ5bVLLPQEodMgGN1Y Txc3jWYJ07FpMYc7gCzZbIv5favHNEsd1Dzimrs+vBb7TjB+lUg4hdybxgOLtVlbmfdu IpmMjadOdFZyyFtQeDGK6jKdPj56dsb4uYF0OBsWT03TICKIO7kmKWufhxVzbTvJ0rr3 xEpzIi6xWAR8xOOV98AFdv1o/ftfOjlIogruxqUYiIdmAK7hYgaywTFq8ydj3cGcPeoh QYJOoBWcX300m0f6VrUUFZQ5GQGV4ocVJNe3H7KB/nmxjGOlQQbpjdt79LF2b6hwvEVr dN3Q== X-Gm-Message-State: ANoB5pnrcKxvm/Q2alDaOTSV+rXJo70FX1LC9AI+YV/oSKc6jqTWq/+H BTls/W2tHVK/3nQNwXog/n0= X-Received: by 2002:a17:902:c652:b0:177:e4c7:e8b7 with SMTP id s18-20020a170902c65200b00177e4c7e8b7mr45522477pls.118.1669844060078; Wed, 30 Nov 2022 13:34:20 -0800 (PST) Received: from localhost (2603-800c-1a02-1bae-a7fa-157f-969a-4cde.res6.spectrum.com. [2603:800c:1a02:1bae:a7fa:157f:969a:4cde]) by smtp.gmail.com with ESMTPSA id m5-20020a63ed45000000b0047829d1b8eesm1376647pgk.31.2022.11.30.13.34.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Nov 2022 13:34:19 -0800 (PST) Sender: Tejun Heo Date: Wed, 30 Nov 2022 11:34:18 -1000 From: Tejun Heo To: Kemeng Shi Cc: josef@toxicpanda.com, axboe@kernel.dk, cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 08/10] blk-throttle: remove repeat check of elapsed time from last upgrade in throtl_hierarchy_can_downgrade Message-ID: References: <20221129030147.27400-1-shikemeng@huawei.com> <20221129030147.27400-9-shikemeng@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221129030147.27400-9-shikemeng@huawei.com> X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 29, 2022 at 11:01:45AM +0800, Kemeng Shi wrote: > There is no need to check elapsed time from last upgrade for each node in > hierarchy. Move this check before traversing as throtl_can_upgrade do > to remove repeat check. > > Signed-off-by: Kemeng Shi > Reported-by: kernel test robot Acked-by: Tejun Heo -- tejun