Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp3060394rwb; Wed, 30 Nov 2022 14:57:06 -0800 (PST) X-Google-Smtp-Source: AA0mqf4X2D+KRqqfMTEKYlSF2+HSz5bpAU1GPt4mJTUrXiTSF7/6nbqJkZbTx/9DKdjO4wJ4nc6Q X-Received: by 2002:a63:ef15:0:b0:477:bac4:549b with SMTP id u21-20020a63ef15000000b00477bac4549bmr33227793pgh.170.1669849026634; Wed, 30 Nov 2022 14:57:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669849026; cv=none; d=google.com; s=arc-20160816; b=Xk9jQyPuZP5LUDV/iH6mfxk7fESU78NSGGf9Jye6odBKByHp09Hkc66r7WS0SJAVYk jp3sJLWJhkgmDPklPe2+lXwb+vNhZcKeb3zRDyA7sI7LrzKm8ObHbpIW2XPqPXMuh0m1 G3BjQcl/Rdn+jfW+1/xGD7m/O12kHMnKZekEOW7oZmskOLVXsX0oSw+xU7Yqyg0mYKwd q7oA3RVyB64GWssIfIBkNu7oeka1C2B3wc5hBNd5u63yCvLjW3xOhmaWtmus2IjRuvuR TTYobwAK1P3ONvZomWvFK/LMVu8nbvJprXHarKJ0QH1oVXykOMb85UNulew7v/26gU4C WEkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=r4h7r8Y0MVojckxjMiu4M7Ts0J0hPMnnZAIpEKfgd6M=; b=FG9EziIn36vbb2B/eF/BlPt3e0a/PkxNpIjiML0ROk1aCx4v1hy/bxd/JtYyzFdcUa VWij4gWmQFPSYvD3mMZVOFnSMk/wAtdutcgd+RqAjjxhW1hA+GskdJMQz91Fv2e7es6b 1AI0IvHqaZVCY0Sk8cHC43glUsH6Hcj8sdzIV/vbZ+bjwaB0OVnLZp2UH8Qc53ANttKW bUOcFPyGYZVLX4wfGNd6Dzai/CrrZo9rEu+moJPfC48W2tZ9uKcVBhaXmVIdGdYDsjGN C2MOlw9/KQUNf9ZTTEKKjJb3JcOeWjDN69BUmNw8A1kiIoj/1hoovkUA+nmxMFa+OJBe v+wA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=Pc2fr1ld; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o15-20020a170902d4cf00b001871d062940si2580789plg.400.2022.11.30.14.56.56; Wed, 30 Nov 2022 14:57:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=Pc2fr1ld; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229629AbiK3WhZ (ORCPT + 83 others); Wed, 30 Nov 2022 17:37:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229555AbiK3WhY (ORCPT ); Wed, 30 Nov 2022 17:37:24 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0257B8C453 for ; Wed, 30 Nov 2022 14:37:22 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 99340B81D11 for ; Wed, 30 Nov 2022 22:37:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA2F2C433C1; Wed, 30 Nov 2022 22:37:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1669847840; bh=zYsNbDHSQZ6QKvCH+Y2IXFnV1un2L85lK4tF30YwHK0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Pc2fr1ldVRBQ8QVl1y/2ZFiBGI7k945coMZwIhITLwcxuuTZmGqnQu7GGMMiiDQv8 FZCsNPXuzoAOPI5GlJI/eEooKEVkrKZFgbZgMAUZa3AD92+X3rpX5K1nU5UEpFo6kM K4UtJhqRuT6+SaDiqHbxTbEy7MADmYSxEZOQqYP4= Date: Wed, 30 Nov 2022 14:37:19 -0800 From: Andrew Morton To: Chris Mason Cc: Steven Rostedt , Borislav Petkov , Alexei Starovoitov , LKML , Linus Torvalds , Masami Hiramatsu , Peter Zijlstra , Kees Cook , Josh Poimboeuf , KP Singh , Mark Rutland , Florent Revest , Greg Kroah-Hartman , Christoph Hellwig Subject: Re: [PATCH] error-injection: Add prompt for function error injection Message-Id: <20221130143719.07e36277d1471b83e9a1b627@linux-foundation.org> In-Reply-To: References: <20221121104403.1545f9b5@gandalf.local.home> <3fa8ec60-dd96-c41f-ea46-8856bf855949@meta.com> <20221122132905.12a8d5ad@gandalf.local.home> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 22 Nov 2022 14:51:08 -0500 Chris Mason wrote: > On 11/22/22 1:29 PM, Steven Rostedt wrote: > > On Tue, 22 Nov 2022 12:42:33 -0500 > > Chris Mason wrote: > > > >> On 11/22/22 5:39 AM, Borislav Petkov wrote: > >>> On Mon, Nov 21, 2022 at 03:36:08PM -0800, Alexei Starovoitov wrote: > >>>> The commit log is bogus and the lack of understanding what Why am I not understanding the controversy here? With this patch applied, people who want function error injection enable CONFIG_FUNCTION_ERROR_INJECTION and people who don't want it don't do that. Alexei, can you please suggest a less bogus changelog for this?