Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 30 Nov 2022 15:58:31 -0800
From:   Dan Williams <dan.j.williams@intel.com>
To:     "Darrick J. Wong" <djwong@kernel.org>,
        Dan Williams <dan.j.williams@intel.com>
CC:     Andrew Morton <akpm@linux-foundation.org>,
        Shiyang Ruan <ruansy.fnst@fujitsu.com>,
        <linux-kernel@vger.kernel.org>, <linux-xfs@vger.kernel.org>,
        <nvdimm@lists.linux.dev>, <linux-fsdevel@vger.kernel.org>,
        <david@fromorbit.com>
Subject: Re: [PATCH 0/2] fsdax,xfs: fix warning messages
Message-ID: <6387ee2769155_c957294c8@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <1669301694-16-1-git-send-email-ruansy.fnst@fujitsu.com>
 <6386d512ce3fc_c9572944e@dwillia2-mobl3.amr.corp.intel.com.notmuch>
 <20221130132725.cd332f03ad3fb5902a54c919@linux-foundation.org>
 <6387cfcbea21f_3cbe0294b9@dwillia2-xfh.jf.intel.com.notmuch>
 <Y4fid4ZFSUWvWzNH@magnolia>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Y4fid4ZFSUWvWzNH@magnolia>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PhiBfkH3z5aZvnwsialWA9lIrJn6c/pWcPZwJdirsCN+0/McPPt5YyqMLAGT?=
 =?us-ascii?Q?oa74AI63Ubl0A98dUHS0wlUtqD9G5tqcdvN5Ql7XCjukwiTCTfkNF+0aVOY5?=
 =?us-ascii?Q?bTRhD4KTknQOX/cyPqTyp5O2vNGtXVWBNtEhkryEwjC1pA/3pofH89h7rqj+?=
 =?us-ascii?Q?s1WSA+HA1W36rGkj5asdx+Eb3FZwA/qVQhUgcrdMLTar9dECB8PL73oZNcTA?=
 =?us-ascii?Q?IqNYki8fJUN4psOUwWDOYKImQYFNa76CnmRCepL+rsapB577NVogWN0bQk+o?=
 =?us-ascii?Q?tcG9IBVT1awmSURFAhaGcwttbmgyPmhqrYUMtSPgZrOTEzwT7mwTTXOca0Kd?=
 =?us-ascii?Q?GBtZaNjLE6pZpc6OgOJYzCJfGvKpvAdrY+KhbBUYGvRcW05j+k5f5ZEcoGef?=
 =?us-ascii?Q?6TqbWXUA075LV3CusxmL14FUOdyeW6yOkgsnRsWbHaYPqD9uhk+lkYL4vQA2?=
 =?us-ascii?Q?VN5UQ9LdEr7iasbq/FEa9OPSFNKRHSWAR5z3dtBM29dmRZ9BiltutObFixZ7?=
 =?us-ascii?Q?RqXFIbaVCfK21W+CLbSxlNs3l+u3vFfQcN53ATCiQDqxFvkGAecQfdoX/3VS?=
 =?us-ascii?Q?1LfrZUk3J8QaJ+Bd5uYYwa7NOxCaNu1vZ/OJ6YjDZ/njj1e7kC9hNnaa/NiM?=
 =?us-ascii?Q?HATnIo/Mp3caJo03BMl03g0JCvZ0+EMldz88iOI8BjKfjfeFkMXHiWzhm1i6?=
 =?us-ascii?Q?c5eOBPZpFE/PTyu1KG4X8yceXie/WLuqBUTBYPgFGU4dNsOjuZEiorCzRiKF?=
 =?us-ascii?Q?nGALz6YyVfQwWLeH4SOm6gmng8Hax2yVuGuGJ6bsgIQjv6zJeSjP668UqHSr?=
 =?us-ascii?Q?kOyP1U7e0J9JLl3fXiB9lcJbyYTZ66CmxTh7WyXUDtCyCRObQMnIySgcHz23?=
 =?us-ascii?Q?0MaMmrPe0k9d9t6mhJ9J5lE57aARf9nR+ApiMG64E14KQB56em/KZOh0vSU5?=
 =?us-ascii?Q?eJapYne5aznNJFRRxy2pbZpEv0Ou7tez0l5hG/DhYe8HgMNkhNBaK7lElwE9?=
 =?us-ascii?Q?uaTVhmEyRFM+AdrHwDMkr9VXexGc4CuEIRweBVSuh3pNpq8Ofuzx7rIMlFBW?=
 =?us-ascii?Q?W66Jinx4tEOnktcwuG8NY/P9+zkVNQHZfD5/HHovko6iNv47A1BFC1naRFBc?=
 =?us-ascii?Q?e1IRGnXG9u7inUOXovtCjS3pbg9VM50P7HvJ0wZA/h0+piL0IxX028+bOCSK?=
 =?us-ascii?Q?yn+3cpVz5RDWgxhVwKPXL2yBoUUHqRkugHPJ0d+xMlniZlPIb0Bry69Wd5FZ?=
 =?us-ascii?Q?aqSy3ui0qjPXTB8XYc3I2wtrvlaVpx4NU0UZKlwqX8U2fRW287Y1lVxjZXNf?=
 =?us-ascii?Q?dKG//QNoYInnq4apzoK2m/T8F46m5zwauPEWMfNViNZxuAij4CSZ7BKfKee+?=
 =?us-ascii?Q?eauaXkAf8ODzcveJy3JtN23DJXY+6ZUBADKwUC3ICiOmFNfXIuhCXM4Odw6u?=
 =?us-ascii?Q?tEcGeGdngDuwtJNrhgQylA+tQfKEOnfby9gLzUBN2CsxH0fEHeNgFku/B9Ot?=
 =?us-ascii?Q?wlukbH8O/HSo0ElofdYNIKlezn36TD0Jw9Ic5T250Tjw7UCI69IhA87fsnrr?=
 =?us-ascii?Q?07oCN+T/VwE7U8rKGqiiHCTN4O4YSZlDhn4gxn2dhDeofAHJeXpbQpsQ60NW?=
 =?us-ascii?Q?1w=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 38c568b8-47cf-47cd-4964-08dad32ecdbc
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2022 23:58:40.2002
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rukAqVaH3CIMDzJDVlfNKqfFWgxAc2VlszriU4aofRWcODg8aWPj48/j2Ek4EygxtOJOsx404QQ+yRwCZF/kdkulY3laOOV4RSL/xVCSAhs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6755
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Darrick J. Wong wrote:
> On Wed, Nov 30, 2022 at 01:48:59PM -0800, Dan Williams wrote:
> > Andrew Morton wrote:
> > > On Tue, 29 Nov 2022 19:59:14 -0800 Dan Williams <dan.j.williams@intel.com> wrote:
> > > 
> > > > [ add Andrew ]
> > > > 
> > > > Shiyang Ruan wrote:
> > > > > Many testcases failed in dax+reflink mode with warning message in dmesg.
> > > > > This also effects dax+noreflink mode if we run the test after a
> > > > > dax+reflink test.  So, the most urgent thing is solving the warning
> > > > > messages.
> > > > > 
> > > > > Patch 1 fixes some mistakes and adds handling of CoW cases not
> > > > > previously considered (srcmap is HOLE or UNWRITTEN).
> > > > > Patch 2 adds the implementation of unshare for fsdax.
> > > > > 
> > > > > With these fixes, most warning messages in dax_associate_entry() are
> > > > > gone.  But honestly, generic/388 will randomly failed with the warning.
> > > > > The case shutdown the xfs when fsstress is running, and do it for many
> > > > > times.  I think the reason is that dax pages in use are not able to be
> > > > > invalidated in time when fs is shutdown.  The next time dax page to be
> > > > > associated, it still remains the mapping value set last time.  I'll keep
> > > > > on solving it.
> > > > > 
> > > > > The warning message in dax_writeback_one() can also be fixed because of
> > > > > the dax unshare.
> > > > 
> > > > Thank you for digging in on this, I had been pinned down on CXL tasks
> > > > and worried that we would need to mark FS_DAX broken for a cycle, so
> > > > this is timely.
> > > > 
> > > > My only concern is that these patches look to have significant collisions with
> > > > the fsdax page reference counting reworks pending in linux-next. Although,
> > > > those are still sitting in mm-unstable:
> > > > 
> > > > http://lore.kernel.org/r/20221108162059.2ee440d5244657c4f16bdca0@linux-foundation.org
> > > 
> > > As far as I know, Dan's "Fix the DAX-gup mistake" series is somewhat
> > > stuck.  Jan pointed out:
> > > 
> > > https://lore.kernel.org/all/20221109113849.p7pwob533ijgrytu@quack3/T/#u
> > > 
> > > or have Jason's issues since been addressed?
> > 
> > No, they have not. I do think the current series is a step forward, but
> > given the urgency remains low for the time being (CXL hotplug use case
> > further out, no known collisions with ongoing folio work, and no
> > MEMORY_DEVICE_PRIVATE users looking to build any conversions on top for
> > 6.2) I am ok to circle back for 6.3 for that follow on work to be
> > integrated.
> > 
> > > > My preference would be to move ahead with both in which case I can help
> > > > rebase these fixes on top. In that scenario everything would go through
> > > > Andrew.
> > > > 
> > > > However, if we are getting too late in the cycle for that path I think
> > > > these dax-fixes take precedence, and one more cycle to let the page
> > > > reference count reworks sit is ok.
> > > 
> > > That sounds a decent approach.  So we go with this series ("fsdax,xfs:
> > > fix warning messages") and aim at 6.3-rc1 with "Fix the DAX-gup
> > > mistake"?
> > > 
> > 
> > Yeah, that's the path of least hassle.
> 
> Sounds good.  I still want to see patch 1 of this series broken up into
> smaller pieces though.  Once the series goes through review, do you want
> me to push the fixes to Linus, seeing as xfs is the only user of this
> functionality?

Yes, that was my primary feedback as well, and merging through xfs makes
sense to me.