Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp3227096rwb; Wed, 30 Nov 2022 17:36:57 -0800 (PST) X-Google-Smtp-Source: AA0mqf6EBBNX7PIVZXaBJrZgcYMFhDIIE6SpnD5jJkeHggMttJYCWgmJy++wh15Zg3bE5T2b5Fuy X-Received: by 2002:aa7:9534:0:b0:575:c857:edc0 with SMTP id c20-20020aa79534000000b00575c857edc0mr7553961pfp.22.1669858617646; Wed, 30 Nov 2022 17:36:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669858617; cv=none; d=google.com; s=arc-20160816; b=NCqWJ9HwWljhkDqbq561MvBtok/M86u2DhIThBilRAjUq/4FJfUyb8iClnl4MHYx2v 59Pzeb1Nsy5PL22ZQ6R88UILrgtF8/qqySzg3ceCf5yVHk7mOsc1LLQWiQ3vP/LIOtjx bF7etwGUbletRGrH+Iavr95XTqi+SdaBiaB+i6PzwQ2HdaWHT0knzNUjEExhdITI5/Ju a5V2EzH5wGtJg3jahAa1uQ69bhGvisSQNT3TfLBYhm/d+1OQteMIxGkVdgM92zNn2u/n G8vjcPR0+zwAEbts9+lf1tGN+HWK34GRD5YUydBV0+zYx26SPvmit1FZf3G4QTwiyWkD JPhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=fzfV/blg/Ga/fe54PrNu5hR73CGPMYQ1vTju1IYxRMo=; b=ybVwX4QgpPt5d+Pq2duvF845n2pOYTJxijgSNMQgA3f0zEmvf7bW2o+xmcjMKntGtF ZfFAo7LmqX9m6ZeLEZXP46zfLprfP/P/ByGKY/I4ak7lgNFr7uzLKidyiAVmasEmlQQt bhdfimINiIwxed2cumBgR2YV7jcjHpQbMovaySJWNWlGDl/Oqw+SdDAzNK6cn08Zttjg 61YGmQ22ffJkC5ANENtbToW2V1Fyd5BPZfP5qjPMlhdyaC5kMN0/uwv/2qMrxge9jsCG mADw3AzNzlhQ2aN5sQa84ffEgMnjm58YpYnPiJh6phhMZCUDzB7B8iCH+gJpyTU88S3B /+Yw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Pj9Nt5dQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e125-20020a636983000000b00477cead7cd1si2705172pgc.644.2022.11.30.17.36.47; Wed, 30 Nov 2022 17:36:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Pj9Nt5dQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229829AbiLAApz (ORCPT + 82 others); Wed, 30 Nov 2022 19:45:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229597AbiLAApx (ORCPT ); Wed, 30 Nov 2022 19:45:53 -0500 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6ABF26105; Wed, 30 Nov 2022 16:45:51 -0800 (PST) Received: by mail-lj1-x234.google.com with SMTP id r8so162273ljn.8; Wed, 30 Nov 2022 16:45:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=fzfV/blg/Ga/fe54PrNu5hR73CGPMYQ1vTju1IYxRMo=; b=Pj9Nt5dQ+Ly5gcWlBA9pYDNkOfBlQ/CZ+m1Mwn+EVF3Br++Ki5hIWbxy0HgxVxPLpr QsNeK3m90nafRA24+mfcwWUoUNZKE8Jv0Fo/S1KaEs2LABvd0u+dw/oAYwb+bDS/nVu3 HsqASUc6BCJA4N8V5rBtDKNNPVpoS53p+UN9tZgHKV8rHFtbwpY4wMWL6VurUA5SHn3H JlpyT7g8T0RiDlRMizunD0vzQnmVHipp2wEStVgPqpQZ8bqdThxM5IhGA+sdmEAmreS1 QzHzAvEXBClaprcFg9kPYYzIm25kcmz2vLojS2N6xWYXRZmdEFIz7xN3kolprf9Wz7ZZ nzzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fzfV/blg/Ga/fe54PrNu5hR73CGPMYQ1vTju1IYxRMo=; b=IDHiu5L1dQSZTR6wXdGMW3OH6Ha/9K6UJMWWOKSWdGaOXotSeEe4zgqqw3FDZoaWyq ZY+LF2JmdrH00R7ZsQDATqw4InItVuZ2dkPeU1zatuLU2w/is10RTwYsccWKhIb6kMqe 4Gsr0qLyhn8H2gGdbXXr3HmhlJo4Jv0wNKovCWsRwD0Dum/gjour+SoRbjtlJRcx7M+7 YYRXuBgZ8QLYfpVzO4L8friMF52nRVyo7on5UECtJ/huMdT++Moa+jvmkvVrQ9p4ogW/ Bc7CQZhkOyY5DlaawUoWJeBMZ8JHSrSQGo8dqbp8MRLPAZGCmSNp/OxojOS7snlueB7a XOsQ== X-Gm-Message-State: ANoB5pkjBI6TFooqw/QnBd7UKD6PePvsZumvD6DPYTvKKcnaVriXkKDf NkXucTmSliYQ0EoyZZmq3kWajekUklNC7ba/BA== X-Received: by 2002:a2e:b984:0:b0:279:ba98:62b1 with SMTP id p4-20020a2eb984000000b00279ba9862b1mr2746062ljp.307.1669855549712; Wed, 30 Nov 2022 16:45:49 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Stanley Chu Date: Thu, 1 Dec 2022 08:45:34 +0800 Message-ID: Subject: Re: [PATCH v9 01/16] ufs: core: Optimize duplicate code to read extended feature To: Asutosh Das Cc: quic_cang@quicinc.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, quic_nguyenb@quicinc.com, quic_xiaosenh@quicinc.com, stanley.chu@mediatek.com, eddie.huang@mediatek.com, daejun7.park@samsung.com, bvanassche@acm.org, avri.altman@wdc.com, mani@kernel.org, beanhuo@micron.com, linux-arm-msm@vger.kernel.org, Alim Akhtar , "James E.J. Bottomley" , Jinyoung Choi , open list Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 1, 2022 at 8:03 AM Asutosh Das wrote: > > The code to parse the extended feature is duplicated twice > in the ufs core. Replace the duplicated code with a > function. > > Signed-off-by: Asutosh Das > Reviewed-by: Bart Van Assche > Reviewed-by: Manivannan Sadhasivam > --- Reviewed-by: Stanley Chu