Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp3258232rwb; Wed, 30 Nov 2022 18:10:11 -0800 (PST) X-Google-Smtp-Source: AA0mqf4SQWuPFmHHHcQt7uhdzQvhF5/Jm2+D1SSe2BOF0bTxS45JSfNKNVW5AXGfUf4gY/TUG57K X-Received: by 2002:a17:906:3510:b0:781:b7f2:bce9 with SMTP id r16-20020a170906351000b00781b7f2bce9mr55295843eja.269.1669860610936; Wed, 30 Nov 2022 18:10:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669860610; cv=none; d=google.com; s=arc-20160816; b=P/O0h+F8nWuuRFuFq7hqEXOsUjc0DRAN6ant5OkfyMvmQK5SL74rH1QK90NzAYGv1h UFreJK9q2beTIVg56Pehoc9mKCcxWS74fPe9uJ/ZMtjNQ4c8dglCtRK4ul79UVYsrxKM hhb2kKQYV6mxHsBany9/j1MhWIIGum2KD0QGfIrXeC8oYW3rRxCxRie7RqIslcRFWEgO cuGb5eDxEJ+PLPbyscF1DljI03s+4ZJfo302Yd6DVsbZEAJ5q+GL+JkNsQKd+bPpT4ci /37Vkq5HMqprqCHCfLdtRM2P3WDBPYUIVliZ4jjlgaePtS/uBQkTYXnqSRtfZJ892qvH fhgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=8hDdaQmPxw+eSKXxu3gfMm69MhV0uzkfUNnKEmkBTXE=; b=EF9AdvlzwUhq8u1fTP46Qpc0Hx6jKxTg48CRk7r8dpxvo8eEzoySSgZr9cg9cfHM4U DTG3yXl721cMiq8Pq38QnYfX48ys06ipDnArpj3ndXPNu0UyuyvtjzMXEDd9vWE3HId7 RjszjVgdyX4NQuzYwPPx/Aa1NrTBglowueFxYWl9YDK6Nj7qiDkx6AZFY4k8ZY2rb2VT 5LFdIn8+SR4ThRzsv64RfnxWsYqL5fcpPOdYeDGep56gbynGXuT5rsraYRwCdiPLtZTq 1eRwvEbDn7enyIvJRVqQW48yHjHK9VDw99edidhlz57QV5z+f1BEBxyKjzjwqqUwPxLT HYyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=EP1iVAJN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id by12-20020a0564021b0c00b00468eee74e58si2370747edb.273.2022.11.30.18.09.51; Wed, 30 Nov 2022 18:10:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=EP1iVAJN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229852AbiLABrD (ORCPT + 82 others); Wed, 30 Nov 2022 20:47:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229579AbiLABrC (ORCPT ); Wed, 30 Nov 2022 20:47:02 -0500 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A94DF4B9AD for ; Wed, 30 Nov 2022 17:47:01 -0800 (PST) Received: by mail-pj1-x1033.google.com with SMTP id mv18so519481pjb.0 for ; Wed, 30 Nov 2022 17:47:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8hDdaQmPxw+eSKXxu3gfMm69MhV0uzkfUNnKEmkBTXE=; b=EP1iVAJNfePbfh1XQ73+nj6duWcS7GeX4kDcPDxP4Zm/+vKz4IF61o1LkM32zEI0Zb KiOqL32O6LJsNHvJ0j2SjjF5kwdBlhIrCYwE1Kj8DOe3ZFbl7yYWpS0aoBewT2XUSoyc aW7E51BsJQV00EOBQKOhqfQ01rbNZJLh6QJ3Ty0FuBKYqGp74uuVxRYUz9g1j/nQBtG7 xjMERT22SHAsVvI+YnsSbaWBI2/QN87pJcKYsdNPzktxXsAXdJD+L9gTOMnlVGhMuBaq bPPZItg0sTNH7G1l0s2LRMK52I4Ft+DIAdQlFp7jobjCEdMmsrZb5kTH0olbnhapauVg 91MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8hDdaQmPxw+eSKXxu3gfMm69MhV0uzkfUNnKEmkBTXE=; b=DgwGCdW/jPOBcOfbVxmb7JFUudk+vw8PfGkMGcDXl3yix/V9OmoXfTBtcwDBurThR7 StuRUKnn4C7iQkg+IxMOMEhIOhA2/JtqawfXTPbdNCnVPCnoj1BQho21DV4VPnubZSOG waZCjT97JKZDIyE66AKIgJSCWa2bZHO2vxcE8SS3lO/spRQ2hFpddkXJJXzEtJJWLr/V XcdUAfj94nwG3X7dibP8OnB+Y1wUkCi+gxogO7OuRHPBl6haLh3F7qg2HnP0dL3US9Rl V7PZR579HGtR4+CBHZsXn2cZqEfF6RuCQkWqwbRZ+G2S+SsgbTAilPQr31sAtTxMAeFd JOCA== X-Gm-Message-State: ANoB5pmE4lXesyyViQbv9DyMRB1YVQInVNcVZ94VeSs6jydZSnIiT1sK vTNf/XfmOFeFwyKRReIH6e1Jxw== X-Received: by 2002:a17:903:300c:b0:17f:9538:e1f4 with SMTP id o12-20020a170903300c00b0017f9538e1f4mr56504944pla.89.1669859221046; Wed, 30 Nov 2022 17:47:01 -0800 (PST) Received: from [192.168.1.136] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id x128-20020a626386000000b0056cea9530b9sm1968984pfb.200.2022.11.30.17.47.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Nov 2022 17:47:00 -0800 (PST) Message-ID: Date: Wed, 30 Nov 2022 18:46:59 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v2 0/5] A few cleanup and bugfix patches for blk-iocost Content-Language: en-US To: Kemeng Shi , tj@kernel.org, josef@toxicpanda.com Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221018121932.10792-1-shikemeng@huawei.com> <93f9093b-abec-db7e-a945-263cd9355c08@huaweicloud.com> From: Jens Axboe In-Reply-To: <93f9093b-abec-db7e-a945-263cd9355c08@huaweicloud.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/30/22 6:45?PM, Kemeng Shi wrote: > > Hi jens, > on 10/18/2022 8:19 PM, Kemeng Shi wrote: >> This series contain a few patch to correct comment, correct trace of >> vtime_rate and so on. More detail can be found in the respective >> changelogs. >> >> --- >> v2: >> Thanks Tejun for review and comment! >> Add Acked-by tag from Tejun. >> Correct description in patch 3/5 and 4/5. >> Drop "blk-iocost: Avoid to call current_hweight_max if iocg->inuse >> == iocg->active" >> Drop "blk-iocost: Remove redundant initialization of struct ioc_gq" >> Drop "blk-iocost: Get ioc_now inside weight_updated" >> --- >> >> Kemeng Shi (5): >> blk-iocost: Fix typo in comment >> blk-iocost: Reset vtime_base_rate in ioc_refresh_params >> blk-iocost: Trace vtime_base_rate instead of vtime_rate >> blk-iocost: Remove vrate member in struct ioc_now >> blk-iocost: Correct comment in blk_iocost_init >> >> block/blk-iocost.c | 16 +++++++++------- >> include/trace/events/iocost.h | 4 ++-- >> 2 files changed, 11 insertions(+), 9 deletions(-) > Could you apply this patchset? > By the way, my apply for an cloud variant of email was just passed > a few days ago. Is this mail still in spam? This one wasn't, but I've seen the huaweicloud.com emails fail the same origination checks in the past. -- Jens Axboe