Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 1 Dec 2022 10:05:32 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     Conor Dooley <conor@kernel.org>
Cc:     Palmer Dabbelt <palmer@dabbelt.com>,
        linux-riscv@lists.infradead.org,
        Conor Dooley <conor.dooley@microchip.com>,
        ajones@ventanamicro.com, aou@eecs.berkeley.edu, corbet@lwn.net,
        guoren@kernel.org, heiko@sntech.de, paul.walmsley@sifive.com,
        linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v1 3/3] Documentation: riscv: add a section about ISA
 string ordering in /proc/cpuinfo
Message-ID: <Y4gZ/KZz9rdYj/0r@debian.me>
References: <20221130234125.2722364-1-conor@kernel.org>
 <20221130234125.2722364-4-conor@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="gGADNEIMdohg5oZc"
Content-Disposition: inline
In-Reply-To: <20221130234125.2722364-4-conor@kernel.org>
Precedence: bulk


--gGADNEIMdohg5oZc
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Nov 30, 2022 at 11:41:26PM +0000, Conor Dooley wrote:
> +#. Single-letter extensions come first, in "canonical order", so
> +   "IMAFDQLCBKJTPVH".

"..., that is ... ."

> +#. The first letter following the 'Z' conventionally indicates the most
> +   closely related alphabetical extension category, IMAFDQLCBKJTPVH.
> +   If multiple 'Z' extensions are named, they should be ordered first by
> +   category, then alphabetically within a category.
> +

Did you mean "most closely related alphabetical extension category in
canonical order"?

> +An example string following the order is:
> +   rv64imadc_zifoo_zigoo_zafoo_sbar_scar_zxmbaz_xqux_xrux
> +
=20
IMO literal code block should be better fit for the example above,
rather than definition list:

---- >8 ----
diff --git a/Documentation/riscv/uabi.rst b/Documentation/riscv/uabi.rst
index bc3c8ced644bcf..8005add855dc43 100644
--- a/Documentation/riscv/uabi.rst
+++ b/Documentation/riscv/uabi.rst
@@ -43,6 +43,7 @@ ordering, so for our purposes the following rules apply:
 #. Non-standard extensions (starts with 'X') will be listed after all
    standard extensions.
=20
-An example string following the order is:
+An example string following the order is::
+
    rv64imadc_zifoo_zigoo_zafoo_sbar_scar_zxmbaz_xqux_xrux
=20
Thanks.

--=20
An old man doll... just what I always wanted! - Clara

--gGADNEIMdohg5oZc
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCY4gZ8QAKCRD2uYlJVVFO
o8LXAQDg6voodFPTVXIYpNCPvF2HkaiCwmKqQbyxHuyY8letmwD9Efrm/nRjGJBW
Pgs+RY15Td/CNE2QL19Q3dU8AzkiwAE=
=aqlR
-----END PGP SIGNATURE-----

--gGADNEIMdohg5oZc--