Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 1 Dec 2022 12:11:12 +0800
From:   Firo Yang <firo.yang@suse.com>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     marcelo.leitner@gmail.com, vyasevich@gmail.com,
        nhorman@tuxdriver.com, mkubecek@suse.com, davem@davemloft.net,
        edumazet@google.com, pabeni@redhat.com, linux-sctp@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        firogm@gmail.com
Subject: Re: [PATCH v2 1/1] sctp: sysctl: make extra pointers netns aware
Message-ID: <Y4gpYPlWNLe5o8Hy@suse.com>
References: <20221125121127.40815-1-firo.yang@suse.com>
 <20221129204818.7d8204b4@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20221129204818.7d8204b4@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z0tWMHZqaGYzR0h3c3BrRCt4dkpNbVk5clJDRVBzMHNNc1pQSDNHUDhVaVV1?=
 =?utf-8?B?bWZKejQvZjdSR3FhY2tmOWlaeXorRnFqZ3ZlVU52bHZJR1gvTjQrVHVMZ2ZK?=
 =?utf-8?B?K2J0K2tFMzZERU5LTmsvWVc5WmFVTUxQeG9EMEJJSXNiZjhMM2hHMlpaUEJO?=
 =?utf-8?B?bEdyeXg3d2lnVEZpcDYrbmdQK3FCSHozRE5IMXp3R3dwTmJtQlcxYjd0a2xm?=
 =?utf-8?B?Yys0a2Ywc1huZTUvZ3JuVHBST0RVSWF3eFd4bnRJemNoVkJIRHlHRS9sNzZ3?=
 =?utf-8?B?VWpGbHlHWDI3UlFrUHhzcXRWZ1FVYjhVWHBQaDRSdDI3ZjZHRTdaMFdzaHVr?=
 =?utf-8?B?Yk13SDBwNldEUVFidE11VHJOY1c0cGFra3NtTlRHZUpxTjdhL2RJNGFYc21W?=
 =?utf-8?B?QmFTSnUwdmMzNGtITEIyb2w2N2ZEc05JQld5Z29CS2FwVGwvYW9uL3lXVk10?=
 =?utf-8?B?NW9DbTRxZUFZNVVSVU5QS3hNSTBSYVdNdGhUOWJ0ZG04M2pmcmhKbmRvQk4r?=
 =?utf-8?B?Z21tU2hBY0VHMURiOFZjbGNzZzhQK3dFaXcvUjZ4azB2SVczWml2SXpiL3cr?=
 =?utf-8?B?U1NNcXZXNklGdDdnT3JiOFI4NUh5Z0RpV1AyeVBtcXBLQkMzYTY2N0tSRzJx?=
 =?utf-8?B?bXFlcnpwWWNLbFVUMFZrUEdTcks4OXIxVXIzNlpkSlZGdWdGRDRDWmxsSVRI?=
 =?utf-8?B?ZWdCbWQ0d0pPWlBYZEI1TFR1eHpCamlBeUp6NlZZWTZPREU0V1ZPbkJQVU1o?=
 =?utf-8?B?UERZVVhicExGbHBvRkkwbTlETTlmcUxEcnQzalNmeG03YzFJdjNzTDh2c1Bn?=
 =?utf-8?B?QnpOaUx2TDFPTEdZa2FDQ2s5NmtoR2M2Y3dPVS8yTGd2UmgyV3NxRTNzQkkr?=
 =?utf-8?B?R1hud3BXS3gyMUQ2YnVnVUJrTjJld1MxNnVNYWpLYnNqbzVJWGRSbGlRRE1m?=
 =?utf-8?B?eWhjWGRzblN4NzVKTjRvZ0FQYUpaeWd1OFhndHlNdXlsRDZIWHBrQWxGRnlV?=
 =?utf-8?B?NDRtbVJnTWFKOWxudzJubFFMVTBGaHltN1laWENxaFQ4bEs1Zm5OSHFjeDBH?=
 =?utf-8?B?Y1VIZS9DYmZDc09QV01RcEljYzB1VjBvSEtEaXRTY1czb2pTVFhGbTJyV1VQ?=
 =?utf-8?B?WkwwcUhNY0RDaGhUU3A1YUxINW5lSFQ0RUUyNmZKOHlyTysvYk1lK0w4WWJN?=
 =?utf-8?B?ODZZbTFQZm4yTEtWZm55VkpMMzlveG9oVUFKS0NySlRmbTBiL0JpYlJvYk1X?=
 =?utf-8?B?QytqWnJlSXFMRStEdndoVVgyOWk1UXROSWRyTy9GckRkcVpKdjdWMzFMSmx1?=
 =?utf-8?B?SzNzNzJlem9NcWozZEJCdHc2UXdlVk0ydy8wa3JkS1oyNURQOUE0TXBIeFox?=
 =?utf-8?B?cWN5S2d6RHJIRm9OSWxPY2RkS2ZSVWJ4Z0hOeTVBVnpvbTN5Y3dWbmlCcW1S?=
 =?utf-8?B?cHN3czFQMUFGUkE0QXc3dGs4dDhBZC9lTjhFa0lJMng0a1RCZnNpZjlpeFZj?=
 =?utf-8?B?QWZpUi91amZoN1FnYmd6Z1JQM2JweVYyNERBOFpJZ3U3Q1hVZStCTzEzb3Q2?=
 =?utf-8?B?MGdldHVIbGJQRU52ODc5bndYRUMybW5qeitSMitrcXBMakFLSU9kd0E1eXpl?=
 =?utf-8?B?eFZSd0hYdDVzVzRvd2pXN3dtS1E4dE1BNVJDbDJUZjNOR3MrQTJMNTNDU0NB?=
 =?utf-8?B?SCtTK1dkTzRaSENFdXRCa3hZR2c3V2YvS0pmTk5ST3hTb09JZmQxNW9sdnFQ?=
 =?utf-8?B?ZmMvbDZCRC9iZ3d5TEhlSEVzdWJmRFhqMUVuZG56bTJLMk1aa1A3enNhSmRp?=
 =?utf-8?B?ZG1SUHloQmJMcDdiMlo3UXMrTTBoaWxYeFdsYmllYjhrdDRhbkxlRHBoOFBT?=
 =?utf-8?B?OFBpMHFZYzRXZjJRRnErSisyQTVPcVU0NGhHLzlVQ0xob1B3aFg4RWJyZzVh?=
 =?utf-8?B?YTIwNHVRS1dHNFVwMWtXWm5rdVhqSGRsYW9Fb2FEZnRwQmxlcUF4T0ExcnZP?=
 =?utf-8?B?VkpqOWZPUERZQmxBdy9XL2NHblZ6aGJZNEc4QU9aa2RHMVZBdVlYTnl5Snk4?=
 =?utf-8?B?T0xTTEw4eXNiekVmVXBwRUpKcmxHaTY2bmxSYmwydEtZVVoxUE1SSmNyOHdL?=
 =?utf-8?B?WEJmRUxaclVURzIxVXlGcnVTZlpINVVyd05abnNZbHJaMlRGL2Y0VWVjWXdj?=
 =?utf-8?Q?BJFIlB/UF9Zqrerwm/UuJ1XSqCUOJ9DFQhnF3ZDDdPhC?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d5e3ae42-026b-4bf2-44ba-08dad3521d72
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB9009.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2022 04:11:26.9133
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yyCLkEZXT7HftVFETUxrnSySZ6kPwRALLUJ+TM6dwX4PJYdpK5M6x391637b/F9FueLrCs/u2VPvdOIBp96F0w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9335
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The 11/29/2022 20:48, Jakub Kicinski wrote:
> On Fri, 25 Nov 2022 20:11:27 +0800 Firo Yang wrote:
> > +#define SCTP_RTO_MIN_IDX       1
> > +#define SCTP_RTO_MAX_IDX       2
> > +#define SCTP_PF_RETRANS_IDX    3
> > +#define SCTP_PS_RETRANS_IDX    4
> 
> Use these to index the entries, please, like this:
> 
> struct bla table[] = {
> 	[MY_INDEX_ONE] = {
> 		.whatever = 1,
> 	},
> 	[MY_INDEX_TWO] = {
> 		.fields = 2,
> 	},
> 	{
> 		.there = 3,
> 	},
> 	{
> 		.are = 4,
> 	},
> };
> 
> I think that works even without all entries in the table having the
> index.. ?
> 

Cool. I will send a V3.

Thanks,
// Firo