Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 30 Nov 2022 20:41:11 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     "Arnd Bergmann" <arnd@arndb.de>
Cc:     "Richard Cochran" <richardcochran@gmail.com>,
        YueHaibing <yuehaibing@huawei.com>,
        "David S . Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        "Paolo Abeni" <pabeni@redhat.com>,
        "Naresh Kamboju" <naresh.kamboju@linaro.org>,
        Netdev <netdev@vger.kernel.org>, linux-kernel@vger.kernel.org,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        "Florian Fainelli" <f.fainelli@gmail.com>
Subject: Re: [PATCH] net: broadcom: Add PTP_1588_CLOCK_OPTIONAL dependency
 for BCMGENET under ARCH_BCM2835
Message-ID: <20221130204111.2287b2c9@kernel.org>
In-Reply-To: <10c264a3-019e-4473-9c20-9bb0c9af97c3@app.fastmail.com>
References: <20221125115003.30308-1-yuehaibing@huawei.com>
        <20221128191828.169197be@kernel.org>
        <92671929-46fb-4ea8-9e98-1a01f8d6375e@app.fastmail.com>
        <10c264a3-019e-4473-9c20-9bb0c9af97c3@app.fastmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 29 Nov 2022 12:58:23 +0100 Arnd Bergmann wrote:
> > The original report was for a different bug that resulted in the
> > BROADCOM_PHY driver not being selectable at all.
> >
> > The remaining problem here is this configuration:
> >
> > CONFIG_ARM=y
> > CONFIG_BCM2835=y
> > CONFIG_BCMGENET=y
> > CONFIG_PTP_1588_CLOCK=m
> > CONFIG_PTP_1588_CLOCK_OPTIONAL=m
> > CONFIG_BROADCOM_PHY=m
> >
> > In this case, BCMGENET should 'select BROADCOM_PHY' to make the
> > driver work correctly, but fails to do this because of the
> > dependency. During early boot, this means it cannot access the
> > PHY because that is in a loadable module, despite commit
> > 99addbe31f55 ("net: broadcom: Select BROADCOM_PHY for BCMGENET")
> > trying to ensure that it could.
> >
> > Note that many other ethernet drivers don't have this
> > particular 'select' statement and just rely on the .config
> > to contain a sensible set of drivers. In particular that
> > is true when running 64-bit kernels on the same chip,
> > which is now the normal configuration.
> >
> > The alternative to YueHaibing's fix would be to just revert
> > 99addbe31f55 ("net: broadcom: Select BROADCOM_PHY for BCMGENET")
> > and instead change the defconfig file to include the phy driver,
> > as we do elsewhere.

Ah, got it now, I think. Alternatively we could flip the 'select' to 
'depends on' and make the user do the legwork? Enough brain cycles
spend on this simple fix tho, so applying, thanks! :)