Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp87435rwb; Wed, 30 Nov 2022 22:36:51 -0800 (PST) X-Google-Smtp-Source: AA0mqf6UTy2gZ/TW9LjIcHqnG10hJK6QSpq3hLu0MR848N1SsjfI1z6WSnCafOEQTCWOUiEf3LjB X-Received: by 2002:a17:906:a0d9:b0:78d:b912:6a6c with SMTP id bh25-20020a170906a0d900b0078db9126a6cmr55739613ejb.124.1669876611102; Wed, 30 Nov 2022 22:36:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669876611; cv=none; d=google.com; s=arc-20160816; b=sPobidC9OaEaukPFrtZapqHG4EYvmmT+AhXKcjTnVoL9cqJu+emOxSJAdbtfK+4hnf WcHJkmPVbXw13jeMP2CUl8a89ea7jlgTotZD1ZHKhXMIp8bsvT7ePCz4mJYMabMa7/gk ubYeOv92s/xWOu1/RfsaZ2UQkBYNAoyJnxJHsn8t2RUCtHJC9wifiuucyE3U6W4vP4xd knFR2PTHrhe4AIIiAUkCQUUNcKz1t2V9IDxOWu0IAhkfp2gD/tUl8e/DuRM5UGvF19yn a/d62lM8A14D+S1z7sfxbm4EjsJAwX0EleZd0JdRbfUm1EA309SfIp49GXHZtECa6zum feLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=yGpI1AF0qi8iMzo9jybnqrBQne8k/W1XGBdIeUlUrSI=; b=oW/yBhd6U+T5ksNx16W434cofJkUeFygGxYhDdrLBpGXINXTjTlLUBOQK5J05XAKFL shcZwtNnLXp9aEbmEDtqTwhrjgf3BlS5LWO73Acv71etQNv1tkQkz0LBlmLGguOCy+GF XCzECz67qY2p0tH7kYce6lOhbYozgtOFtyIeCK/wnwMiSljBn81PvblEW7ChvSXymz1t qFcqI6nCJjAhPuBubJ4tkUuMSbpyhMvsJanx9Am71ibGU8VQcTbtckrMBz3sW+Zj5IiK nLBgt5APY6ibga+wOwrQwTp5V9mcLZEg0lqfVKrG7eT0i8bxLZd8QWpsI+MV/sJucRGH xaZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dpYMSBdh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z13-20020a05640235cd00b0046ac358ed89si289947edc.219.2022.11.30.22.36.27; Wed, 30 Nov 2022 22:36:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dpYMSBdh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229604AbiLAFqk (ORCPT + 83 others); Thu, 1 Dec 2022 00:46:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229503AbiLAFqj (ORCPT ); Thu, 1 Dec 2022 00:46:39 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8A167740E; Wed, 30 Nov 2022 21:46:38 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5A644B81DEC; Thu, 1 Dec 2022 05:46:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D28FDC433D6; Thu, 1 Dec 2022 05:46:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669873596; bh=VUtsviNV3rU/6hUaSUnVyOu2cg1Pbw372sWMP+ogmFs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dpYMSBdhXxXGH/67nBSXACQ9sHvOFPwT6ABdASy27c6Hmn6sWH78Y+3AhwkMLGOYy PRvvDFIDxsSkaSc8tbF1AguhVsG856o7RKq6cjNHBTbh935bnCDpusce37dhQleANb +ecilIMG0BaqeB6MxYNil/gewVmeG2XRDPQ96eUPfV7ABgNdot6spXbnHXQgbdlECZ lhRA+Yr1KKU2maUYHrEgkiHPJ8fYrNLo6sqJBfttKoPt+IeP7b67XXnYU04CiEtRwu ABsKB+PHSBufaqQnnogyGxw8pLJm2jzAHALY1Cv00KuQG3fDaow8ARM//nqLpoxaqs PMEx0ndDrdXng== Date: Wed, 30 Nov 2022 21:46:35 -0800 From: Jakub Kicinski To: Daniil Tatianin Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH v1] drivers/net/bonding/bond_3ad: return when there's no aggregator Message-ID: <20221130214635.362c80e0@kernel.org> In-Reply-To: <20221129072617.439074-1-d-tatianin@yandex-team.ru> References: <20221129072617.439074-1-d-tatianin@yandex-team.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 29 Nov 2022 10:26:17 +0300 Daniil Tatianin wrote: > Otherwise we would dereference a NULL aggregator pointer when calling > __set_agg_ports_ready on the line below. > > Found by Linux Verification Center (linuxtesting.org) with the SVACE > static analysis tool. > > Signed-off-by: Daniil Tatianin Okay, went thru, now let's try CCing the maintainers of bonding...