Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <771e309e-d7c6-d4db-ab11-0df05db6b9a0@huawei.com>
Date:   Thu, 1 Dec 2022 14:15:13 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.0
Subject: Re: [syzbot] INFO: task hung in gfs2_gl_hash_clear (3)
Content-Language: en-US
To:     syzbot <syzbot+ed7d0f71a89e28557a77@syzkaller.appspotmail.com>,
        <brauner@kernel.org>, <broonie@kernel.org>,
        <catalin.marinas@arm.com>, <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <madvenka@linux.microsoft.com>,
        <scott@os.amperecomputing.com>, <syzkaller-bugs@googlegroups.com>,
        <will@kernel.org>
References: <000000000000d482ba05ee97d4e3@google.com>
CC:     <bobo.shaobowang@huawei.com>, <liwei391@huawei.com>
From:   Yu Liao <liaoyu15@huawei.com>
In-Reply-To: <000000000000d482ba05ee97d4e3@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022/11/29 16:32, syzbot wrote:
> Hello,
> 
> syzbot found the following issue on:
> 
> HEAD commit:    6d464646530f Merge branch 'for-next/core' into for-kernelci
> git tree:       git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci
> console output: https://syzkaller.appspot.com/x/log.txt?x=167aebbb880000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=54b747d981acc7b7
> dashboard link: https://syzkaller.appspot.com/bug?extid=ed7d0f71a89e28557a77
> compiler:       Debian clang version 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU ld (GNU Binutils for Debian) 2.35.2
> userspace arch: arm64
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=16467353880000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=168c3d03880000
> 

Fix missing call gfs2_make_fs_ro() int gfs2_put_super()

#syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
b7b275e60bcd

--- a/fs/gfs2/super.c
+++ b/fs/gfs2/super.c
@@ -584,9 +584,7 @@ static void gfs2_put_super(struct super_block *sb)
 	}
 	spin_unlock(&sdp->sd_jindex_spin);

-	if (!sb_rdonly(sb)) {
-		gfs2_make_fs_ro(sdp);
-	}
+	gfs2_make_fs_ro(sdp);
 	WARN_ON(gfs2_withdrawing(sdp));

 	/*  At this point, we're through modifying the disk  */
--