Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 1 Dec 2022 14:02:40 +0800
From:   Feng Tang <feng.tang@intel.com>
To:     Vlastimil Babka <vbabka@suse.cz>
CC:     Marco Elver <elver@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Oliver Glitta <glittao@gmail.com>,
        Christoph Lameter <cl@linux.com>,
        "Pekka Enberg" <penberg@kernel.org>,
        David Rientjes <rientjes@google.com>,
        "Joonsoo Kim" <iamjoonsoo.kim@lge.com>,
        Roman Gushchin <roman.gushchin@linux.dev>,
        Hyeonggon Yoo <42.hyeyoo@gmail.com>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] mm/slub, kunit: Add a test case for kmalloc
 redzone check
Message-ID: <Y4hDgEh2PP/SJDKu@feng-clx>
References: <20221130085451.3390992-1-feng.tang@intel.com>
 <20221130085451.3390992-2-feng.tang@intel.com>
 <b98a61ae-da11-00c0-60a9-30a3c043f761@suse.cz>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <b98a61ae-da11-00c0-60a9-30a3c043f761@suse.cz>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hLW08faQNvcZ308pIy2FcBYeOW1HAoimNf4nAueIZcbZ1//Z9/8u9qeGkQJY?=
 =?us-ascii?Q?85KDAgfmMibK1+KhYGDwZ7bDx8bk0NzN4/vXPPLhEM/oXxQu9FCknP0a1AXg?=
 =?us-ascii?Q?rEK2QOP27jmgGfxnxVKpAOA7eQVn2+Ri5UcmQksX1JMuB+2/HjzfH4vmgN2/?=
 =?us-ascii?Q?YGC+zURs40vdMUw3UQU/p36SAhf0cBiVDZfTpUfF4YOKZwax6wTfTfCIYOH7?=
 =?us-ascii?Q?gOhnI5dJcL65D8NuxxctXIEVjbGbKXNq5ssY9p+7ZcT9fhCbCBCgm2i1rwZ1?=
 =?us-ascii?Q?80K8yScf92SyFX4T2coSB8yLldqTjlOUVRwYIaetZlXSbrYfEMJIW3HxXMwZ?=
 =?us-ascii?Q?tkrE4o4Ralyu5zmUccwKnhjJNN3JUU8r2qrafbQLA3OVCYhDQXcvpuwh9hC3?=
 =?us-ascii?Q?I4bTDIsL+QjTjQjn0/fCniJESF9IWhR6IeqDJlHjENfnQyP4BSS5sqywobqB?=
 =?us-ascii?Q?U64ICCwhpOG5haUnLljdYxemcbpffVNIkNyb1wYmqKlrqHbTEUP87p+bCNlx?=
 =?us-ascii?Q?c5S7ATA/VEcNjpXcXZFEthAEN4Fs6ogVyX69GacY5+QD+Jz+7e+cMJQZ5UR8?=
 =?us-ascii?Q?b2UKdAE0haPtYO9+r28SWzx4a2DyeFKqguDFqsp7yYxNz2pg1XZ+g7A7Xhnz?=
 =?us-ascii?Q?KKZ21Z/up2pkjgtdUYa8BCGNRS/ZkgsB31ae2QjJqdrmm6exwLhQMw1FKCJZ?=
 =?us-ascii?Q?Fe4SHlQqk5d44WMzIK516NCy/Oc9YhRNVeAjNxfWXGfV4j3UYllex/Vn1FZk?=
 =?us-ascii?Q?h6U+Hyq+iKm6XBpLTp5MNmvvVDq9Ujb+8Rjk2fUUau+uhgaVo5W8O/bXurLh?=
 =?us-ascii?Q?94K3/3IUsGGWMTZIcSEWOs8sDK/RSLF3SNxXCapbzCijwKLKoPXJ0dOEdXAz?=
 =?us-ascii?Q?KnVXd4k6Ln85cBHJApysBLiRV3dymy3t0nfKRId82mBK/PqDaAzQ9GGE1jZj?=
 =?us-ascii?Q?F4fLpYJHzSzL9u1W1Rnv6oZQ9hRYajtGoFy0XvmdoIMXHsyiFfUX9dpfNPeW?=
 =?us-ascii?Q?wbc/C9FL5R1n3xXtOmGm0vAJG60YcO/rwE38WtZkXYDDlqmOY0K7IZ1xGs+V?=
 =?us-ascii?Q?95PbmxvN63ywI8BVv58xivADOtXfaJrIYCo1/yIn2morQfdPApIFOy5Lrk8a?=
 =?us-ascii?Q?3Ic5AttDcs1BnY5YZGnQLgy5s9iNUQnds+cmw1HQty3HCIU8P/Wc/r/Lp188?=
 =?us-ascii?Q?DQiuO7qFDlR5nDXg1tX6EjkZzZ4CpWrhqQ5d3agti8w0RjZXU/EFHfx6lzJg?=
 =?us-ascii?Q?QTxrf3brRHBRkxQ/+TsLnDqHQlayV4DuL7y0hrtuMkwu4DHkDhacNNxiemup?=
 =?us-ascii?Q?JZjjNRX8tP4kfZvTPHSc5Y7os2Om7zMLuelQsiYyiJ+L+CRtPuw6q2h8y3MO?=
 =?us-ascii?Q?9BKpmfC8cm5/lBcz5/09acJpXqrzxBYJUM20LxGELRblzgh7Yi9py11LXo63?=
 =?us-ascii?Q?cmXeLu97i2qyvJbiPXi88Qv7WSawpGWSg4He4V31QFCOVVA/1VhKP9/vKXwI?=
 =?us-ascii?Q?9UsguVp6jarQCBNXwifNK7rVb2sfrTx9hieL9peN/H4TMroanb1xi2ZOKAiD?=
 =?us-ascii?Q?+O09oDin+JkNLAoXUWzyaa1qMFNmQX/b66gRUS2S?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 376b3284-7161-4fd2-268b-08dad3621580
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6304.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2022 06:05:44.9040
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xbT8IrrsLdAjw/OWd01EctHmlOhXaUMYA+WdE4q4FBgoWimshWOBLR1vI9TZStDwRPMJSYqaxh8NFKH1cY4oFQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4905
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Dec 01, 2022 at 12:05:41AM +0100, Vlastimil Babka wrote:
[...]
> > diff --git a/lib/slub_kunit.c b/lib/slub_kunit.c
> > index 5b0c8e7eb6dc..ff24879e3afe 100644
> > --- a/lib/slub_kunit.c
> > +++ b/lib/slub_kunit.c
> > @@ -135,6 +135,27 @@ static void test_clobber_redzone_free(struct kunit *test)
> >  	kmem_cache_destroy(s);
> >  }
> >  
> > +static void test_kmalloc_redzone_access(struct kunit *test)
> > +{
> > +	struct kmem_cache *s = test_kmem_cache_create("TestSlub_RZ_kmalloc", 32,
> > +				SLAB_KMALLOC|SLAB_STORE_USER|SLAB_RED_ZONE);
> > +	u8 *p = kmalloc_trace(s, GFP_KERNEL, 18);
> > +
> > +	kasan_disable_current();
> > +
> > +	/* Suppress the -Warray-bounds warning */
> > +	OPTIMIZER_HIDE_VAR(p);
> > +	p[18] = 0xab;
> > +	p[19] = 0xab;
> > +
> > +	kmem_cache_free(s, p);
> > +	validate_slab_cache(s);
> > +	KUNIT_EXPECT_EQ(test, 2, slab_errors);
> 
> With this ordering the expectation was failing as slab_Errors was 0, had to
> fix it up to look more like TestSlub_RZ_alloc:

Thanks for the catch and fix!

I checked why it worked in my test, and it should be related with
kasan. My test environment has both kasan and kfence enabled, and
kasan could delay the object freeing, and with the original code,
when validate_slab_cache() is called, the object is not freed yet
and gets redzone-checked. 

> > +	kasan_enable_current();
> > +	kmem_cache_destroy(s);
> > +}
> > +
> 
> --- a/lib/slub_kunit.c
> +++ b/lib/slub_kunit.c
> @@ -148,11 +148,11 @@ static void test_kmalloc_redzone_access(struct kunit *test)
>         p[18] = 0xab;
>         p[19] = 0xab;
>  
> -       kmem_cache_free(s, p);
>         validate_slab_cache(s);
>         KUNIT_EXPECT_EQ(test, 2, slab_errors);
>  
>         kasan_enable_current();
> +       kmem_cache_free(s, p);
>         kmem_cache_destroy(s);
>  }
> 
> With that, added both to slab.git branch slab/for-6.2/kmalloc_redzone
> Thanks!

Thanks!

- Feng