Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp193168rwb; Thu, 1 Dec 2022 00:37:42 -0800 (PST) X-Google-Smtp-Source: AA0mqf68g6Eom6+WMtOusFpMZrpOBelXkQqfNiak9XbWhQoXXi+JVFLZqXRaVgEwn993kYhr2P6V X-Received: by 2002:aa7:c046:0:b0:461:54f0:f7dc with SMTP id k6-20020aa7c046000000b0046154f0f7dcmr59049706edo.117.1669883862533; Thu, 01 Dec 2022 00:37:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669883862; cv=none; d=google.com; s=arc-20160816; b=colTEieoiZv+B/gbHQR6rIH2o+qyZbxbM/gXShJ8LFcb6s11S8KaZTCCvDbCTIavDB IfYJUlOqKTT69u8ouD5kvcvXzJ3Byr8/o9pIODzi6b9SzKzMMAbaYfq7TrAiKmQv6dvW AL6oupLG2Cv2QA6ZAmOsldUqb8avqQvGEUO5MFMd/Hms7VJIBcCDHOBReoSf4lcuYXAq B3n6DpfKU8+173TJxRW7NR4doR9cyGEHWVIWQxxizRUD1YNq/x23uZ8t+T4DQpo2k1dh qDSXtK+YTJ9cFk7LHc8cVErd03Iv6tSVUp9yrrUO9JNnAEbWsmTD1reYVTS4gkbI/Sok HEBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ycRR+pwqeL9C2U4meHEyRihzbISpIr+4iJ/828SKBsw=; b=aqEjbIkUWS7SHgO+a6020yQyTyH1EJEhhIh2pz7QcVP5RoIZHGQ3BFVkr5UsP4Rek8 7IEpdMDDLCcjLuxypXBUSGOHQi9dAHRrIGThh/0T04MQnnpv/ge31yAXE9COMHJW28+E chZkfVDlEU0p6cgWZ4tV4JqH2QTWBxE+M0URZ59nOmSyOftEnyCOA8wKvp+8lz5B6gZR aVA3y3l1eSqY7VuPj6GffaV0r4jCPPJUsFNyGrTsySjyqjTDt++ytNJU9M+D8BaQzGnH p8TunXZ002ppwbaLAlYApvKL8ya1FC5GWmwQc2AXwqzR0lVHHlpox6/d6ZE7sy/nmsMj tlXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="yqk59b/S"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i29-20020a50d75d000000b00461ace746adsi3232174edj.453.2022.12.01.00.37.22; Thu, 01 Dec 2022 00:37:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="yqk59b/S"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229797AbiLAI11 (ORCPT + 82 others); Thu, 1 Dec 2022 03:27:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229599AbiLAI1G (ORCPT ); Thu, 1 Dec 2022 03:27:06 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9D23697E7; Thu, 1 Dec 2022 00:26:53 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8C7E961EC7; Thu, 1 Dec 2022 08:26:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7AF10C433C1; Thu, 1 Dec 2022 08:26:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1669883213; bh=9b2/8eE9yzlYofYNhF+OGMGr1M4s1PGOfebwoAlphxU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=yqk59b/SkAVAtAcqGgpSCFRdSfpJMkFYN+ZHNKX3FGmCSFe1KGxvOwnUlJYYENx+N 16G8Tc28Xv5BntgYYsWaDD0UvxWF3yVG8OSOMW3hh1Sc64DyEHWGm8u41YCM3Aora+ kf/CxTpj7H74WEKYIPKU7RTSPe+5FJ5va3wcLU8k= Date: Thu, 1 Dec 2022 09:06:55 +0100 From: Greg Kroah-Hartman To: Daehwan Jung Cc: Rob Herring , Krzysztof Kozlowski , Alim Akhtar , Mathias Nyman , Arnd Bergmann , Linus Walleij , Colin Ian King , Artur Bujdoso , Juergen Gross , Tomer Maimon , "open list:USB SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES" , "open list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES" , open list , sc.suh@samsung.com, taehyun.cho@samsung.com, jh0801.jung@samsung.com, eomji.oh@samsung.com Subject: Re: [RFC PATCH v1 2/2] usb: host: add xhci-exynos to support Exynos SOCs Message-ID: References: <1669860811-171746-1-git-send-email-dh10.jung@samsung.com> <1669860811-171746-3-git-send-email-dh10.jung@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1669860811-171746-3-git-send-email-dh10.jung@samsung.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 01, 2022 at 11:13:31AM +0900, Daehwan Jung wrote: > This driver works with xhci platform driver. It needs to override > functions of xhci_plat_hc_driver. Wakelocks are used for sleep/wakeup > scenario of system. So this means that no other platform xhci driver can be supported in the same system at the same time. Which kind of makes sense as that's not anything a normal system would have, BUT it feels very odd. This whole idea of "override the platform driver" feels fragile, why not make these just real platform drivers and have the xhci platform code be a library that the other ones can use? That way you have more control overall, right? thanks, greg k-h