Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <444e806b-4593-7ea9-a8aa-27d2f726a751@amd.com>
Date:   Thu, 1 Dec 2022 14:32:14 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
From:   Sandipan Das <sandipan.das@amd.com>
Subject: Re: [PATCH] perf: Fix interpretation of branch records
To:     James Clark <james.clark@arm.com>,
        linux-perf-users@vger.kernel.org, acme@kernel.org,
        Anshuman.Khandual@arm.com
Cc:     linux-kernel@vger.kernel.org,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>
References: <20221130165158.517385-1-james.clark@arm.com>
Content-Language: en-US
In-Reply-To: <20221130165158.517385-1-james.clark@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eGdNU2JjbFRiUzBpTkNaQnJXRUY1aGZkQk1scXZscHpkZVQwMndaZlZQc2pG?=
 =?utf-8?B?MFk4cXpYcWN0bTgvZGhHb05rRjNNWE9jaUFwb1MxaUtPQXlEOStGY3R0a0lw?=
 =?utf-8?B?YXU2cnI1VXg3THVnK0NUWDJGN296L216OFRNQm9YczRKczM0VW0ycm5YelND?=
 =?utf-8?B?c3phVXVYdEo0dWdMZHFqV2RwdjQ0SUNSSXNTRGNQbEhpWFUvNzJSSWswNkxv?=
 =?utf-8?B?RU1vWFRPS3ZXTkQ5eEh1WWw0aHFuTzRiMVFSbVNtenFnaVVVeDJPOE1PV1pQ?=
 =?utf-8?B?NU03aDJGVXZRV2dVMjIvTXZGODdpRTBHa01nRGE2TjkvU2w3UzBQNGE2TTZO?=
 =?utf-8?B?QTMweWF3L2JuZkVvNy8zVVRZb2d6WjBEUGVacENzaGtZTDZDSUNFc2RvZ2xO?=
 =?utf-8?B?dkM1MS9Hb0xwQlVrZVZkY2UxTStGRVg2eDVJNENJUmlCWU1MN0tFSmtBcTdh?=
 =?utf-8?B?cHhqVmhGb0pCcVJoU0xFVHhROW93UlZsUjZLRFBQc2JPQktiYjFldGFZQkNU?=
 =?utf-8?B?T00vNXFmeEEzaEN0K1JNVmZ6MDhFeEQvNkJuYUs5bVlVM3RTTkg5TWFRcEtU?=
 =?utf-8?B?SGUza244NVdWWkU2M2lidHNkQ2xzU0NlL2FLOVVkZmc3aDY3MkRYUmxRRUZV?=
 =?utf-8?B?NjNVWmdPMjJpT1JtMFFSeTk2SnZsTzg5SThtb3VkNHdlTWpGbWM4djZSdVUv?=
 =?utf-8?B?WVBZaC9ldXJLZEM1UHNDa2VCYVBaRDFMM0VFQXBRTlhmWXU3S0NhZVBxZlo2?=
 =?utf-8?B?SFA3aEo1dWZaeEtnbmRFU1doMFM5bWFEeU0rUXg4dzZzZ1JjY1o2VG13dHNi?=
 =?utf-8?B?ZnFaTEU2R3NUSWRtOHMvOVpVUFNuclBwVlVKa0ptRlNueklnYzRxZEVidjVQ?=
 =?utf-8?B?UFZsNnRLZ1BDclBDSHRMMDA3bEMvMjJteDE5SzdXUDIxeGRsR2hQQ3plSTF6?=
 =?utf-8?B?Y2U0d2lBT0E2WDFBMVN6QkVSU1BOZDlEWUFiVE1IN0V1SDZ5UzNxeEpGSDBv?=
 =?utf-8?B?L0M0NnNGSkxsbnRzNDFIYldLTGFmUldXYkRuZXNaem5hc1Q2eUJTTTBSMlUy?=
 =?utf-8?B?Mk5Oc0RxRUxPMVZsc0FmZmtJNDRhWXQrdkZJOElqeE9yOWJQb0o4TEZRK3ln?=
 =?utf-8?B?OCtlN3JiQ1l6RlBKNGJ4RzlWU3cySGVwaENkZi9zbDhSck83MHdBUnBkcHpN?=
 =?utf-8?B?d3NTMjZOZkRLZ1VoeWhBdmFhWnB3cy9RUndDSjE5UHd6MExVMnp1bUpTdzBJ?=
 =?utf-8?B?ZTFvUEgwS2dGSEM1ekhINmpwN2lnU1h2am1iQ0twSi80MW5XblBlQW9TSis2?=
 =?utf-8?B?RVAyeTV3SVJqcld5YmVRSmhhRWF3eG1ZbHBnckQrZzEwc0lEVHIvNVNLdTBz?=
 =?utf-8?B?T2U4a3JoQ2VCZ01jNVgxRE16Unc3ZWo2RzRQNHY4WmtoaDdhRFhvSVEzdUVR?=
 =?utf-8?B?VTNEMVZSa2k4dlNkQnlSVjNrbXBYVGhTQjBYa1VnOWsxRmVIK3JZWVNpdjE5?=
 =?utf-8?B?a0F0c3dKOUowT0VzbVg5a3dWVXNORFk1dHhpMjhFSnJ5RjI2S3kwTDQ0NXdB?=
 =?utf-8?B?WjJnWFJ0d3FmRzJ1Sjg0YktpcVhNa1Y1Skkza1NoRlg4OURqeVJ0R2tOeUdX?=
 =?utf-8?B?ZVgrd01pME1VRERZS3RaYXlMdnVXUEJvWFMvVFJxSkN4S3R0VkZaaHZLL2Ry?=
 =?utf-8?B?WXJzV2VoVlg4Um5Hdk4xTXZPdWN2bWNPeVVrUThmdEhFS1Q3VGI0ZWVhWmhn?=
 =?utf-8?B?ZUp5aVJYblRjemxQYTNKbm1rUUxGTFJJSFBjOHB4R2l0MENoYkZsVHRPTEpT?=
 =?utf-8?B?NTNNaG0yNSs3R2dMeDdQWGVJRlEwclpHZkJuVHlxR3R3aDV2QjJ2ZUEvd1o0?=
 =?utf-8?B?elJ6OXhYVWkvcjRGelpodmhxblpheExYNG54eVJZelFIWXNGRm50ZEIxNUJV?=
 =?utf-8?B?REJDanZZNlZYYlE2cjI2V01yY2NtdzFpMlNXMUY5SHltRWR6SWVTZ25weW1B?=
 =?utf-8?B?RTh6UldDRWtHRUh0UHQ4OHZkYzNDUC9vOG95TStGWlNuQ1dXNXd0S0QyMVBz?=
 =?utf-8?B?L0JUREVEL2J2YUFSZGNzaUtJS2xYRGtoOHdwQ3VMTmpVYStpMSt0dlRhYkRP?=
 =?utf-8?Q?S08sPN6KDyX1ATgx4Y7Q6mtDS?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a4a285ac-ad10-45f2-537b-08dad37ac551
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB5712.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2022 09:02:27.9551
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MQ0bK8DE0nwWf48iWml1pPa9tK6OzShaK17JrnyldmIg9tMEXiZMquDbm4i18XQlVYuYIkvVLfqdiu+8x6nekA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5312
X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/30/2022 10:21 PM, James Clark wrote:
> Commit 93315e46b000 ("perf/core: Add speculation info to branch
> entries") added a new field in between type and new_type. Perf has
> its own copy of this struct so update it to match the kernel side.
> 
> This doesn't currently cause any issues because new_type is only used
> by the Arm BRBE driver which isn't merged yet.
> 
> Fixes: 93315e46b000 ("perf/core: Add speculation info to branch entries")

Technically, in the kernel sources, commit 93315e46b000 ("perf/core: Add
speculation info to branch entries") landed before commit b190bc4ac9e6
("perf: Extend branch type classification").

So I think the Fixes tag should instead have commit 0ddea8e2a0c2
("perf branch: Extend branch type classification") which added the
UAPI changes to the perf tool headers.

Aside from that, the patch looks good to me.

> Signed-off-by: James Clark <james.clark@arm.com>
> ---
>  tools/perf/util/branch.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/branch.h b/tools/perf/util/branch.h
> index d6017c9b1872..3ed792db1125 100644
> --- a/tools/perf/util/branch.h
> +++ b/tools/perf/util/branch.h
> @@ -22,9 +22,10 @@ struct branch_flags {
>  			u64 abort:1;
>  			u64 cycles:16;
>  			u64 type:4;
> +			u64 spec:2;
>  			u64 new_type:4;
>  			u64 priv:3;
> -			u64 reserved:33;
> +			u64 reserved:31;
>  		};
>  	};
>  };