Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <62399b9c-d5ef-4c56-4592-d2cf1af503d6@amd.com>
Date:   Thu, 1 Dec 2022 14:43:26 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH v2 2/2] perf test: Add event group test
To:     "Liang, Kan" <kan.liang@linux.intel.com>
Cc:     acme@kernel.org, irogers@google.com, jolsa@redhat.com,
        namhyung@kernel.org, peterz@infradead.org, mark.rutland@arm.com,
        adrian.hunter@intel.com, alexander.shishkin@linux.intel.com,
        carsten.haitzler@arm.com, leo.yan@linaro.org, maddy@linux.ibm.com,
        kjain@linux.ibm.com, atrajeev@linux.vnet.ibm.com,
        tmricht@linux.ibm.com, linux-perf-users@vger.kernel.org,
        linux-kernel@vger.kernel.org, sandipan.das@amd.com,
        ananth.narayan@amd.com, santosh.shukla@amd.com,
        Ravi Bangoria <ravi.bangoria@amd.com>
References: <20221129111946.409-1-ravi.bangoria@amd.com>
 <20221129111946.409-3-ravi.bangoria@amd.com>
 <0dd566ab-38fd-2204-f59c-e74b2244828b@linux.intel.com>
Content-Language: en-US
From:   Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <0dd566ab-38fd-2204-f59c-e74b2244828b@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S0RvK2xaRjFEdTFaY2gydHdOYlJKSTQwSGg0a3JnNXRqTys2Wmt2b1hONExl?=
 =?utf-8?B?TDhMYVpZOTljNkR6RExYaTVqZHBuSi96QUxoYTFESy91aG4rYm5aVlRjUGpB?=
 =?utf-8?B?N0c0dDVwS0U2OGZ2YzZ4NnVPc0N4a2VqZ0dQZDhNbTRGTnZweldmY3dyUzlQ?=
 =?utf-8?B?UUhweFE4WDdrYzdKSE5SWDgrR21uVURGbTdLVmpHeS9CRW9CU0UwcWlnaDBi?=
 =?utf-8?B?OE9zcUZyMWEzeDBQaUdPZUxUL0FBWlFCWENPT2FjQzdQRzFFdlc5Y0twdTYx?=
 =?utf-8?B?NExxWG8vN1FWVGtEYjYvOEttcU1yV0pKcEFGWnF3akVrRkUxNHlyNGZvUU5Y?=
 =?utf-8?B?aVlqS05SMVlLZWZ2RHNlbUo5bEpMOC9halJVUVZEMjVUZUNvTUN6bGZhN3Ix?=
 =?utf-8?B?V1JDMzQwTWs5a0lXQkJsZC92YUpDcFZPK20yekh4SEpYQjFIZWdyL0V5cWhh?=
 =?utf-8?B?SmxDTFkzVGxMcTh6ZzYyRHR3VVQ2bTZ2U2o2cWxMc1h5cWpsbHhPcm9sbkN6?=
 =?utf-8?B?QU40Ry8ra3Y1azl2SlJ0Yy9JQTBJNXBLMDIrKzNnQVRneEJldUVRY2YvYzU5?=
 =?utf-8?B?N285cUl0RG9nbWtDSmVYcy80bkVjdk1MQ2xLSFludmwzVUdudXNBTk1jQXNS?=
 =?utf-8?B?T3N2M3ZDV0UzSm1BZnAza1RscFJVL1JGcXBvZW9PaWxIdUVnVzNEcU1Vazhz?=
 =?utf-8?B?b3N0Ti9CUUJIRit4dmtkc3YwVnpVdDB6THVtVmE3Z1lFU2ZXcm1mRVR1SXAy?=
 =?utf-8?B?Tmk5M3N5dDF5OTBORGhwakNYL05TN29YNjFYekRVZk9tN01IZjRCdXFwNmx5?=
 =?utf-8?B?WkJtTTM1OUdKUkx4SmpROExVV2EwdmpwbzNBYlByUWxlbXA4M3BLMWJqck1u?=
 =?utf-8?B?bzY5Njk1MXN1eUtHTDVwNHpPVTgrZHhSZFE0Q0doN2k0dXlHQ0VUYnVVUzd6?=
 =?utf-8?B?TTZpc3R1L0xpcFc4eUNXdml2US9DSGpVYmxNNEkyVFUveC9VWnBYNFFqTXhi?=
 =?utf-8?B?NTYyeEhiTUlXUXN2bnZHa1lVR3JGQmZld0JBN3N0eXRSelo1bEJUUjVBQyt6?=
 =?utf-8?B?MmVCdy9sZXlpdGttWWkrNU5tUldRMjc2S3ZoY1VUQXRXa29NKzdmYUV5MzVt?=
 =?utf-8?B?OHNyZ1pXcmgzdTFoM0s3ci85S0EzWXhHcXk2OUorT0ZVSmlETDNNWHkwaERw?=
 =?utf-8?B?SWxzZkI5Y0VaUHprbUJnMlc4RzI4SWRsWUJBcDNYRktLYVhleHQ1Uzlqd0ha?=
 =?utf-8?B?R1AyQUw2dEh5ekxOcit0K3ExV1ZybkFaMlQ1RG5QVXBFZUZMekpJK3ZXQ0NO?=
 =?utf-8?B?elc2SmMvZi91MXZrc0VwdTF1R1k4d0pHYzhSVU1LZVU3aTA1T3BDUGpQYXZp?=
 =?utf-8?B?dU1MUGdKOHRCbmZUK2JXNzk3MU5OeVQrajFvTk5CSUNVWmZwcmRNQkdyOFcr?=
 =?utf-8?B?R01iZm52UzRaOFBybnJ3RWl2bXhJbXZaOGw4SUZIdG1oTE1VYk5UbzBoY3g1?=
 =?utf-8?B?aURYSHIzbzVFYy9hbXdTRUM2czB4Qm0wR3ZXdU95a3RvcWtIL3JiR1hXYkcz?=
 =?utf-8?B?dk4wNGhZS1dXU1pwVGZCL3I4OFVDZmxsUHJIMDZQV281NmtJQjJkdC9kNXpS?=
 =?utf-8?B?bnNkVjVrSEpzcjhZZU5PTE1nalZrQ01xZ0xKbnNXL29ZQjNpQXBFQnFnbXlL?=
 =?utf-8?B?MlJuZHhRRW1CUnlDZnVoNmlUU0cvR3U0RCtBOGVKNGVzOVhlKzIzZUhTMDBj?=
 =?utf-8?B?MU5EOVNVd1BqSUlObTJ2dzlJM0YzcWNpbHpwK2J0L0l3TEZDQVBzeVRRdWJX?=
 =?utf-8?B?WVlCaXM3cWZqUVJpT3B2dWw2dUxYMDJRSzRaWE1ERjRQNUFqckxPWkFwQzVv?=
 =?utf-8?B?NlZXS2FUbGYwSXIwMVE1M2p5WG9WTlEzbnJHa1FYcEhtYTdsS3JjVU9UQzFr?=
 =?utf-8?B?OU41R1dXaFRqODRpYW9pbE9tbWVOYmlGTUpvWjhWcDRCeG9waVZ4dTZZSUZ5?=
 =?utf-8?B?RnN0RDA4TU1pMXFQM3R4L00wTHowZ1luSDdvRmRGd1VOd3l1Q1FSL0JLeDVn?=
 =?utf-8?B?WWZueUYrZ3hVa2ZjbkJ2KytTVFNWQ0M5ZVd2bDUzcVN2U1NzYWJmRnViSjhS?=
 =?utf-8?Q?cLldeyxRSIvMwggk5Ke2W9mUx?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6bad2597-a255-459e-ec91-08dad37c57f8
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2022 09:13:43.4819
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Jl0449EiGr53E9NAElO5ML9kn6qabkqtWNePN8Bh6z17CtxDuJaS9emx/wo80mw0tTDq9qHvdMg9Kbo7TvFucg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6767
X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Kan,

Thanks for the review.

>> +static int setup_uncore_event(void)
>> +{
>> +	struct perf_pmu *pmu;
>> +
>> +	if (list_empty(&pmus))
>> +		perf_pmu__scan(NULL);
>> +
>> +	perf_pmus__for_each_pmu(pmu) {
>> +		if (pmu->is_uncore) {
> 
> Always using the first uncore PMU may trigger false alarm on some Intel
> platforms. For example, Intel has free running uncore PMUs (e.g.,
> uncore_imc_free_running_0), which only supports special event encoding
> 0xff. The config 0 must fails.
> You may want to add the below check to ignore the free running uncore PMUs.
>                         if (strstr(pmu->name, "free_running"))
>                                 continue;
> 
> 
> Also, some uncore PMUs only support two counters. But the test assumes
> that the number of counters > 2. You may want to limit the size of the
> group for 2 for a pure uncore group.

That seems hacky. Instead of ignoring, would it be possible to provide
a list of testable pmus? Example with random values:

  /* Uncore pmus that support more than 3 counters */
  static struct uncore_pmus {
      char *name;
      unsigned long config;
  } uncore_pmus[] = {
      { "amd_l3",         0x0  },
      { "amd_df",         0x0  },
      { "uncore_imc_xxx", 0xff },   /* Intel */
      { "intel_xxx_pmu2", 0xff },   /* Intel */
      { "abc_pmu1",       0x0  },   /* Arm */
      { "hv_24x7",        0xa  },   /* PowerPC */
      { ...                    },
  };

  perf_pmus__for_each_pmu(pmu) {
      if (pmu present in uncore_pmus[])
          type[2] = pmu->type;
          config[2] = pmu->config;
  }

Ofcourse, this should work for all architectures. Arm, PowerPC, s390 folks?

Thanks,
Ravi