Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   wangchuanlei <wangchuanlei@inspur.com>
To:     <kuba@kernel.org>
CC:     <echaudro@redhat.com>, <alexandr.lobakin@intel.com>,
        <pabeni@redhat.com>, <pshelar@ovn.org>, <davem@davemloft.net>,
        <edumazet@google.com>, <wangpeihui@inspur.com>,
        <netdev@vger.kernel.org>, <dev@openvswitch.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [PATCH v6 net-next] net: openvswitch: Add support to count upcall packets
Date:   Thu, 1 Dec 2022 03:46:01 -0500
Message-ID: <20221201084601.3598586-1-wangchuanlei@inspur.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7BIT
Content-Type:   text/plain; charset=US-ASCII
tUid:   20221201164602824ffe32c6994f19eee192ef09416773
Abuse-Reports-To: service@corp-email.com
Precedence: bulk

Hi, Jakub, 

	Thank you for review, the comments below is a little confusing, can you
give a explanation?

Best regards!
wangchuanlei

--------------------------------------------------------
On Wed, 30 Nov 2022 04:15:59 -0500 wangchuanlei wrote:
> +/**
> + *	ovs_vport_get_upcall_stats - retrieve upcall stats
> + *
> + * @vport: vport from which to retrieve the stats
> + * @ovs_vport_upcall_stats: location to store stats

s/ovs_vport_upcall_//

> + *
> + * Retrieves upcall stats for the given device.
> + *
> + * Must be called with ovs_mutex or rcu_read_lock.
> + */
> +void ovs_vport_get_upcall_stats(struct vport *vport, struct ovs_vport_upcall_stats *stats)