Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221129115217.129290-1-marpagan@redhat.com>
In-Reply-To: <20221129115217.129290-1-marpagan@redhat.com>
From:   Oded Gabbay <ogabbay@kernel.org>
Date:   Thu, 1 Dec 2022 12:31:18 +0200
Message-ID: <CAFCwf11cqNHZhAR0b8iKnGeT_XVy5Oa2KHjNo7ROVF2-MjYZfA@mail.gmail.com>
Subject: Re: [PATCH] habanalabs: fix double assignment in MMU V1
To:     Marco Pagani <marpagan@redhat.com>
Cc:     Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Tom Rix <trix@redhat.com>, linux-kernel@vger.kernel.org,
        llvm@lists.linux.dev
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Nov 29, 2022 at 1:52 PM Marco Pagani <marpagan@redhat.com> wrote:
>
> Removing double assignment of the hop2_pte_addr
> variable in dram_default_mapping_fini().
>
> Dead store reported by clang-analyzer.
>
> Signed-off-by: Marco Pagani <marpagan@redhat.com>
> ---
>  drivers/misc/habanalabs/common/mmu/mmu_v1.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/misc/habanalabs/common/mmu/mmu_v1.c b/drivers/misc/habanalabs/common/mmu/mmu_v1.c
> index 8a40de4a4761..d925dc4dd097 100644
> --- a/drivers/misc/habanalabs/common/mmu/mmu_v1.c
> +++ b/drivers/misc/habanalabs/common/mmu/mmu_v1.c
> @@ -344,7 +344,6 @@ static void dram_default_mapping_fini(struct hl_ctx *ctx)
>                 }
>         }
>
> -       hop2_pte_addr = hop2_addr;
>         hop2_pte_addr = hop2_addr;
>         for (i = 0 ; i < num_of_hop3 ; i++) {
>                 clear_pte(ctx, hop2_pte_addr);
> --
> 2.38.1
>

Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Applied to -next.
Thanks,
Oded