Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 1 Dec 2022 10:25:19 +0000
From:   Sudeep Holla <sudeep.holla@arm.com>
To:     Wang Honghui <honghui.wang@ucas.com.cn>
Cc:     Cristian Marussi <cristian.marussi@arm.com>,
        Sudeep Holla <sudeep.holla@arm.com>,
        Jassi Brar <jassisinghbrar@gmail.com>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH]mailbox/arm_scpi: Add to support Phytium FT2000/4 CPUs,
 show temperature of cpu.
Message-ID: <20221201102519.epkictlook3lzs4q@bogus>
References: <414EB9088FC46457+Y4hS8eOJa/XUQ8xR@TP-P15V>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <414EB9088FC46457+Y4hS8eOJa/XUQ8xR@TP-P15V>
Precedence: bulk

On Thu, Dec 01, 2022 at 03:08:33PM +0800, Wang Honghui wrote:
> Add to support Phytium FT2000/4 CPUs, show temperature of cpu.
> 
> Signed-off-by: Wang Honghui <honghui.wang@ucas.com.cn>
> ---
>  drivers/firmware/arm_scpi.c       |   1 +
>  drivers/mailbox/Kconfig           |   6 +
>  drivers/mailbox/Makefile          |   2 +
>  drivers/mailbox/phytium_mailbox.c | 193 ++++++++++++++++++++++++++++++
>  4 files changed, 202 insertions(+)
>  create mode 100644 drivers/mailbox/phytium_mailbox.c
> 
> diff --git a/drivers/firmware/arm_scpi.c b/drivers/firmware/arm_scpi.c
> index 435d0e2658a4..876eb2f9ff81 100644
> --- a/drivers/firmware/arm_scpi.c
> +++ b/drivers/firmware/arm_scpi.c
> @@ -904,6 +904,7 @@ static const struct of_device_id shmem_of_match[] __maybe_unused = {
>  	{ .compatible = "amlogic,meson-axg-scp-shmem", },
>  	{ .compatible = "arm,juno-scp-shmem", },
>  	{ .compatible = "arm,scp-shmem", },
> +	{ .compatible = "phytium,ft2004-scpi-shmem", },


Where is the binding for this new compatible ?
And why do you need this ? Any particular reason why you can't use the
generic "arm,scp-shmem" ?

I don't see the need for this change. Please drop it.

--
Regards,
Sudeep