Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 1 Dec 2022 12:14:50 +0100
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Markus Schneider-Pargmann <msp@baylibre.com>
Cc:     Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
        Wolfgang Grandegger <wg@grandegger.com>,
        linux-can@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/15] can: m_can: Cache tx putidx and transmits in flight
Message-ID: <20221201111450.fpadmwscjyhefs2u@pengutronix.de>
References: <20221116205308.2996556-1-msp@baylibre.com>
 <20221116205308.2996556-4-msp@baylibre.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ysvt4sh7xyxarrpp"
Content-Disposition: inline
In-Reply-To: <20221116205308.2996556-4-msp@baylibre.com>
Precedence: bulk


--ysvt4sh7xyxarrpp
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 16.11.2022 21:52:56, Markus Schneider-Pargmann wrote:
> On peripheral chips every read/write can be costly. Avoid reading easily
> trackable information and cache them internally. This saves multiple
> reads.
>=20
> Transmit FIFO put index is cached, this is increased for every time we
> enqueue a transmit request.
>=20
> The transmits in flight is cached as well. With each transmit request it
> is increased when reading the finished transmit event it is decreased.
>=20
> A submit limit is cached to avoid submitting too many transmits at once,
> either because the TX FIFO or the TXE FIFO is limited. This is currently
> done very conservatively as the minimum of the fifo sizes. This means we
> can reach FIFO full events but won't drop anything.

You have a dedicated in_flight variable, which is read-modify-write in 2
different code path, i.e. this looks racy.

If you allow only power-of-two FIFO size, you can use 2 unsigned
variables, i.e. a head and a tail pointer. You can apply a mask to get
the index to the FIFO. The difference between head and tail is the fill
level of the FIFO. See mcp251xfd driver for this.

Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--ysvt4sh7xyxarrpp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmOIjKcACgkQrX5LkNig
0106Pgf/c+3LyxVEAyWReUSMy4S25PKscNC/HC7FSIfZv/T4pUhUfhjoNHFsdOKD
mxJS60E0hXNuER/oOjUzN/hQYCf8eLDmo7lY1ABkwUMqt03s6ouIeo2nUIxfYBHM
Cxiju541PilmMvIhydL/j0YMPfexOvvVV6XJHGHPTPAfoRF/adHphiIMHg34IVbv
R/mZtnutVHNwnjaZLmM0ffiXHxyRexca5ptziY6cqzT5S11ktYPPyqcx4NPxbZeF
iVCKBICb2Yu4vqFF93shAflWPnfLrgIHewju/lSYA3yGFOgzATIRF/iawTdmK/8K
e3WT//xQtxnLxJG7bZ33s8AvIWkwvg==
=k8r2
-----END PGP SIGNATURE-----

--ysvt4sh7xyxarrpp--