Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 1 Dec 2022 14:21:19 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     wangyufen <wangyufen@huawei.com>
Cc:     Bart Van Assche <bvanassche@acm.org>, jgg@ziepe.ca,
        leon@kernel.org, dennis.dalessandro@cornelisnetworks.com,
        linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
        bart.vanassche@wdc.com, easwar.hariharan@intel.com
Subject: Re: [PATCH v4 2/2] RDMA/srp: Fix error return code in
 srp_parse_options()
Message-ID: <Y4icP1qyB+bLK+ya@smile.fi.intel.com>
References: <1669687459-14180-1-git-send-email-wangyufen@huawei.com>
 <1669687459-14180-2-git-send-email-wangyufen@huawei.com>
 <b4d78eb0-4492-ac7f-d500-3d49b0dc7aa1@acm.org>
 <65604aae-b722-4caf-3373-d0f1e4492faa@huawei.com>
 <1d27a774-cf83-6e36-4fa1-c0635ebfd79e@acm.org>
 <0b726968-bfb8-ab9a-8d03-4d072d410597@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <0b726968-bfb8-ab9a-8d03-4d072d410597@huawei.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Thu, Dec 01, 2022 at 09:49:51AM +0800, wangyufen wrote:
> 在 2022/12/1 2:00, Bart Van Assche 写道:
> > On 11/29/22 19:31, wangyufen wrote:

...

>                 case SRP_OPT_CMD_SG_ENTRIES:
> -                       if (match_int(args, &token) || token < 1 || token >
> 255) {
> +                       ret = match_int(args, &token);
> +                       if (ret) {
> +                               pr_warn("bad max cmd_sg_entries parameter
> '%s'\n",

It's misleading message here. The problem is that parser failed by some reason.
Otherwise this variant seems good one.

> +                                       p);
> +                               goto out;
> +                       }
> +                       if (token < 1 || token > 255) {
>                                 pr_warn("bad max cmd_sg_entries parameter
> '%s'\n",
>                                         p);
> +                               ret = -EINVAL;
>                                 goto out;
>                         }
>                         target->cmd_sg_cnt = token;
>                         break;

...

> Or the following is better?

Why do you want to shadow actual error code?

-- 
With Best Regards,
Andy Shevchenko