Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp489869rwb; Thu, 1 Dec 2022 04:58:58 -0800 (PST) X-Google-Smtp-Source: AA0mqf7WwgIdYANhO543YvWXmcBGOTdnzwq/A8F6u51+AxHhMBwsQRhp8m7Zlg7zj80iUsz9Fpp8 X-Received: by 2002:a17:90a:7c43:b0:213:ecb5:c4fe with SMTP id e3-20020a17090a7c4300b00213ecb5c4femr69665673pjl.179.1669899538344; Thu, 01 Dec 2022 04:58:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669899538; cv=none; d=google.com; s=arc-20160816; b=jtU79PgqXffJc6F28yTZ115tpwuIxY9dSNMf6HZWwCru5YWKokBANfH7DKk2UlP8RJ h4/+amXZ4k9xSPkKb5eGDRqghFhbpGvNo+X7AeJkCxvmYujRq2AY5GzDoMLa65h946KE NuJt6XhMXC5p+Q8pGJJVUyFcqIYte3saLuzJ236+o7+6d6yvxHbEbZQZ0IGA1umeWnt2 9ssTE/y9Y8q7QdOX09caluM3s/aNuIchnnObsj8cY65SOSpF5ZNw3xOYusggRZ48db+E BoAuoYLp3RncAAgyN4J62bK/yburudfXF2iv2pqXOo/yYllWx+8SdfSUJuG8UxTP6D0P 0bRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=LWP8++dyzN5IlpdlH1Q7+epYIpRqCIW6YSnt7Xgc9gY=; b=liQEHbQBcYhQ/U+j9lOgpSVl5jyO7nIzYIUlMWOVs1QypRizCBR7IK0ZXnmXcDf90v h0txnYpFkf8N1IZDb1nxtv15sTa3IWJhcfMKDnGOpgcNYFvu+ODFW9t4dosWzu79WeeN yXMifsNFs3CBCpAKwwC8tGApsy2Yqqvd8ZmgaP+ynQhTl3rIUQCCQAsj/Els21Wo8uBE gqp0P5d+KCr4fChFSRqrgVkJ5qFBNfklrxEy2APwIpoWwmVLU7FSOfGPBiKdLUu6/YIy V6e9Cbf0Lmz5PMh8qTRquyjLkevsOGK9E59LOINjFBdaRmpSVqtjOatZCqDyuMey7TdL HY1Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e124-20020a636982000000b004700d8ddfc4si4153865pgc.646.2022.12.01.04.58.47; Thu, 01 Dec 2022 04:58:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231190AbiLALxb (ORCPT + 82 others); Thu, 1 Dec 2022 06:53:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231297AbiLALxO (ORCPT ); Thu, 1 Dec 2022 06:53:14 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id EB46155AA0 for ; Thu, 1 Dec 2022 03:53:12 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5EBF1D6E; Thu, 1 Dec 2022 03:53:19 -0800 (PST) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DC77B3F73D; Thu, 1 Dec 2022 03:53:10 -0800 (PST) Date: Thu, 1 Dec 2022 11:53:08 +0000 From: Sudeep Holla To: Quentin Perret Cc: Marc Zyngier , James Morse , Alexandru Elisei , Sudeep Holla , Suzuki K Poulose , Oliver Upton , Catalin Marinas , Will Deacon , Andrew Walbran , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH 02/12] firmware: arm_ffa: Move comment before the field it is documenting Message-ID: <20221201115308.gciyfttnhvz2wcuz@bogus> References: <20221116170335.2341003-1-qperret@google.com> <20221116170335.2341003-3-qperret@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221116170335.2341003-3-qperret@google.com> X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Quentin, On Wed, Nov 16, 2022 at 05:03:25PM +0000, Quentin Perret wrote: > From: Will Deacon > > This is consistent with the other comments in the struct. > Not sure how that happened :). Anyways, Reviewed-by: Sudeep Holla I am yet to look at the other patches and I would like to have a setup to test it as well. So I will look at the other patches and test it later. The reason for reviewing the first 2 patches moving the code out of the driver is to check if they can be merged for v6.2 itself. I may start pushing FF-A v1.1 changes for v6.3 and trying to avoid conflicts or cross tree dependencies. I know it is quite late for v6.2 but these changes are trivial and good to get it in for v6.2 if possible. Will, thoughts ? If you agree, please take it via arm64 for v6.2. I don't have any FF-A changes for v6.2 ATM, so there should be not conflicts. -- Regards, Sudeep