Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 1 Dec 2022 13:46:48 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     wangchuanlei <wangchuanlei@inspur.com>
Cc:     kuba@kernel.org, dev@openvswitch.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, edumazet@google.com,
        alexandr.lobakin@intel.com, pabeni@redhat.com, davem@davemloft.net
Subject: Re: [ovs-dev] [PATCH] [PATCH v6 net-next] net: openvswitch: Add
 support to count upcall packets
Message-ID: <Y4iiOBzus5v5aOIP@corigine.com>
References: <20221201084601.3598586-1-wangchuanlei@inspur.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221201084601.3598586-1-wangchuanlei@inspur.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?A8kVj6iQl10FPcB4sTbD+h/Xx6oYJFXQvD4oDr3q2XpqcF8NDpmejBjzA6EA?=
 =?us-ascii?Q?vRqNOdIVyGVeaxSkacTmjB35Q3mvMOPk52OJ88ydFgNfay2rlj7tH1NoZYpQ?=
 =?us-ascii?Q?cZp6jy7Rap6PLRrEN+zr1w9DubDN16epCH19n+KvH5mNtTeeNm7tQ9/XPz48?=
 =?us-ascii?Q?cPRJXmCIp9sys4+i0XBp0UZodbU1/d2AqfC1msWnn3Zvm4aDOO5UssQkmmZ6?=
 =?us-ascii?Q?mllOS4tsi+5Zds/Nm93jxkpxhIh7Ya3ZMFINcNIf2OAkjpvuV8NH8Nrt+P4j?=
 =?us-ascii?Q?lV3hdweQLW5lYb2JSw/am0lqHyIIEvH9Ff9YABclNR7JGkKuuorYaiLexwIA?=
 =?us-ascii?Q?ZmosjHTuFDYqYEyazXL6LXXka5cJ3hrbdR/9lW5ui1cuB9+ncbZil8DSuQ8m?=
 =?us-ascii?Q?N6ecm8HpG+er/6TjJTQS/edSBqfnAQ78hL3VOORZdQV9koS4pIfamRG+DPQc?=
 =?us-ascii?Q?jel53ASxO4pFlLgbBgPb0TkrBcgR4ZC6/SXrfByt+bbKC9i1asAIijJgF6ps?=
 =?us-ascii?Q?Cb9Uo4UDweuivMV00kKKlWqAAbcy8rtuXNUgB09CD8vyEUv44VT+cuat/RhV?=
 =?us-ascii?Q?7AhhZ1VV1ykkkTrNrxzA1+uRUixZl0UiY+OT8YfKIYyu6rBRkl2DtE7sIzxi?=
 =?us-ascii?Q?d1c7ag7uuiwHuZRgC/rbsHA4XF6g3AlJGqZSwlHnL7XYQhotHgTAvr6qabEi?=
 =?us-ascii?Q?FwoEX7e0yoCl9FM49R75VQUfWq7iynICyBUoYwKKE1SG1a5dmmgmj2xQyAYK?=
 =?us-ascii?Q?MO++XN9MjK7YjK6qDfXg22SKS+wrU3tga8Jo384NDsuAlfONyQt97UVGAUmC?=
 =?us-ascii?Q?zWjY+/Tbl17cgY44jjU6LNTNhVD9JLaWHxYGHab+cryTcjCJywVCeErpBEcl?=
 =?us-ascii?Q?XH+J6/FqozvT7P2O7AoaYqFRbpZc2Gi4raF+ZnPkukecVw5ONxWAaiNJI4xX?=
 =?us-ascii?Q?X+JB3jmZrW2PjRApPpaOoX55s+x0jDvR2dq6lTYrgAIpRBOGd+NTMVsewY/g?=
 =?us-ascii?Q?xO8BUGfFKwXBIhISCEt/YZB9mypxJtSHFknXY3QkWl7g9lxw35s9bqUWwI3d?=
 =?us-ascii?Q?3IechsvZ25+hWM6WyJ15bHBNxySTkh0R21qSbZ9kd165IgoSygCbg1ZRSrNL?=
 =?us-ascii?Q?XpJhHcYJ4LNzwbwVsQG4fN2KQSFP6GYDpficqldJl1cQEWPMy987kKiILt8D?=
 =?us-ascii?Q?9+9jf1rdFiBk5pfL15lEVxNRv4qIISeBXC90qzKmsFMRuk0UU56h239euHGd?=
 =?us-ascii?Q?68Ts5FAg0HDhr8HCfp5a1q7A5OUfPHkY3N/JiWzTGxqyqemE/7R6Xlu2PXqn?=
 =?us-ascii?Q?QJkYAK4UBKu7F2B4Ygwmo9Vw5zmtjm4PouSo1TFKmtOUAmFh8RkFSTBtCBJU?=
 =?us-ascii?Q?6DZKzBfu+AHRQFJw4GuVw8HQ0Kximt0qgU7etPcCshMub47eprauybNmp71U?=
 =?us-ascii?Q?+U3afjEMC3ljWa2DUZqu0PqiXwAmpkfYa4eRgXRGNx1p1jUkBq+NYV+0G4Cx?=
 =?us-ascii?Q?2oNv+I58JLWvgMJgs35dWTnRLq3ARlkm4TaHw6IMyR8CMT65td8YYIXZlsrb?=
 =?us-ascii?Q?zs7bFx6XV13E/XH1ofAhfyBKxCJHcO33aATCOlrpxBYpFwQkekbck5NexnhC?=
 =?us-ascii?Q?KDaHAa3p57dXy0uLxZaRj7ujgZHULfSVqlVRYUVGX9O2ZRP7pPlvdjTCqqxZ?=
 =?us-ascii?Q?V/2Liw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8eb72c82-8f5b-4bde-c149-08dad39a203c
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2022 12:46:56.3458
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5CpevlpZgKHlf+WEMBnDk3B5zcE+hvK9qdMXR3LKVvE5KX+m8+5yjAZxfe5jY5LeUOrndTq3MF9NGduCR4hkxzJp2tU75DpL6JxlNrwp6vc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR13MB4481
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On Thu, Dec 01, 2022 at 03:46:01AM -0500, wangchuanlei wrote:
> Hi, Jakub, 
> 
> 	Thank you for review, the comments below is a little confusing, can you
> give a explanation?
> 
> Best regards!
> wangchuanlei
> 
> --------------------------------------------------------
> On Wed, 30 Nov 2022 04:15:59 -0500 wangchuanlei wrote:
> > +/**
> > + *	ovs_vport_get_upcall_stats - retrieve upcall stats
> > + *
> > + * @vport: vport from which to retrieve the stats
> > + * @ovs_vport_upcall_stats: location to store stats
> 
> s/ovs_vport_upcall_//

I believe Jakub is asking for "ovs_vport_upcall_" to be removed.
Or, in other words, to refer to the parameter as "stats",
(which matches the name in the function signature below).

> 
> > + *
> > + * Retrieves upcall stats for the given device.
> > + *
> > + * Must be called with ovs_mutex or rcu_read_lock.
> > + */
> > +void ovs_vport_get_upcall_stats(struct vport *vport, struct ovs_vport_upcall_stats *stats)
> 
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>