Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp503416rwb; Thu, 1 Dec 2022 05:06:39 -0800 (PST) X-Google-Smtp-Source: AA0mqf5uLI+xf+zXVMxNiw7UXOnB5Nb1w7F66ZeaVapH8tNIw5Bn2aH9l8xBLhkh5kbOOEAnD77s X-Received: by 2002:a17:902:f68a:b0:188:dd56:1eea with SMTP id l10-20020a170902f68a00b00188dd561eeamr47696951plg.80.1669899999315; Thu, 01 Dec 2022 05:06:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669899999; cv=none; d=google.com; s=arc-20160816; b=BRId/efYFiUqw3y2vv5KYiTHvHOWvJuX4yUyiaagUQMTb0KYBaL15+tZNgaU/wvxZg 8AFfbcAyjYQB1YG0gphoBYGTUGwEBEc9JVlYuoTzmiqYWljOwBf6gSNhP5JKjOemRenM UQlvGt3EGS8ISCKUWgnGrNROJ2LRIodNTzSsxSJFYQgbZGJOWoMjAT3P1zbFKnVXr82l ThmlIqJyE7O29SYFQ2Q1HZog4J1CqiGDvWwdq9Dkoz0KU6Mt30PVqKg5CAvcV/pJAIT4 LC59lz3BprqIgH99QlBaojfEwhpIyy0Y+unQmdn7IB87IKeVrCLQmkUcr6U44O9BFxoU QwtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=phJlgjNLzib7WTpSGDvnhvf8KTYB6xxmRva4yzSEc44=; b=vbujWsMn+8OZ9sJlIlK8OC8EvuFfMt8eWycaFEUb1QBoBMZlS2zlfjxgejFv5GIdJc jP4bMQrNwQDHDv0I2X7gvGgwGwhpeh3Jq/vPmMRSwvCzYI36IXl7XGPVPehIRS7IaGoD A+85GonSBBze3s6hA2E3PO4nNrEmWpgl5XJ3s7EkylohEC18x3mGQCc6tD3OzfyiuzlS RYImJvHTaRB+I5mIrtbZwPFh/PNTjKbWTLouMCdOvZzgEj5i9ptD1AQR0D8PZbaOIpSb cup4Oukz1utGBObu9OMKYPA/V12OljktEr5+c+XcN64VvKL5wWKyEkD2hAN1cd8jAzBt 62jA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ventanamicro.com header.s=google header.b=n2e0yZdc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y17-20020a170903011100b00179c921918esi4104666plc.17.2022.12.01.05.06.24; Thu, 01 Dec 2022 05:06:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ventanamicro.com header.s=google header.b=n2e0yZdc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231522AbiLANCu (ORCPT + 83 others); Thu, 1 Dec 2022 08:02:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231450AbiLANCS (ORCPT ); Thu, 1 Dec 2022 08:02:18 -0500 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40E2D56EF7 for ; Thu, 1 Dec 2022 05:02:17 -0800 (PST) Received: by mail-pj1-x1036.google.com with SMTP id t17so1781784pjo.3 for ; Thu, 01 Dec 2022 05:02:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=phJlgjNLzib7WTpSGDvnhvf8KTYB6xxmRva4yzSEc44=; b=n2e0yZdcl14EJlhwIp2DpWjwtDctb05QLyLB95I+aBrg36W1iOn0rA6z5dPPzGtuJU jyw51261VT22Ei/HrieKaLxAnIIwX6EobH8XoIpiuP+PxuPka0HDlk9QYtuAGymdCGiQ kVQ2HGoRFUgvFFy70pGK6KyT2AeN/+uc180ndGrpzLy35CIKGKz0d8b7G25Pp6C+QsWJ dhJRTevZtGQy7CkVB7M04oeCTmscjYzV/cjv2DYU/KtsICCqZTvoOV903A5AhoDIrWNC CyC0CWQKU6qbbR0r/iV/ibY0GxB4JEWP1OsqZdTa+exRi9MY0WMOqdTy/MxteijSmaCj OH0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=phJlgjNLzib7WTpSGDvnhvf8KTYB6xxmRva4yzSEc44=; b=Rh+3pYu8RAWMxUL24qP7v7spMiBxAotIDZ1SCXOUdNEQJtWgRzvlaiRN6qowhpwdJz CYfJph5kjgYxUwEp0h10pT4ms6PG73WcTghagDfIEf8EMNGg0GnZCIvHgPLZXYee3R7C hufdHGes1EGiVq32JuvBqC6+gfhNOeTD2G+2xGeIjo2bvJ9O7eF1BRjJqkYEyQWhClxd ksgsfWraO2mOeeUlLVSHR6lC6N9Cjk+W9TdoFjFity9VpWwU45xfsupnFKvAvaA3XnkH aBemusdUQwnFE5grbQf+mOfsW4sh2ZKz+aH2/SGMQdFhwUcA4zYSMK5tFJM/Lz8EPMUG 0m8g== X-Gm-Message-State: ANoB5pkLqdNPD/rFujngjFzh9GwY3C7xcWnqxFbpJvfe23SzM7O35SpO x3K+j1ESaGes8/mjSqRNbU/3vg== X-Received: by 2002:a17:902:f243:b0:189:8046:4335 with SMTP id j3-20020a170902f24300b0018980464335mr23845589plc.152.1669899727955; Thu, 01 Dec 2022 05:02:07 -0800 (PST) Received: from anup-ubuntu-vm.localdomain ([171.76.81.69]) by smtp.gmail.com with ESMTPSA id l4-20020a17090a384400b00212c27abcaesm4855856pjf.17.2022.12.01.05.02.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Dec 2022 05:02:07 -0800 (PST) From: Anup Patel To: Palmer Dabbelt , Paul Walmsley , Thomas Gleixner , Marc Zyngier , Daniel Lezcano Cc: Atish Patra , Alistair Francis , Anup Patel , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Anup Patel , Atish Patra Subject: [PATCH v14 5/8] RISC-V: Allow marking IPIs as suitable for remote FENCEs Date: Thu, 1 Dec 2022 18:31:32 +0530 Message-Id: <20221201130135.1115380-6-apatel@ventanamicro.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221201130135.1115380-1-apatel@ventanamicro.com> References: <20221201130135.1115380-1-apatel@ventanamicro.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org To do remote FENCEs (i.e. remote TLB flushes) using IPI calls on the RISC-V kernel, we need hardware mechanism to directly inject IPI from the supervisor mode (i.e. RISC-V kernel) instead of using SBI calls. The upcoming AIA IMSIC devices allow direct IPI injection from the supervisor mode (i.e. RISC-V kernel). To support this, we extend the riscv_ipi_set_virq_range() function so that IPI provider (i.e. irqchip drivers can mark IPIs as suitable for remote FENCEs. Signed-off-by: Anup Patel Reviewed-by: Atish Patra --- arch/riscv/include/asm/smp.h | 18 ++++++++++++++++-- arch/riscv/kernel/sbi-ipi.c | 2 +- arch/riscv/kernel/smp.c | 11 ++++++++++- drivers/clocksource/timer-clint.c | 2 +- 4 files changed, 28 insertions(+), 5 deletions(-) diff --git a/arch/riscv/include/asm/smp.h b/arch/riscv/include/asm/smp.h index 79ed0b73cd4e..56976e41a21e 100644 --- a/arch/riscv/include/asm/smp.h +++ b/arch/riscv/include/asm/smp.h @@ -16,6 +16,9 @@ struct seq_file; extern unsigned long boot_cpu_hartid; #ifdef CONFIG_SMP + +#include + /* * Mapping between linux logical cpu index and hartid. */ @@ -46,7 +49,12 @@ void riscv_ipi_disable(void); bool riscv_ipi_have_virq_range(void); /* Set the IPI interrupt numbers for arch (called by irqchip drivers) */ -void riscv_ipi_set_virq_range(int virq, int nr); +void riscv_ipi_set_virq_range(int virq, int nr, bool use_for_rfence); + +/* Check if we can use IPIs for remote FENCEs */ +DECLARE_STATIC_KEY_FALSE(riscv_ipi_for_rfence); +#define riscv_use_ipi_for_rfence() \ + static_branch_unlikely(&riscv_ipi_for_rfence) /* Secondary hart entry */ asmlinkage void smp_callin(void); @@ -93,10 +101,16 @@ static inline bool riscv_ipi_have_virq_range(void) return false; } -static inline void riscv_ipi_set_virq_range(int virq, int nr) +static inline void riscv_ipi_set_virq_range(int virq, int nr, + bool use_for_rfence) { } +static inline bool riscv_use_ipi_for_rfence(void) +{ + return false; +} + #endif /* CONFIG_SMP */ #if defined(CONFIG_HOTPLUG_CPU) && (CONFIG_SMP) diff --git a/arch/riscv/kernel/sbi-ipi.c b/arch/riscv/kernel/sbi-ipi.c index 256bc1f951cd..b25116990126 100644 --- a/arch/riscv/kernel/sbi-ipi.c +++ b/arch/riscv/kernel/sbi-ipi.c @@ -72,6 +72,6 @@ void __init sbi_ipi_init(void) "irqchip/sbi-ipi:starting", sbi_ipi_starting_cpu, sbi_ipi_dying_cpu); - riscv_ipi_set_virq_range(virq, BITS_PER_BYTE); + riscv_ipi_set_virq_range(virq, BITS_PER_BYTE, false); pr_info("providing IPIs using SBI IPI extension\n"); } diff --git a/arch/riscv/kernel/smp.c b/arch/riscv/kernel/smp.c index e8a20454d65b..74b8cb1a89ab 100644 --- a/arch/riscv/kernel/smp.c +++ b/arch/riscv/kernel/smp.c @@ -145,7 +145,10 @@ bool riscv_ipi_have_virq_range(void) return (ipi_virq_base) ? true : false; } -void riscv_ipi_set_virq_range(int virq, int nr) +DEFINE_STATIC_KEY_FALSE(riscv_ipi_for_rfence); +EXPORT_SYMBOL_GPL(riscv_ipi_for_rfence); + +void riscv_ipi_set_virq_range(int virq, int nr, bool use_for_rfence) { int i, err; @@ -168,6 +171,12 @@ void riscv_ipi_set_virq_range(int virq, int nr) /* Enabled IPIs for boot CPU immediately */ riscv_ipi_enable(); + + /* Update RFENCE static key */ + if (use_for_rfence) + static_branch_enable(&riscv_ipi_for_rfence); + else + static_branch_disable(&riscv_ipi_for_rfence); } EXPORT_SYMBOL_GPL(riscv_ipi_set_virq_range); diff --git a/drivers/clocksource/timer-clint.c b/drivers/clocksource/timer-clint.c index ab7a7b1d535b..455e634055e7 100644 --- a/drivers/clocksource/timer-clint.c +++ b/drivers/clocksource/timer-clint.c @@ -247,7 +247,7 @@ static int __init clint_timer_init_dt(struct device_node *np) } irq_set_chained_handler(clint_ipi_irq, clint_ipi_interrupt); - riscv_ipi_set_virq_range(rc, BITS_PER_BYTE); + riscv_ipi_set_virq_range(rc, BITS_PER_BYTE, true); clint_clear_ipi(); #endif -- 2.34.1