Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp585361rwb; Thu, 1 Dec 2022 06:06:23 -0800 (PST) X-Google-Smtp-Source: AA0mqf4smUTl1q0Zhxt5TWkbDPVnRs61AHZjLL5KqmtlecJFQ3x4Kv6yzvlpAE6/W4HYaLX/9sIo X-Received: by 2002:a63:1747:0:b0:478:1391:fd14 with SMTP id 7-20020a631747000000b004781391fd14mr19121610pgx.112.1669903582915; Thu, 01 Dec 2022 06:06:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669903582; cv=none; d=google.com; s=arc-20160816; b=BTptuoWCDu4uqL7Vm8ZkFOofecr/WHK9b+1RILI1mMfJ/8IKnEOT5wFtuCAtmIZ/Tz x8eo3rCpTNRYqA6Q9l+i3Fx5SOphnJny6slG4t290Sv6/e0OYg5fA6SfzXy7VUSQzOZY dfNaIoqdEgqIYk/hmCNhvZG07G9o7WfF2gYY+BCpsgfjajzQwpostkj4/g7rwpiyrt3X eIWnevPDCQHpW16gGMM+is3e5FRZCoiBfjTdWobUWpNv1NZ4yl3kYcGAWYM+PyvJr8UM b1fufFobmhnDOFTOYuMPgWW6+jxkAss3G6uD/qjBTKDoAgvLMsd6XXvyI2W16jsK7FkS PiiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=lypgQCSJjPaqSVzgleWjyhDpf4hoKuzLN8HOLWwDAuI=; b=bCnTLVqUf/6paL9kTuForKQNIwqxDVTQzHXiHM23zE418h8FSs3pPKI9uj2chrw4O5 8xFPWA0CWZNRvSI7Be9NkOhyS1IHgDkP7LgBX1B+1KbGC1sZqSSLE2e1THbxp/H62mni dRJYAfFjCW6KmAc9l3mKB7jVU3KfRSHEAxNwhHv3NrPShNYypZl+mLTOmoFBx9n+jiqd Fhbpp87/Awii+eu/OMfDvOJY0noJitXqTAun3GVPWa9KSoij9jEBffc0KeFKNVTRSXRm Gk3JVvkYQNw0H8A03xVS1c2ERHvjODauLNSir6DyRbFX5kTsZDmTrRfQIsry1Unbi9hN c9Sg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f2-20020a63f102000000b00477abe15f06si4440964pgi.63.2022.12.01.06.05.53; Thu, 01 Dec 2022 06:06:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231555AbiLANeN (ORCPT + 83 others); Thu, 1 Dec 2022 08:34:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231524AbiLANeJ (ORCPT ); Thu, 1 Dec 2022 08:34:09 -0500 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8F8FCAC1A2; Thu, 1 Dec 2022 05:34:08 -0800 (PST) Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1p0jhW-000077-01; Thu, 01 Dec 2022 14:34:06 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id CA780C1FB9; Thu, 1 Dec 2022 14:33:18 +0100 (CET) Date: Thu, 1 Dec 2022 14:33:18 +0100 From: Thomas Bogendoerfer To: John Thomson Cc: Sergio Paracuellos , John Crispin , =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] mips: ralink: mt7621: soc queries and tests as functions Message-ID: <20221201133318.GB10560@alpha.franken.de> References: <20221114015658.2873120-1-git@johnthomson.fastmail.com.au> <20221114015658.2873120-3-git@johnthomson.fastmail.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221114015658.2873120-3-git@johnthomson.fastmail.com.au> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 14, 2022 at 11:56:57AM +1000, John Thomson wrote: > Move the SoC register value queries and tests to specific functions, > to remove repetition of logic > No functional changes intended > > Signed-off-by: John Thomson > --- > arch/mips/ralink/mt7621.c | 86 +++++++++++++++++++++++++++------------ > 1 file changed, 61 insertions(+), 25 deletions(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]