Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp590489rwb; Thu, 1 Dec 2022 06:09:17 -0800 (PST) X-Google-Smtp-Source: AA0mqf4NAwr+o/lDCg1BATkJSUgZZkgtO50yHv2c4GCd2A2hPd1OMy6+ufMoh5yPsm6opuOE7IaQ X-Received: by 2002:a17:902:cf03:b0:186:5d7e:7ca8 with SMTP id i3-20020a170902cf0300b001865d7e7ca8mr47173782plg.74.1669903757240; Thu, 01 Dec 2022 06:09:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669903757; cv=none; d=google.com; s=arc-20160816; b=es4+3IkYeXf3SQ5iwWI3oSwBKSab7kSXGgqJRamA0kZ5w+ZLyRciiCuqzOzaUk5WTQ MP7TUWqw+JrZpXS1R5sqmf4Umlr1m6mgWjOlPo14P3VFNBi98ur1q9Ox5mWuucveOPi7 /jPg4sqh/8SSiqqTTsUN48GERDQirbxnHI+gGLh4U1Iux3CXBC1MmAnrRbEQeXa6uSE6 RIFDSRSmCojsPH1eqhZzoNvs2Sbrdu6pGaHhBVosZg2rH4x2zp6eGs6Ru+TLEO9CeOA/ y+ton0/kfdi++mUJiQOzPRpPd4HS87Ov8RFKtubVtmMlxlu+cJaGnfm94ew6t6DrUol3 kKzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=iGN3VL/XFnVBkPaM7c0HjkkPxAlIY56C6pEqxkaLsVI=; b=N38cHEojNBtUeqCVUxV6K7wPal1roAhr+n7jIM7znw0OHja3y62tuTX7R6LYqriDOv KiMPZ8Wsb3OKThNZG2XxcaegNPxVqYhu39cPMBLEtnag1WopPjnePa7BS7oAzav/AJCW O3jImNMAmwYyHm7D/c+mQl7WwCCSVfJt83BOgD+IdUJaugmn0YxXW/iJqpL4S04AH3OD C77uPGgVePbN2CQlAOCa4cSHDO03Xp7UD//GEuuR/reJrQl/KOymYw1fizxp5IlDA4TG ldNbf12sxRy+lFMYWG84jfPTgHA4e40lGyFAeOd+WD7SFnfRcsukyL7wCJp07LxgHOwi ZxFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ventanamicro.com header.s=google header.b=JRWrAp8p; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g15-20020a056a000b8f00b0056e3c566bfasi4848775pfj.201.2022.12.01.06.09.02; Thu, 01 Dec 2022 06:09:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ventanamicro.com header.s=google header.b=JRWrAp8p; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230337AbiLANB7 (ORCPT + 82 others); Thu, 1 Dec 2022 08:01:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231163AbiLANBr (ORCPT ); Thu, 1 Dec 2022 08:01:47 -0500 Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 340A5BF925 for ; Thu, 1 Dec 2022 05:01:46 -0800 (PST) Received: by mail-pg1-x533.google.com with SMTP id 136so1624223pga.1 for ; Thu, 01 Dec 2022 05:01:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=iGN3VL/XFnVBkPaM7c0HjkkPxAlIY56C6pEqxkaLsVI=; b=JRWrAp8pv7B0SuPanT2S5U0Gl2lpwtK8NYFWWI7a2f+xm7t/Ok8i2BuXx0BL/3SFHw Sa4HhlcaSlfsS6JUwKLvXFM22sLEyh65+AwvsN5MzbW10y+nCvw6ZAuv/Mn25r9z5iEH hkZCB80ZaREHd9Kb15AqDb6YFW7sE5cK+dsTUjpW5nLXUxDX0BTorPv9XywKu8JI1CAY zA3ue2VcJbkkitZpeKwFbLyjPXzzRaDyhSZ3wp+Xzfr1oR1R0fwvSkhLign7M2qxVaFq tsr1k1C4ErhZ/SDdyi5Jb/2+LSZBcMxWGf6IKIiZayjwBqIaPQeKH5KeQkstRU/xlIrE GwOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=iGN3VL/XFnVBkPaM7c0HjkkPxAlIY56C6pEqxkaLsVI=; b=st0CRirqoSYbDdUIHMuc+pHA/Gb35DVuq5nPfzQ2gSX15seRZdghl4SQc96MBt2kok HlFP1M/XV7FSvLSpcY3ollMxfyOk7zGeENtKl4cGX7TddTzFP/qQ34sBv/9Xqr026E+v pVHnYEIhlcp7OMyJfoEwsrjbM2xZuh9FAfTW1RNqpw5szeETEJcGmN9ellCX/tL0QLL7 aFBcUBQQHyMG5tL4YxvhBm8cx/vTOw8iAJEP8wh0qY9q2nvsIH5oA8jmcxAkLCnCeI0a K5pFQARdc5qnnL+PSQJ5KwZbtXO97c6BNgAyQXzE8luZlNCT1cTODeSSIJcEQ19ysLYG ABmg== X-Gm-Message-State: ANoB5pl3U8P1jI9HjOf/9sEwHbWYLxBX7/Ceq684pY2T3/P5Y/nFz/9G wQyQ0ubsWucPr3tuhiheXmKOCQ== X-Received: by 2002:a63:d751:0:b0:46f:f87c:fb1a with SMTP id w17-20020a63d751000000b0046ff87cfb1amr43453753pgi.214.1669899705201; Thu, 01 Dec 2022 05:01:45 -0800 (PST) Received: from anup-ubuntu-vm.localdomain ([171.76.81.69]) by smtp.gmail.com with ESMTPSA id l4-20020a17090a384400b00212c27abcaesm4855856pjf.17.2022.12.01.05.01.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Dec 2022 05:01:44 -0800 (PST) From: Anup Patel To: Palmer Dabbelt , Paul Walmsley , Thomas Gleixner , Marc Zyngier , Daniel Lezcano Cc: Atish Patra , Alistair Francis , Anup Patel , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Anup Patel Subject: [PATCH v14 0/8] RISC-V IPI Improvements Date: Thu, 1 Dec 2022 18:31:27 +0530 Message-Id: <20221201130135.1115380-1-apatel@ventanamicro.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This series aims to improve IPI support in Linux RISC-V in following ways: 1) Treat IPIs as normal per-CPU interrupts instead of having custom RISC-V specific hooks. This also makes Linux RISC-V IPI support aligned with other architectures. 2) Remote TLB flushes and icache flushes should prefer local IPIs instead of SBI calls whenever we have specialized hardware (such as RISC-V AIA IMSIC and RISC-V SWI) which allows S-mode software to directly inject IPIs without any assistance from M-mode runtime firmware. These patches were originally part of the "Linux RISC-V ACLINT Support" series but this now a separate series so that it can be merged independently of the "Linux RISC-V ACLINT Support" series. (Refer, https://lore.kernel.org/lkml/20211007123632.697666-1-anup.patel@wdc.com/) These patches are also a preparatory patches for the up-coming: 1) Linux RISC-V AIA support 2) Linux RISC-V SWI support These patches can also be found in riscv_ipi_imp_v14 branch at: https://github.com/avpatel/linux.git Changes since v13: - Included changes suggested by Marc Z in PATCH3 - Use chained handlers in PATCH4 - Added new PATCH8 to have empty irq_eoi() in RISC-V INTC driver. This avoids the unnecessary mask/unmask dance at time of handling interrupts. Changes since v12: - Rebased on Linux-6.1-rc7 - Bring-back the IPI optimization in ipi_mux_send_mask() for PATCH3 - Call ipi_mux_send() for one target CPU at a time in PATCH3 Changes since v11: - Removed ipi_mux_pre/post_handle() callbacks in PATCH3 - Removed sturct ipi_mux_ops in PATCH3 - Removed parent_virq and data pointer from everywhere in PATCH3 - Removed struct ipi_mux_control in PATCH3 - Improved function signature of ipi_mux_send() callback in PATCH3 - Used unsigned type with atomic operation in PATCH3 Changes since v10: - Rebased on Linux-6.1-rc5 - Drop the "!(pending & ibit)" check in ipi_mux_send_mask() of PATCH3 - Disable local interrupts in ipi_mux_send_mask() of PATCH3 because we can be preempted while using a per-CPU temporary variable. Changes since v9: - Rebased on Linux-6.1-rc3 - Updated header comment block of ipi-mux.c in PATCH3 - Use a struct for global data of ipi-mux.c in PATCH3 - Add per-CPU temp cpumask for sending IPIs in PATCH3 - Drop the use of fwspec in PATCH3 - Use static key for ipi_mux_pre_handle() and ipi_mux_post_handle() in PATCH3 - Remove redundant pr_warn_ratelimited() called by ipi_mux_process() in PATCH3 - Remove CPUHP thingy from ipi_mux_create() in PATCH3 Changes since v8: - Rebased on Linux-6.0-rc3 - Use dummy percpu data as parameter for request_percpu_irq() in PATCH4. Changes since v7: - Rebased on Linux-6.0-rc1 - Use atomic operations to track per-CPU pending and enabled IPIs in PATCH3. (Note: this is inspired from IPI muxing implemented in drivers/irqchip/irq-apple-aic.c) - Made "struct ipi_mux_ops" (added by PATCH3) flexible so that drivers/irqchip/irq-apple-aic.c can adopt it in future. Changes since v6: - Rebased on Linux-5.19-rc7 - Added documentation for struct ipi_mux_ops in PATCH3 - Dropped dummy irq_mask()/unmask() in PATCH3 - Added const for "ipi_mux_chip" in PATCH3 - Removed "type" initialization from ipi_mux_domain_alloc() in PATCH3 - Dropped translate() from "ipi_mux_domain_ops" in PATCH3 - Improved barrier documentation in ipi_mux_process() of PATCH3 - Added percpu check in ipi_mux_create() for parent_virq of PATCH3 - Added nr_ipi parameter in ipi_mux_create() of PATCH3 Changes since v5: - Rebased on Linux-5.18-rc3 - Used kernel doc style in PATCH3 - Removed redundant loop in ipi_mux_process() of PATCH3 - Removed "RISC-V" prefix form ipi_mux_chip.name of PATCH3 - Removed use of "this patch" in PATCH3 commit description - Addressed few other nit comments in PATCH3 Changes since v4: - Rebased on Linux-5.17 - Includes new PATCH3 which adds mechanism to multiplex a single HW IPI Changes since v3: - Rebased on Linux-5.17-rc6 - Updated PATCH2 to not export riscv_set_intc_hwnode_fn() - Simplified riscv_intc_hwnode() in PATCH2 Changes since v2: - Rebased on Linux-5.17-rc4 - Updated PATCH2 to not create synthetic INTC fwnode and instead provide a function which allows drivers to directly discover INTC fwnode Changes since v1: - Use synthetic fwnode for INTC instead of irq_set_default_host() in PATCH2 Anup Patel (8): RISC-V: Clear SIP bit only when using SBI IPI operations irqchip/riscv-intc: Allow drivers to directly discover INTC hwnode genirq: Add mechanism to multiplex a single HW IPI RISC-V: Treat IPIs as normal Linux IRQs RISC-V: Allow marking IPIs as suitable for remote FENCEs RISC-V: Use IPIs for remote TLB flush when possible RISC-V: Use IPIs for remote icache flush when possible irqchip/riscv-intc: Add empty irq_eoi() for chained irq handlers arch/riscv/Kconfig | 2 + arch/riscv/include/asm/irq.h | 4 + arch/riscv/include/asm/sbi.h | 10 +- arch/riscv/include/asm/smp.h | 49 +++++--- arch/riscv/kernel/Makefile | 1 + arch/riscv/kernel/cpu-hotplug.c | 3 +- arch/riscv/kernel/irq.c | 21 +++- arch/riscv/kernel/sbi-ipi.c | 77 ++++++++++++ arch/riscv/kernel/sbi.c | 100 +++------------ arch/riscv/kernel/smp.c | 166 +++++++++++++------------ arch/riscv/kernel/smpboot.c | 5 +- arch/riscv/mm/cacheflush.c | 5 +- arch/riscv/mm/tlbflush.c | 93 +++++++++++--- drivers/clocksource/timer-clint.c | 61 ++++++--- drivers/irqchip/Kconfig | 1 + drivers/irqchip/irq-riscv-intc.c | 71 +++++++---- include/linux/irq.h | 3 + kernel/irq/Kconfig | 5 + kernel/irq/Makefile | 1 + kernel/irq/ipi-mux.c | 199 ++++++++++++++++++++++++++++++ 20 files changed, 633 insertions(+), 244 deletions(-) create mode 100644 arch/riscv/kernel/sbi-ipi.c create mode 100644 kernel/irq/ipi-mux.c -- 2.34.1