Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Frank Li <Frank.Li@nxp.com>
To:     haibo.chen@nxp.com
Cc:     cai.huoqing@linux.dev, festevam@gmail.com, frank.li@nxp.com,
        imx@lists.linux.dev, jic23@kernel.org, kernel@pengutronix.de,
        lars@metafoo.de, linux-arm-kernel@lists.infradead.org,
        linux-iio@vger.kernel.org, linux-imx@nxp.com,
        linux-kernel@vger.kernel.org, s.hauer@pengutronix.de,
        shawnguo@kernel.org
Subject: [PATCH v2 1/1] iio: imx8qxp-adc: fix irq flood when call imx8qxp_adc_read_raw()
Date:   Thu,  1 Dec 2022 09:01:10 -0500
Message-Id: <20221201140110.2653501-1-Frank.Li@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?C5Zb/HKmTgHAJF8SC1ZrhJ8XYrwGV3avIKdV7CcrjY8eR0Z349ww7L84//5B?=
 =?us-ascii?Q?rN9HJqszTd79BquYmerxjHcaOIo8eAxcdppQMsmh6z0LFeJuBEw4Mkb0D0JA?=
 =?us-ascii?Q?++3pijwO08DE4vGIedf2J2wE6r+advzKQAPdR5hgoWYctYr1Bc4vwIfHqJ/y?=
 =?us-ascii?Q?C9+yoqg7MwnxQJXn1srLADga9HqXT6tBuSyyH0q0LppLi2cCaVAu2UEomrDN?=
 =?us-ascii?Q?pjhOgbwI48Zic3oFOGtmZZ9eU2hii+WttbAnasMMdAaEzqzGl7LCBKKpsLYo?=
 =?us-ascii?Q?uvtseKHFrCRUL3QSI7+ZdcBzf53Z+nSfkoIKHZFIqYeaGz0WEE/10Nrp+Krt?=
 =?us-ascii?Q?yTxj8W0QeVkvd+9NihgXpfSE+8dJTD5D0JbAOHAOcBpDqBxS2b2gsjuVQNjE?=
 =?us-ascii?Q?Cd+ZgM71SwTBDEbwSPJfccudMS1f2Ld5StLn/YjBLvP1oEiqBsMVhBhetE3C?=
 =?us-ascii?Q?bvVxwKMYBmn3hZsTHqTFhk6AEk2rLZeTsh46cQZesMCViiPFbRkS1HzIlKXs?=
 =?us-ascii?Q?Yr1z+2ujM27Nm/WRsh0Qg/78nIRy4QikuRPJFDuxl1YztgZM9RmQ2DDuEUNH?=
 =?us-ascii?Q?NXqbFDtz3bC1bOaYj1n2p/W+jRcebuu0j+xrBhR1QL6mzGOE6JZe6jNXYxbc?=
 =?us-ascii?Q?89uC1mvno4fxtCUc7quyrzwSbZ7KjmmsimUb9XXFyDaD/XQZ2dxnujL3dhBh?=
 =?us-ascii?Q?VEhXaXauMF+bocnfPNntUyXnIlTuabM0f2kX1mlisyV4j+H0HLiV1zEY5fJv?=
 =?us-ascii?Q?e+7RcWKGESY6LDg1AVZrHilE+8VUkcCtW3QawGQcF8octmhfMpO7whZAFWx+?=
 =?us-ascii?Q?nC0OJ0SgDwzWUK4DvJExfEHW6w4V3u52WhY/8/biBh9e5PvrLW61u4US2n4G?=
 =?us-ascii?Q?ehs8eR7AD7T/b26eFWbyXABw/pGlxMoAXRRk+w7xKd7sTYjlI4Fq2T1eqqFL?=
 =?us-ascii?Q?InPb06ajDuEGMufaymF3j5OQYejauEimKKJ71KbEI0wR+cpCB/KuNaxfg4N2?=
 =?us-ascii?Q?0L75IDDbcieAik2OeSg5VEFIOKvVFSQCbUvUMk0ElUrCiUwZ/sCOBEFGWOlG?=
 =?us-ascii?Q?hTv33Uc3b7lAT02kWk1ZVGHuV38YkaJ8bDpxCIporZl2LyxXu2Mej3XXmGoj?=
 =?us-ascii?Q?sbktVGdzXPKQJ5Tc+g6vpy+FZNQZDoBzoDnr/pQwQw34hd2eKwNACbgMUnZi?=
 =?us-ascii?Q?Mz5pEyI6PLrUfUwHwucWF7c7VD17Mp4ARw5dpcYFd4PXNhI3S/uyYc1DpFme?=
 =?us-ascii?Q?ZuEWb4XW92nD43NmBwbnKqg3cykm3sT2aShzTNX09+edRU+ojoLACJRDdk8V?=
 =?us-ascii?Q?VpNOSgZTZuex1//rO22k3J8c1xvzfz4hcWgSc+jI1o1lYWPbCQ+s5lP4Xzed?=
 =?us-ascii?Q?KUF5ZeaFhHCoKGvNcKEVXS7Y3XEIKrzuH8+I/cv3ubkvmrWU+zztlQfe9rc7?=
 =?us-ascii?Q?9rMxML2JudrSU3pNYN9gBfwjY/LlhxXuKTy5Voh2qnGc4Idfax79eZInd0A2?=
 =?us-ascii?Q?+DIcVycy89Y7hu/ZQo4JSh71t52Sa+G//sHWRKtz9nHnQAQwezEQTfja2kV3?=
 =?us-ascii?Q?4uG+Z5aOyGZtsgLnUsM=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c562ef1a-c6e9-42ed-8452-08dad3a48b55
X-MS-Exchange-CrossTenant-AuthSource: HE1PR0401MB2331.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2022 14:01:45.2692
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: n6Bk//TSb2lKqojNKQ+EZ0uqjgV1FTzpnIEcB9pGagMaMhefZo3z6ilU4yXgsxRu41WWboUuFNMfZgnMOM1KeQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7792
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

irq flood happen when run
    cat /sys/bus/iio/devices/iio:device0/in_voltage1_raw

imx8qxp_adc_read_raw()
{
	...
	enable irq
	/* adc start */
	writel(1, adc->regs + IMX8QXP_ADR_ADC_SWTRIG);
	^^^^ trigger irq flood.
	wait_for_completion_interruptible_timeout();
	readl(adc->regs + IMX8QXP_ADR_ADC_RESFIFO);
	^^^^ clear irq here.
	...
}

There is only FIFO watermark interrupt at this ADC controller.
IRQ line will be assert until software read data from FIFO.
So IRQ flood happen during wait_for_completion_interruptible_timeout().

Move FIFO read into irq handle to avoid irq flood.

Fixes: 1e23dcaa1a9f ("iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC")
Cc: stable@vger.kernel.org

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Change from v1 to v2
 - move complete() after read fifo


 drivers/iio/adc/imx8qxp-adc.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/adc/imx8qxp-adc.c b/drivers/iio/adc/imx8qxp-adc.c
index 36777b827165..f5a0fc9e64c5 100644
--- a/drivers/iio/adc/imx8qxp-adc.c
+++ b/drivers/iio/adc/imx8qxp-adc.c
@@ -86,6 +86,8 @@
 
 #define IMX8QXP_ADC_TIMEOUT		msecs_to_jiffies(100)
 
+#define IMX8QXP_ADC_MAX_FIFO_SIZE		16
+
 struct imx8qxp_adc {
 	struct device *dev;
 	void __iomem *regs;
@@ -95,6 +97,7 @@ struct imx8qxp_adc {
 	/* Serialise ADC channel reads */
 	struct mutex lock;
 	struct completion completion;
+	u32 fifo[IMX8QXP_ADC_MAX_FIFO_SIZE];
 };
 
 #define IMX8QXP_ADC_CHAN(_idx) {				\
@@ -238,8 +241,7 @@ static int imx8qxp_adc_read_raw(struct iio_dev *indio_dev,
 			return ret;
 		}
 
-		*val = FIELD_GET(IMX8QXP_ADC_RESFIFO_VAL_MASK,
-				 readl(adc->regs + IMX8QXP_ADR_ADC_RESFIFO));
+		*val = adc->fifo[0];
 
 		mutex_unlock(&adc->lock);
 		return IIO_VAL_INT;
@@ -265,10 +267,15 @@ static irqreturn_t imx8qxp_adc_isr(int irq, void *dev_id)
 {
 	struct imx8qxp_adc *adc = dev_id;
 	u32 fifo_count;
+	int i;
 
 	fifo_count = FIELD_GET(IMX8QXP_ADC_FCTRL_FCOUNT_MASK,
 			       readl(adc->regs + IMX8QXP_ADR_ADC_FCTRL));
 
+	for (i = 0; i < fifo_count; i++)
+		adc->fifo[i] = FIELD_GET(IMX8QXP_ADC_RESFIFO_VAL_MASK,
+				readl_relaxed(adc->regs + IMX8QXP_ADR_ADC_RESFIFO));
+
 	if (fifo_count)
 		complete(&adc->completion);
 
-- 
2.34.1