Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 1 Dec 2022 19:06:37 +0530
From:   Pavan Kondeti <quic_pkondeti@quicinc.com>
To:     David Hildenbrand <david@redhat.com>
CC:     Pavankumar Kondeti <quic_pkondeti@quicinc.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
        Suren Baghdasaryan <surenb@google.com>,
        Minchan Kim <minchan@kernel.org>,
        Charan Teja Kalla <quic_charante@quicinc.com>,
        Prakash Gupta <quic_guptap@quicinc.com>,
        Divyanand Rangu <quic_drangu@quicinc.com>
Subject: Re: [PATCH] mm/madvise: fix madvise_pageout for private file mappings
Message-ID: <20221201133637.GC3980@hu-pkondeti-hyd.qualcomm.com>
References: <1667971116-12900-1-git-send-email-quic_pkondeti@quicinc.com>
 <906b0150-ef7c-d2b9-783f-4e94c48fa367@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <906b0150-ef7c-d2b9-783f-4e94c48fa367@redhat.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk

Hi David,

Thanks for your review.

On Thu, Dec 01, 2022 at 02:01:22PM +0100, David Hildenbrand wrote:
> >+	 * If the VMA belongs to a private file mapping, there can be private
> >+	 * dirty pages which can be paged out if even this process is neither
> >+	 * owner nor write capable of the file. Cache the file access check
> >+	 * here and use it later during page walk.
> >+	 */
> >+	can_pageout_file = can_do_file_pageout(vma);
> 
> Why not move that into madvise_pageout_page_range() ? Avoids passing this
> variable to that function.
> 
Silly me. I should have done that in the first place.

> In fact, why not even call that function directly instead of storing that in
> madvise_walk_private(). The function is extremely lightweight.

Agreed. I will incorporate your suggestion and send the patch after testing.

> 
> >  	lru_add_drain();
> >  	tlb_gather_mmu(&tlb, mm);
> >-	madvise_pageout_page_range(&tlb, vma, start_addr, end_addr);
> >+	madvise_pageout_page_range(&tlb, vma, start_addr, end_addr, can_pageout_file);
> >  	tlb_finish_mmu(&tlb);
> >  	return 0;
> 
Thanks,
Pavan