Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vishnu Dasa <vdasa@vmware.com>
To:     Stefano Garzarella <sgarzare@redhat.com>,
        Arseniy Krasnov <AVKrasnov@sberdevices.ru>
CC:     Bryan Tan <bryantan@vmware.com>,
        "David S. Miller" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "kys@microsoft.com" <kys@microsoft.com>,
        "haiyangz@microsoft.com" <haiyangz@microsoft.com>,
        "wei.liu@kernel.org" <wei.liu@kernel.org>,
        Dexuan Cui <decui@microsoft.com>,
        Krasnov Arseniy <oxffffaa@gmail.com>,
        Bobby Eshleman <bobby.eshleman@gmail.com>,
        Bobby Eshleman <bobby.eshleman@bytedance.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "virtualization@lists.linux-foundation.org" 
        <virtualization@lists.linux-foundation.org>,
        "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
        kernel <kernel@sberdevices.ru>
Subject: Re: [RFC PATCH v2 3/6] vsock/vmci: always return ENOMEM in case of
 error
Thread-Topic: [RFC PATCH v2 3/6] vsock/vmci: always return ENOMEM in case of
 error
Thread-Index: AQHZAPCA3ICEgU4zakSbW2G8CFeTF65YzU8AgABf+oA=
Date:   Thu, 1 Dec 2022 15:14:20 +0000
Message-ID: <D7DE3103-994D-478E-B7F6-42CE8B6469FE@vmware.com>
References: <9d96f6c6-1d4f-8197-b3bc-8957124c8933@sberdevices.ru>
 <675b1f93-dc07-0a70-0622-c3fc6236c8bb@sberdevices.ru>
 <20221201093048.q2pradrgn5limcfb@sgarzare-redhat>
In-Reply-To: <20221201093048.q2pradrgn5limcfb@sgarzare-redhat>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kmzg7aH3v+uXxmxm1snhpNnQ9NvvAPbIt92gy1rml+NCryzpJURV4tTYqb0J?=
 =?us-ascii?Q?Lb9hKpNRD2NDnNGxbDPXPQExBym4eGietJ7vcbTkMeH7V7IhdOBKYSoIZku4?=
 =?us-ascii?Q?Pz5r44cIO3OmfOrFNI2pflarEMoo2tDQQKzw7tC6DhJA/mjPKR6QY4YEzE0b?=
 =?us-ascii?Q?W18RfFvyemNGrtLohouO3LiftkvZPNGr7ywrbUpYR36jRLfRUQRSjWk+A20u?=
 =?us-ascii?Q?wRIHvryLsf8Rs8pAaCRoGg8Kc6H6lATjWmZ5S8D1UY1FZGzPgkJyj5AAu0nX?=
 =?us-ascii?Q?elUueal153dh0gRW4WL3/uUKpvdTwX6nt9ozjLX2RV4Db0RNDK1s0kCMUyvs?=
 =?us-ascii?Q?ydVreZcBsrkEBxmVORd51sThr1Ka+2ofRjEScOP1lk/8MDb9PY9XzPYzDD18?=
 =?us-ascii?Q?gjBwVNAzOMANFWhZXV4FWvP6f4cqcD+8kJBhi5ahV1fTnXhTC4/SN7noLQ+i?=
 =?us-ascii?Q?nyZfHIBlMvnCDdDpYP5Mpd1kKbJzblK2xXsVJRPRrss+2bFHb9o1edfCJW4e?=
 =?us-ascii?Q?RA2kAgE5T5WklK36IMSdltmQP7e/Ef3byTIQxQctzHc3yDXk++BSvS8giZTX?=
 =?us-ascii?Q?uONXrhKt1g3mfZOMSVLUnSVzMQq4KGDk5vi0hlulJzUmd613ltzFcHFqNi5e?=
 =?us-ascii?Q?An4YdfIP4/V4yWsQiwAFS2f8kM57XHAgW3QkImKbXuoZ1ndC2vR2z5J8icRm?=
 =?us-ascii?Q?CdgA0fpoTIoWT7J4qWnXvCZmcocCqjIvrX+QMw2eWRf9nPYQSK/4QjVwhvx1?=
 =?us-ascii?Q?gv0jgMxehQIwYEjvqElCs9XmguEpCvKFWE7NeiagVCEXoaxZVnF/MFaOVMIO?=
 =?us-ascii?Q?9l1fM498ApmsnmXvpeqLMdowt9SYwF9YHmqsirq+ySghNShbX1UVmMms14Gj?=
 =?us-ascii?Q?vaMMj4TlsoPDqNzzJQmZ7bEEdzxy/delv85MYuBnp2dP3e9/K6Cb+EA+Qxa6?=
 =?us-ascii?Q?4DTfiR1XwdSfe+9Ybxz6AE7WD+BELfPxwKlgLptBkskFSGnYCVmcKQje5N4V?=
 =?us-ascii?Q?D66QBg3g8cwhYb9PWM+Oa0M81hP1heud0FhS5LRJcTNGXl4QOf19smoY2h6R?=
 =?us-ascii?Q?jPX6zyAhc5xIJd8cMajZH3dYLwkH/DItWLFWS2w2ZyoeB88iDg8zvbm6GUbD?=
 =?us-ascii?Q?E5PTEAHS9hil81ux9Zr8ESzdio5DhiVS7di1c5L93kfm43T1o/V3hIJA76Hd?=
 =?us-ascii?Q?3odfn7fWNAZKoAwqUziOhp3nTcQWrVEVd/LG6Pjo32c52rMU0GTW18Omirpw?=
 =?us-ascii?Q?xaF6Db1MyRvTG9VyAtX2aueqd0iyIJl9QzFNwIeP4LrSg1l+XKTIDUMiUgpo?=
 =?us-ascii?Q?06RpwY+rKgKt7m28I58Yh/NC2+XLqJ7oAGt+2rwD6FOMCvFytGEPbjljgLHq?=
 =?us-ascii?Q?0b6aHoh4dYwUAiwerUgFTCwHtfCLZeNgfaQRAmWSSO4Z8OK00UEcX+NQlzeS?=
 =?us-ascii?Q?C6IEmg7w+QP9MAdiez5oz4idlCONdQYhMzJiK+pektbbLN+fxuh93rPEQckA?=
 =?us-ascii?Q?bVi0bUA1aVxq7UbbNEEmK/qibBMBWreD6PQgjBuXvjGQ4n3WfIfPwYrc1bMK?=
 =?us-ascii?Q?Mmj+cJN3G/lBlkeVAGCcaPhpCF4iYngl6jSMK9zBbCCu++Y5DijZKLeT0gcQ?=
 =?us-ascii?Q?tqKyirTJSYQiQBczsC3LTwZHxoTJKirfee3uipTc90QO?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <A0D536CE63F6D9428AFA7750B19E3B41@namprd05.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: vmware.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR05MB3960.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5cbd9221-e625-4f23-8e0f-08dad3aeb8b1
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Dec 2022 15:14:20.2448
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: NgmDZiIZgcJyPgSlM4g6aCDdJIBVxKN3SM5VTgBCWZwtQIr4f6lgt76g51H71BhWYR5kRJQ535boMBzJWKcjGQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR05MB2473
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_NONE autolearn=no
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Dec 1, 2022, at 1:30 AM, Stefano Garzarella <sgarzare@redhat.com> wrot=
e:
>=20
> !! External Email
>=20
> On Fri, Nov 25, 2022 at 05:08:06PM +0000, Arseniy Krasnov wrote:
>> From: Bobby Eshleman <bobby.eshleman@bytedance.com>
>>=20
>> This saves original behaviour from af_vsock.c - switch any error
>> code returned from transport layer to ENOMEM.
>>=20
>> Signed-off-by: Bobby Eshleman <bobby.eshleman@bytedance.com>
>> Signed-off-by: Arseniy Krasnov <AVKrasnov@sberdevices.ru>
>> ---
>> net/vmw_vsock/vmci_transport.c | 9 ++++++++-
>> 1 file changed, 8 insertions(+), 1 deletion(-)
>=20
> @Bryan @Vishnu what do you think about this patch?
>=20
> A bit of context:
>=20
> Before this series, the af_vsock core always returned ENOMEM to the user
> if the transport failed to queue the packet.
>=20
> Now we are changing it by returning the transport error. So I think here
> we want to preserve the previous behavior for vmci, but I don't know if
> that's the right thing.
>=20

Agree with Stefano.  I don't think we need to preserve the previous
behavior for vmci.

>=20
> @Arseniy please in the next versions describe better in the commit
> messages the reasons for these changes, so it is easier review for
> others and also in the future by reading the commit message we can
> understand the reason for the change.
>=20
> Thanks,
> Stefano
>=20
>>=20
>> diff --git a/net/vmw_vsock/vmci_transport.c b/net/vmw_vsock/vmci_transpo=
rt.c
>> index 842c94286d31..289a36a203a2 100644
>> --- a/net/vmw_vsock/vmci_transport.c
>> +++ b/net/vmw_vsock/vmci_transport.c
>> @@ -1838,7 +1838,14 @@ static ssize_t vmci_transport_stream_enqueue(
>>      struct msghdr *msg,
>>      size_t len)
>> {
>> -      return vmci_qpair_enquev(vmci_trans(vsk)->qpair, msg, len, 0);
>> +      int err;
>> +
>> +      err =3D vmci_qpair_enquev(vmci_trans(vsk)->qpair, msg, len, 0);
>> +
>> +      if (err < 0)
>> +              err =3D -ENOMEM;
>> +
>> +      return err;
>> }
>>=20
>> static s64 vmci_transport_stream_has_data(struct vsock_sock *vsk)
>> --
>> 2.25.1
>=20
>=20
> !! External Email: This email originated from outside of the organization=
. Do not click links or open attachments unless you recognize the sender.