Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp817325rwb; Thu, 1 Dec 2022 08:43:48 -0800 (PST) X-Google-Smtp-Source: AA0mqf6JPKFazBpdBPX2ROzabjsKp8LKgkIZXioCatMOQgQsBgzRO03wETNlSTmmLMTKxCfmzxin X-Received: by 2002:aa7:d85a:0:b0:46b:81a8:1ff6 with SMTP id f26-20020aa7d85a000000b0046b81a81ff6mr11883523eds.174.1669913028646; Thu, 01 Dec 2022 08:43:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669913028; cv=none; d=google.com; s=arc-20160816; b=vSoKuo5wMlWANMvNkvIAAr6dDa4euEUgKd5eKrnzaaCAg/lor62izlkDydPnjUuHwI /CF7fH2L94f/1bQ7/NW6vyl/ZSL3OqsXBT15SDz6JGt9uBGAHnb0hLCXsSBbBbkFDBiK jflYKlOMk27pY8/L93ltv8oSWWrAr/mcqGVPu8c2g8r78uDB06rWR57liHbwDKQfj3Ua Vv/EkyFzQyIike1gsMB913RCNLJFXI0Ja7Y+vScxFwIDNCNg46iEgPVkVrH/5EYx9psX H4kSZmATyxKw+0oh4ZjrAeXC/XkOZwJGbOBsuyPudfceBglrY+ehVuiKuhHXDZgfWoA1 ZEcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=PWPmRJDAyGj+pptgBNHHweUgs8v/1V5O7sPPnYQ3HWU=; b=KS0ufxNlD2VlE6ATeXavWHCQZ2Jew0jrHpRCfpF+uFtwxHI8xAcBfEL2DZeUNt6os6 KQ5PfeWZ2tYTvB74mz8DuoJ+bUyIvMshTBYH8R0Y05MVe9dpAPdX4aE2NFnhpII2V2Gy mlJzCwlhgSr+1w3WCiWIwg8YpRClchEkvicPBm/nAsRkjbgRsdiTNJZnrs9JdwoCFaf7 yW7pgHoFbi1HhtlqjdOfm90Vypr0HZsuQFGXlam7rRjjB7nb+26xfF6ygwNi06Su/MSE L9hyeGMPUpwVzRbUqbPu6JBH4ylbOzunmf3pcjTFmr4cISKvF1BZWjrJb5Y0xiODIPBo VvCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=k0Z59nYH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ho19-20020a1709070e9300b007ade664ee53si4715480ejc.148.2022.12.01.08.43.28; Thu, 01 Dec 2022 08:43:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=k0Z59nYH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231829AbiLAPuH (ORCPT + 82 others); Thu, 1 Dec 2022 10:50:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230143AbiLAPuG (ORCPT ); Thu, 1 Dec 2022 10:50:06 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89248A0566 for ; Thu, 1 Dec 2022 07:50:04 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 27D3661FC6 for ; Thu, 1 Dec 2022 15:50:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EDCE1C433C1; Thu, 1 Dec 2022 15:50:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669909803; bh=LUT1bQztocCXvyDRR6quaBkfdm6TJC4VK3CcqENBpls=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=k0Z59nYHBrf584E9ogu8bxEUVrMHyFuQbzRH/g/hRi5fj+xjVT93zwZm2RbI4G2VA tvoMPjvOv2YXsQd8/iPu8/T1ExoPhhxCDDNBOISmlRWgebFQ4ftKQtnkIWLxFtxhda KYmycqreGvAfFEYwW98LiDTjAgO1CgwO6cXo69jdqYO/Fh8/nC16dL5NdosdKlHJh2 wHozbBGE1I+upsM6V32hFdxebJPPOhEeRL87+HHM0Ll4vMMsomliXoflBOWze60DMF dmYtHRApxQCgNTDWJd+jdk2Wyaokq2PGxqIDjgNpvhzrzIkCVM7B2/PrsdU5/847/b DKYFPCDnCP8gA== Date: Thu, 1 Dec 2022 15:49:56 +0000 From: Will Deacon To: Sudeep Holla Cc: Quentin Perret , Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Oliver Upton , Catalin Marinas , Andrew Walbran , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH 02/12] firmware: arm_ffa: Move comment before the field it is documenting Message-ID: <20221201154956.GA28682@willie-the-truck> References: <20221116170335.2341003-1-qperret@google.com> <20221116170335.2341003-3-qperret@google.com> <20221201115308.gciyfttnhvz2wcuz@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221201115308.gciyfttnhvz2wcuz@bogus> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 01, 2022 at 11:53:08AM +0000, Sudeep Holla wrote: > On Wed, Nov 16, 2022 at 05:03:25PM +0000, Quentin Perret wrote: > > From: Will Deacon > > > > This is consistent with the other comments in the struct. > > > Not sure how that happened :). Anyways, > > Reviewed-by: Sudeep Holla > > I am yet to look at the other patches and I would like to have a setup > to test it as well. So I will look at the other patches and test it later. > The reason for reviewing the first 2 patches moving the code out of the > driver is to check if they can be merged for v6.2 itself. > > I may start pushing FF-A v1.1 changes for v6.3 and trying to avoid conflicts > or cross tree dependencies. I know it is quite late for v6.2 but these changes > are trivial and good to get it in for v6.2 if possible. > > Will, thoughts ? If you agree, please take it via arm64 for v6.2. I don't > have any FF-A changes for v6.2 ATM, so there should be not conflicts. You're asking me to merge my own patches? Of course I can do that :D Cheers, Will