Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e037b3b5-3a5a-90c3-0d91-e4882700cbf5@kernel.org>
Date:   Thu, 1 Dec 2022 10:36:48 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH] clk: socfpga: Fix memory leak in socfpga_gate_init()
Content-Language: en-US
To:     Xiu Jianfeng <xiujianfeng@huawei.com>, mturquette@baylibre.com,
        sboyd@kernel.org
Cc:     linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20221123031622.63171-1-xiujianfeng@huawei.com>
From:   Dinh Nguyen <dinguyen@kernel.org>
In-Reply-To: <20221123031622.63171-1-xiujianfeng@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 11/22/22 21:16, Xiu Jianfeng wrote:
> Free @socfpga_clk and @ops on the error path to avoid memory leak issue.
> 
> Fixes: a30a67be7b6e ("clk: socfpga: Don't have get_parent for single parent ops")
> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
> ---
>   drivers/clk/socfpga/clk-gate.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/socfpga/clk-gate.c b/drivers/clk/socfpga/clk-gate.c
> index 3e347b9e9eff..0c18c55edf8c 100644
> --- a/drivers/clk/socfpga/clk-gate.c
> +++ b/drivers/clk/socfpga/clk-gate.c
> @@ -133,8 +133,10 @@ void __init socfpga_gate_init(struct device_node *node)
>   		return;
>   
>   	ops = kmemdup(&gateclk_ops, sizeof(gateclk_ops), GFP_KERNEL);
> -	if (WARN_ON(!ops))
> +	if (WARN_ON(!ops)) {
> +		kfree(socfpga_clk);
>   		return;
> +	}
>   
>   	rc = of_property_read_u32_array(node, "clk-gate", clk_gate, 2);
>   	if (rc)
> @@ -182,6 +184,7 @@ void __init socfpga_gate_init(struct device_node *node)
>   
>   	err = clk_hw_register(NULL, hw_clk);
>   	if (err) {
> +		kfree(ops);
>   		kfree(socfpga_clk);
>   		return;
>   	}

Acked-by: Dinh Nguyen <dinguyen@kernel.org>