Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 1 Dec 2022 10:50:01 -0600
From:   Jeff LaBundy <jeff@labundy.com>
To:     ye.xingchen@zte.com.cn
Cc:     dmitry.torokhov@gmail.com, colin.i.king@gmail.com,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: misc: use sysfs_emit() to instead of scnprintf()
Message-ID: <Y4jbOX4ePJz7vbu1@nixie71>
References: <202212011548387254492@zte.com.cn>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202212011548387254492@zte.com.cn>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?a5SxbkVtsLK4fxj56ixMAFc8jUW6e3FyhwigO6N0nsY3XY+KRkKWd53DGrzR?=
 =?us-ascii?Q?qe3DeQesz9iBHfSUtvWhfcbfri+pdztRripabh9OaRgkGtDHqcLnCAPx5lPv?=
 =?us-ascii?Q?oe+P9mmxBeX1vmWgk7ehIljil4q1HC5KRh66+mjeSrbbRR5P8ap5KFJsqyK4?=
 =?us-ascii?Q?E+U3sxnlpVAJH+W10jMpZpm0r2NuhmNty6YJRuq0xRoHK1XkvSAphiIpkRg1?=
 =?us-ascii?Q?KJmadaKEkBWv/bdlJQ9W54+g+PZqkVv/ELd/oGjgCgaUXkXp/cRMt43DBXgX?=
 =?us-ascii?Q?YD17PyhEVDbNLCt9URhtffAaMr1H3pTLRCu777FhfPEAOrGLVIdj7j2M66WK?=
 =?us-ascii?Q?TPwRzVgERR/sO90lobYxr/fCmPnVz5vUIgU31x1017Em9EKmRHEYxbruQQpx?=
 =?us-ascii?Q?5yRyZJ2FeBWUD6dDEYpxoLL1XYdWyjQI2HGMBzxIA+SC8FKHN7GhGXeyb0lM?=
 =?us-ascii?Q?Aeq0IKFPzqoooWU9kD/QV9iE0XGe415CRVi+KvHwbcvt6ercScEZyMgAlC1K?=
 =?us-ascii?Q?ytCYH9WiPDGQX2JSuQxkPcVWSB+OyFE6O171BSYbT3nXxujo8wQAgxX0/onS?=
 =?us-ascii?Q?kwp8wCS6Xl0kNgWS6AChRtF7jTBzPpApNa6PrIS0RHFBG3NvNIWSi+Tjx6fO?=
 =?us-ascii?Q?kw5lZTZ5+7sKBDOVIYGnF2uJK5uad1esptv2fD90IyOSx22KlNinaG3AwJE4?=
 =?us-ascii?Q?ORwsNIT6r6pQlI4Yl+RkgPy/gJ25STc8KNUk8Hm4v2BLs8OLcMW+wXb8VyxU?=
 =?us-ascii?Q?NX1MFhBEUxDUECsl1zApb85ASoHMz4p9domV4pWFDJlRzu3fYC4I5RIZhpWU?=
 =?us-ascii?Q?qls1TYT5ZlcTH36pYl1yW43v4k9eOmM3k/mc9KTLkFS/yWYUHzCRawnpTuQJ?=
 =?us-ascii?Q?bmUEyEvt/LweL0aeYabTzeIBYuCH7Z7gHDClt5+QTF+1/7FdD8i8FZsQ8oPI?=
 =?us-ascii?Q?tujVmQsxXVRq8a9VFyN/BtLg7EQ1M4///R3p4iZQZxgBbtQ1xZr2xVbP95u3?=
 =?us-ascii?Q?suqJSHE+0sGfBcQQr7eKrkkdwr6pXUOWnAh+XpVXv7cpmxpPECK+hu+oA8ma?=
 =?us-ascii?Q?KT8UutwV/16cWXJnrbL+0nCyC3p4HtMUcu9wknrRuglJ2TLK31pwKsDEqcyR?=
 =?us-ascii?Q?vqJGRW5hX+Qsh3t9CAO6QqUJ+NbfNGEYS1n8tAgdA9RdGdJd54pFDcJ3fnPE?=
 =?us-ascii?Q?nGfFeaFT+T5/OY15hSbcQgcm39zy1Ld3ds7TJy+RRfAJmSEaffpG2Yvky5Hz?=
 =?us-ascii?Q?za9u5h3q4hp426hXUqhdfLTjKCrF7Pv5cH9TEJmUEnxwv8sMsky8YJTOt+C9?=
 =?us-ascii?Q?vVzD5VvqgcTu9xw84acZFRnOhQ9Bmd2T+yLIs591YrmuS+v/zOWJ7TDVGJX0?=
 =?us-ascii?Q?wDN54BkddmOsBaBQUanMb9t0c9O22hPiSQx60U/Ola5BHeTtTX09NbPSOl9h?=
 =?us-ascii?Q?MXhIIrTwyOy9cnydHuLoIkXkcrvFjqKXEPof7klVzT2qlDjeF5NB1mZDv6qA?=
 =?us-ascii?Q?0/pkj6PN19fNCXXck/etcvzlSLNp5+wtOzu8obBXyp54qcJ5nQiT8x56+9Ky?=
 =?us-ascii?Q?h+kG+BK1MlmyN1k0J5EzXb2kP2GClnZOBGMJbTjw?=
X-OriginatorOrg: labundy.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6c5fca01-2008-4368-3330-08dad3bc185b
X-MS-Exchange-CrossTenant-AuthSource: SN4PR0801MB3774.namprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2022 16:50:04.4163
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 00b69d09-acab-4585-aca7-8fb7c6323e6f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZAFqjcale80HG2Z2JQHqNDFu0nuaAV915x3Xb1yshjZEawSDXBaEu3VlgrZR+tCO47cn/XKOuS0amvW5/Ti2HQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR08MB8279
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ye,

On Thu, Dec 01, 2022 at 03:48:38PM +0800, ye.xingchen@zte.com.cn wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
> 
> Replace the open-code with sysfs_emit() to simplify the code.
> 
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
>  drivers/input/misc/ims-pcu.c | 10 +++++-----
>  drivers/input/misc/iqs269a.c | 18 +++++++++---------
>  2 files changed, 14 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/input/misc/ims-pcu.c b/drivers/input/misc/ims-pcu.c
> index b2f1292e27ef..6e8cc28debd9 100644
> --- a/drivers/input/misc/ims-pcu.c
> +++ b/drivers/input/misc/ims-pcu.c
> @@ -1050,7 +1050,7 @@ static ssize_t ims_pcu_attribute_show(struct device *dev,
>  			container_of(dattr, struct ims_pcu_attribute, dattr);
>  	char *field = (char *)pcu + attr->field_offset;
> 
> -	return scnprintf(buf, PAGE_SIZE, "%.*s\n", attr->field_length, field);
> +	return sysfs_emit(buf, "%.*s\n", attr->field_length, field);
>  }
> 
>  static ssize_t ims_pcu_attribute_store(struct device *dev,
> @@ -1206,7 +1206,7 @@ ims_pcu_update_firmware_status_show(struct device *dev,
>  	struct usb_interface *intf = to_usb_interface(dev);
>  	struct ims_pcu *pcu = usb_get_intfdata(intf);
> 
> -	return scnprintf(buf, PAGE_SIZE, "%d\n", pcu->update_firmware_status);
> +	return sysfs_emit(buf, "%d\n", pcu->update_firmware_status);
>  }
> 
>  static DEVICE_ATTR(update_firmware_status, S_IRUGO,
> @@ -1309,7 +1309,7 @@ static ssize_t ims_pcu_ofn_reg_data_show(struct device *dev,
>  	if (error)
>  		return error;
> 
> -	return scnprintf(buf, PAGE_SIZE, "%x\n", data);
> +	return sysfs_emit(buf, "%x\n", data);
>  }
> 
>  static ssize_t ims_pcu_ofn_reg_data_store(struct device *dev,
> @@ -1344,7 +1344,7 @@ static ssize_t ims_pcu_ofn_reg_addr_show(struct device *dev,
>  	int error;
> 
>  	mutex_lock(&pcu->cmd_mutex);
> -	error = scnprintf(buf, PAGE_SIZE, "%x\n", pcu->ofn_reg_addr);
> +	error = sysfs_emit(buf, "%x\n", pcu->ofn_reg_addr);
>  	mutex_unlock(&pcu->cmd_mutex);
> 
>  	return error;
> @@ -1397,7 +1397,7 @@ static ssize_t ims_pcu_ofn_bit_show(struct device *dev,
>  	if (error)
>  		return error;
> 
> -	return scnprintf(buf, PAGE_SIZE, "%d\n", !!(data & (1 << attr->nr)));
> +	return sysfs_emit(buf, "%d\n", !!(data & (1 << attr->nr)));
>  }
> 
>  static ssize_t ims_pcu_ofn_bit_store(struct device *dev,
> diff --git a/drivers/input/misc/iqs269a.c b/drivers/input/misc/iqs269a.c
> index a348247d3d38..e4d5cea51f39 100644
> --- a/drivers/input/misc/iqs269a.c
> +++ b/drivers/input/misc/iqs269a.c
> @@ -1332,7 +1332,7 @@ static ssize_t counts_show(struct device *dev,
>  	if (error)
>  		return error;
> 
> -	return scnprintf(buf, PAGE_SIZE, "%u\n", le16_to_cpu(counts));
> +	return sysfs_emit(buf, "%u\n", le16_to_cpu(counts));
>  }
> 
>  static ssize_t hall_bin_show(struct device *dev,
> @@ -1369,7 +1369,7 @@ static ssize_t hall_bin_show(struct device *dev,
>  		return -EINVAL;
>  	}
> 
> -	return scnprintf(buf, PAGE_SIZE, "%u\n", val);
> +	return sysfs_emit(buf, "%u\n", val);
>  }
> 
>  static ssize_t hall_enable_show(struct device *dev,
> @@ -1377,7 +1377,7 @@ static ssize_t hall_enable_show(struct device *dev,
>  {
>  	struct iqs269_private *iqs269 = dev_get_drvdata(dev);
> 
> -	return scnprintf(buf, PAGE_SIZE, "%u\n", iqs269->hall_enable);
> +	return sysfs_emit(buf, "%u\n", iqs269->hall_enable);
>  }
> 
>  static ssize_t hall_enable_store(struct device *dev,
> @@ -1407,7 +1407,7 @@ static ssize_t ch_number_show(struct device *dev,
>  {
>  	struct iqs269_private *iqs269 = dev_get_drvdata(dev);
> 
> -	return scnprintf(buf, PAGE_SIZE, "%u\n", iqs269->ch_num);
> +	return sysfs_emit(buf, "%u\n", iqs269->ch_num);
>  }
> 
>  static ssize_t ch_number_store(struct device *dev,
> @@ -1435,7 +1435,7 @@ static ssize_t rx_enable_show(struct device *dev,
>  {
>  	struct iqs269_private *iqs269 = dev_get_drvdata(dev);
> 
> -	return scnprintf(buf, PAGE_SIZE, "%u\n",
> +	return sysfs_emit(buf, "%u\n",
>  			 iqs269->ch_reg[iqs269->ch_num].rx_enable);

Please refer to my earlier comment with regard to vertical alignment.

>  }
> 
> @@ -1475,7 +1475,7 @@ static ssize_t ati_mode_show(struct device *dev,
>  	if (error)
>  		return error;
> 
> -	return scnprintf(buf, PAGE_SIZE, "%u\n", val);
> +	return sysfs_emit(buf, "%u\n", val);
>  }
> 
>  static ssize_t ati_mode_store(struct device *dev,
> @@ -1508,7 +1508,7 @@ static ssize_t ati_base_show(struct device *dev,
>  	if (error)
>  		return error;
> 
> -	return scnprintf(buf, PAGE_SIZE, "%u\n", val);
> +	return sysfs_emit(buf, "%u\n", val);
>  }
> 
>  static ssize_t ati_base_store(struct device *dev,
> @@ -1541,7 +1541,7 @@ static ssize_t ati_target_show(struct device *dev,
>  	if (error)
>  		return error;
> 
> -	return scnprintf(buf, PAGE_SIZE, "%u\n", val);
> +	return sysfs_emit(buf, "%u\n", val);
>  }
> 
>  static ssize_t ati_target_store(struct device *dev,
> @@ -1568,7 +1568,7 @@ static ssize_t ati_trigger_show(struct device *dev,
>  {
>  	struct iqs269_private *iqs269 = dev_get_drvdata(dev);
> 
> -	return scnprintf(buf, PAGE_SIZE, "%u\n", iqs269->ati_current);
> +	return sysfs_emit(buf, "%u\n", iqs269->ati_current);

This patch creates a merge conflict with another one I have out for
review [1], so one of us will need to rework.

My hope is that I can go first, because mine is a bug fix and hence
higher priority.

>  }
> 
>  static ssize_t ati_trigger_store(struct device *dev,
> -- 
> 2.25.1

[1] https://patchwork.kernel.org/patch/13058161/

Kind regards,
Jeff LaBundy