Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 1 Dec 2022 09:02:01 -0800
From:   Ira Weiny <ira.weiny@intel.com>
To:     Jonathan Cameron <Jonathan.Cameron@huawei.com>
CC:     Dan Williams <dan.j.williams@intel.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        "Davidlohr Bueso" <dave@stgolabs.net>,
        <linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>
Subject: Re: [PATCH V2 04/11] cxl/mem: Clear events on driver load
Message-ID: <Y4jeCWOKhbQT+nlJ@iweiny-desk3>
References: <20221201002719.2596558-1-ira.weiny@intel.com>
 <20221201002719.2596558-5-ira.weiny@intel.com>
 <20221201133033.0000090f@Huawei.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221201133033.0000090f@Huawei.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jwJ3EO3EO52OH3gw6qCX1SrNJVYPZojnky7Rz3nahyFd4hz55CclkuOHwpBs?=
 =?us-ascii?Q?Is0jlax5vJSFP4+9Nk9SCID18OjhBIw/q2MDcwFbodGfLRMmZPaSXHHDxcY/?=
 =?us-ascii?Q?NdU/iG4lHTlOzqLBp5yPd2gaC87pXWOSQeI451KS2UGNNNiHTBlcmtN72+lT?=
 =?us-ascii?Q?/I2DH9UPlNelK4CtQwFvvql62ytWICy41MAHcPBM2waYyyGjdi6wD/bNj7v1?=
 =?us-ascii?Q?CxcAfClM65J1puxs6M8goWL+dBqPBpsfdvxKklIfDYjZnKmNt+GAGpK6RjJc?=
 =?us-ascii?Q?pX8mxj1n1Nrf6wPvRQlMaiiX17qR/fcIQZxhSq23kQwE7jXnDjN0G2TgIodx?=
 =?us-ascii?Q?FnjeRTpI2kRZzLlkmuEafDLgEMioYMU+j6iBBrLTXNA/gvVOqlNkJ/ad839J?=
 =?us-ascii?Q?Wjqs9XahH32N/TozWtFQbuLRLqqcXCe3yz0uTbADglPi+oartnrkp4FLZnbN?=
 =?us-ascii?Q?6FXWRStLLXRNxUAVnMgGivue7jW8r8P3zMGS8pDurcUFjrTXHGRkPaQRIidg?=
 =?us-ascii?Q?BQ5MMR2Cv3IusunKcj+4kesjrZGsGUJW6AVC1vMOntPGid8ZLrsGEe42Nd77?=
 =?us-ascii?Q?Qop0KNMmXbPTi2Wo3FuR1ciog8c4Sg0pgBSeD5klYWQ/nPGzrfy1nhm9Az8d?=
 =?us-ascii?Q?GPAFpc58PB5HW+zYFS1N8Vafqdgu0nzXQjg5oRzvlL6fk14fC26hAdACC9KD?=
 =?us-ascii?Q?lC3vFTpcaMrKEpI0NZq0EVaPBjG/2sLSoNZxJp8ymqSipRg4EP10E6bT0IZs?=
 =?us-ascii?Q?fbp7XMz3lp6qrpe7kYzeDIb/zP1gaeiBSOVpI4cPEn00U3pzaP3wl6z3f6ES?=
 =?us-ascii?Q?X02Njl9IE6B043AeKMNShTbn5RulNq8g+NgYRof5j1rTBlHCcGMBbCOwvBio?=
 =?us-ascii?Q?bCdVHBuHW5Rf/VE1gKXvuePIbFm59txlq2wo06VZ3qBPMk1jbz25WvhVCLTJ?=
 =?us-ascii?Q?c4sDMP8US2/8LJD2rYEb37y6edeEU26s0luKUsnY+z63N0IXPkJEGJ1OwzBx?=
 =?us-ascii?Q?H6l3XQgWtN4DkG5EFQn4S9fKR+tWB/AKY411hVjxYBwcIpnouA9hIwySfe4V?=
 =?us-ascii?Q?2LpWtKkiVGGsfNKBunlphYmXDiLcZEX0KYsFIZA8CK/C+RAPduxOQaG5rYbe?=
 =?us-ascii?Q?wEmrShBgLsE1tCbDTYxS2cP3QeSNbnh28zu7itZTW2+5DJBXr62OU67k1DWC?=
 =?us-ascii?Q?SyYR27M3w7RxD26bCZQGJOpy+eWxvilUda2rzbcmADFpYcq1jisuVz6wRyud?=
 =?us-ascii?Q?NUbZVK8HeKowiAmz7wkq91CiC9R4To2tvD+3Nz+C84cIxkL7d3B1mocG2M/o?=
 =?us-ascii?Q?IEWeQTyLk9loFfhGLD7I3pMPo1Jged72XzKV2LVn9E/b02OSgTaAFGwx5Uzv?=
 =?us-ascii?Q?0QwfL8mpWGEUtTEmqXSnkVDV4R8UkTaWwKOmNO48Vor+jT8eGzVXQ5ea3mmn?=
 =?us-ascii?Q?9wcwt/6PDPlui7D5kJ1NX2GgYwCg54YQK2QjA6NsnQ42idrPSD3Nok++8+Dk?=
 =?us-ascii?Q?Xq2sy7pvy1yL4yFT1mZhWHqpUP5nS+OgOCPRYmbljPphWmYeIS5V9w774Pdq?=
 =?us-ascii?Q?bUlhPIsDgUMt5/sUrlybFux2fDmMH0RLl9VXjokn?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 10a1ce49-4308-4360-0ae1-08dad3bdc676
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2022 17:02:05.9813
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XnNcTTIZsI9VemMxlEmXt4PxHy/r137Dgl8BbOW8bQzS0n552TnmrSjwiTxyJvwgLPL4M4N8NV1W0wsPMSu/MQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB7626
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Dec 01, 2022 at 01:30:33PM +0000, Jonathan Cameron wrote:
> On Wed, 30 Nov 2022 16:27:12 -0800
> ira.weiny@intel.com wrote:
> 
> > From: Ira Weiny <ira.weiny@intel.com>
> > 
> > The information contained in the events prior to the driver loading can
> > be queried at any time through other mailbox commands.
> > 
> > Ensure a clean slate of events by reading and clearing the events.  The
> > events are sent to the trace buffer but it is not anticipated to have
> > anyone listening to it at driver load time.
> > 
> > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> > Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> 
> Probably not worth addressing but there is a corner case where this might fail
> if some broken software already messed with reading out the events.

Yea they can keep the pieces if they have done that.

> 
> Imagine it read the first mailbox sized chunk, but didn't clear them...
> 
> If that happens, then we'd end up seeing the whole list, but in non
> temporal order and hence trying to clear them out of order with predictable
> fails.
> 
> Maybe this is the category of things we 'fix' if we ever hear of it actually
> happening.
> 
> So with that caveat called out so I can say 'I told you so' :), fine to keep my tag on this.

Sure!  We probably owe you this T-Shirt already!

https://www.amazon.com/Big-Bang-Theory-Informed-Thusly/dp/B06XYCSQRF

:-D

Ira

> 
> Thanks,
> 
> Jonathan
> 
> 
> > ---
> >  drivers/cxl/pci.c            | 2 ++
> >  tools/testing/cxl/test/mem.c | 2 ++
> >  2 files changed, 4 insertions(+)
> > 
> > diff --git a/drivers/cxl/pci.c b/drivers/cxl/pci.c
> > index 8f86f85d89c7..11e95a95195a 100644
> > --- a/drivers/cxl/pci.c
> > +++ b/drivers/cxl/pci.c
> > @@ -521,6 +521,8 @@ static int cxl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> >  	if (IS_ERR(cxlmd))
> >  		return PTR_ERR(cxlmd);
> >  
> > +	cxl_mem_get_event_records(cxlds);
> > +
> >  	if (resource_size(&cxlds->pmem_res) && IS_ENABLED(CONFIG_CXL_PMEM))
> >  		rc = devm_cxl_add_nvdimm(&pdev->dev, cxlmd);
> >  
> > diff --git a/tools/testing/cxl/test/mem.c b/tools/testing/cxl/test/mem.c
> > index aa2df3a15051..e2f5445d24ff 100644
> > --- a/tools/testing/cxl/test/mem.c
> > +++ b/tools/testing/cxl/test/mem.c
> > @@ -285,6 +285,8 @@ static int cxl_mock_mem_probe(struct platform_device *pdev)
> >  	if (IS_ERR(cxlmd))
> >  		return PTR_ERR(cxlmd);
> >  
> > +	cxl_mem_get_event_records(cxlds);
> > +
> >  	if (resource_size(&cxlds->pmem_res) && IS_ENABLED(CONFIG_CXL_PMEM))
> >  		rc = devm_cxl_add_nvdimm(dev, cxlmd);
> >  
>