Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp903743rwb; Thu, 1 Dec 2022 09:44:16 -0800 (PST) X-Google-Smtp-Source: AA0mqf51ptDcPj0vsDbq8FiYlZsv8JleLy0DA76JfnQlsHns9n2OrTj62KHx5N4VZ/cULBgzaBOC X-Received: by 2002:a05:6402:3c1:b0:46b:2d74:d970 with SMTP id t1-20020a05640203c100b0046b2d74d970mr18425573edw.138.1669916655938; Thu, 01 Dec 2022 09:44:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669916655; cv=none; d=google.com; s=arc-20160816; b=chjzlSvchOCXht6TyVSzQ+BH/wJ9hJuUvVs1IUvwevD3ce3U/c9y9edndJouFNzUnz LDdUAxViaDNKzGsC4K1qFPqbQbE6CWf502H4CKDxZYTF6oQIIqEa+2xnYSl4tSFKZl6q 2vcjIPe98J+agjrmvT3uVQ7fUbo0O8LpT1WjzJF4/3xvc/IGP+8IK8HdZdXmZryWXGs6 +4dE2ldMfnZ++ECUQ02AZNAsGQNcMKthB0TGc1BxPHAqxjdAG+eHTTfVhGst9/K7fofC 9/I47+sTqUF2xmNDkDCR0/DNdDnaxoObLvfmm0g1Lg7O6mqJcPz2LifDrLsmwySDKHlv Smaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=8tTkfl7b38uC2WDz4yKrjD8Z9Ib6oZTawq2Wea8T5PA=; b=tC6kP7QcUFuCf5C3weG/2ok+NtwwKaJq2lHYqvAtvp1dl3/pdyZVs8gTWdLuVlxSGC zhAIKwfjl0IhHnDsOLEZYuC83oADIClaFpivNntv4TFAoHYl1CN8AaB0kjJXxZ21Ua3R 0q43E+umQn/PppwvTv7VuNFSa9JNQoOTa8yclOo7z6WFQDnEUSFq8TTS7h6lAjdXkDgc Yj/Qyej5BfEu5qf6qFZo2PjiRV60bA3qj7pGhHLSY71SjMS91pVObETO/9N/sVNdaB0S r0jJoLbKdlZw6fxyAc69kBQJnIZJWEJ8boG7SMPde1RIBDnAR7t8zvEHQzkZC5qHHD3B Tq8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=lcEPbMdK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hw9-20020a170907a0c900b0078dbd939dacsi4566835ejc.545.2022.12.01.09.43.56; Thu, 01 Dec 2022 09:44:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=lcEPbMdK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232292AbiLAQj6 (ORCPT + 82 others); Thu, 1 Dec 2022 11:39:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232306AbiLAQjr (ORCPT ); Thu, 1 Dec 2022 11:39:47 -0500 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30D5EBB7D2 for ; Thu, 1 Dec 2022 08:39:30 -0800 (PST) Received: by mail-pj1-x102d.google.com with SMTP id 3-20020a17090a098300b00219041dcbe9so2598101pjo.3 for ; Thu, 01 Dec 2022 08:39:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8tTkfl7b38uC2WDz4yKrjD8Z9Ib6oZTawq2Wea8T5PA=; b=lcEPbMdKdFt38HwwgaWulaeQeLiD6eYpcMAEPqcuGZrdr5CbZ+TTIaq/YZ8EbPmLWO i9yjejt8UDI7SYb7sMp6/rBviiGAxo7HXDWmLy+usxx+tHysd3j2ew2Xtz6krPpdlY/c 9nywz2AFdfmTNWpiqcEO03qQAGRsKKrQjwwGw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8tTkfl7b38uC2WDz4yKrjD8Z9Ib6oZTawq2Wea8T5PA=; b=Xkl2wj0o3c3GWXVUFF4RpPlhq2yxBfIrQNgfQhZTbBjTQqZeLvTaIjj27Xtx7bErKQ Pz0LkvjLIs1ecMSxMnYHJp+9rzVhIapzrGepOejdNYlJ/CCRMsTIy6YU19z5EmBtqCzr OisPtHxcFORonuM83IDz89+tsKncdfE+N5bf82SAn+ZYG+7JOJV9GgFSfuDWaDXds5V2 8v+GzSCUbIFwtr92GRDURn4UN5iF6wlYHwUoOesrzgsyYklhjRh5YV2CKYr1PzZbs7++ Pxxqi3SCBzFyX5uiLgvjgNsdgeXdHszZtyE02VtccGXwb35Dm88zKnnIBf29rU07/xE4 o/zw== X-Gm-Message-State: ANoB5pkDDo0ZJ83K2i0R1H3wcCHr+Q8h91vfROZ9/mt5aAfyotSVE/Rr n//DKb8Ozrn4EiIkP5zelOHxQCf11tbmNA== X-Received: by 2002:a17:902:e74d:b0:186:887b:baa2 with SMTP id p13-20020a170902e74d00b00186887bbaa2mr62209107plf.27.1669912769708; Thu, 01 Dec 2022 08:39:29 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id z15-20020a655a4f000000b0046faefad8a1sm2759204pgs.79.2022.12.01.08.39.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Dec 2022 08:39:29 -0800 (PST) Date: Thu, 1 Dec 2022 08:39:28 -0800 From: Kees Cook To: "Masami Hiramatsu (Google)" Cc: LKML , Borislav Petkov , Alexei Starovoitov , Steven Rostedt , Linus Torvalds , Andrew Morton , Peter Zijlstra , Josh Poimboeuf , KP Singh , Mark Rutland , Florent Revest , Greg Kroah-Hartman , Christoph Hellwig , Chris Mason Subject: Re: [RFC PATCH] panic: Add new taint flag for fault injection Message-ID: <202212010838.B0B109DA@keescook> References: <20221201234121.8925fdf83115747ac4ac116a@kernel.org> <166991263326.311919.16890937584677289681.stgit@devnote3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <166991263326.311919.16890937584677289681.stgit@devnote3> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 02, 2022 at 01:37:13AM +0900, Masami Hiramatsu (Google) wrote: > From: Masami Hiramatsu (Google) > > Since the function error injection framework in the fault injection > subsystem can change the function code flow forcibly, it may cause > unexpected behavior (but that is the purpose of this feature). > To identify this in the kernel oops message, add a new taint flag > for this, and set it if it is (and similar things in BPF) used. Why is hooking through BPF considered to be "fault injection" here? -- Kees Cook