Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp929837rwb; Thu, 1 Dec 2022 10:04:19 -0800 (PST) X-Google-Smtp-Source: AA0mqf5vUMg9HKaiboBP+s0jdFCgabmwx8T7GrQVrfziKRIswOp1D6xc3ezBt9jNAzinQi3DsB4J X-Received: by 2002:a17:906:a157:b0:7a5:7e25:5b11 with SMTP id bu23-20020a170906a15700b007a57e255b11mr56349875ejb.254.1669917858849; Thu, 01 Dec 2022 10:04:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669917858; cv=none; d=google.com; s=arc-20160816; b=0925GNp4fq+7OaT7qdKeEj2WN+BphyS4nNECyHWPaDvWUPy5jjyLTWznOkZD5lNfsf EqzyZwhDEv64ckWjum7ag9bK7h8pHtJ5xl9oWezElVL6rutfQWcjQIIqkWiqAzu7Cj4h s6OFs7E3g7qEx8x4jzGMfc8I3fVg8nMC7tlakwiE14z7LP9tz+1mQ7a5dxk4Igz8eSQZ 8V2mJQcQIrKT+ArDomSy+Rv+6jcHY7JOjtBAUeHja1l8tu2epTwEyXl59tfjiBzAkVzr rRfQAOdijtfeE+NuOftQ3khiIoKq3x8P1pYdLblmCBdzq+RBzk0tTKgiu03ybX4amUL7 gRjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature:dkim-filter; bh=1Yld3/6UrtN3Zfgf3UojbyOQXGmtYGVa6e3vHIqgirg=; b=aN038Uezh0AqDexQc0K/YBGOQcqxH8zgqkQHvaGAKYyzYn/mzOcktp4DTgxUHvRk5v c6+3PvESXEflEttnJDWyY8U5l9p3kow6QxtjlfXPqMx7mP2Rc1J0LP0R8TCKW289B8tW s8Tvv7hU90QuBrvBSwBFhj1ktICnhPAF3/2un+PLlL0fsh1tFQPLlXGEb+DXAkElBZ6B MQFec42G8AJBM7U5d7LVrNtwsV5wKHg21rVs8uIEi+NPpViEvqv0Cwsspxto3XK2X7Uo FiBYaZjT8Tn2+JxO4vDpKirZRd8ir8Hzj6hphhQ1zFUrH2+Ll0c/tfDBs/GYohXbUu8D 3b8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ispras.ru header.s=default header.b=jgYoo7Jc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ho44-20020a1709070eac00b007a1084820f6si4945035ejc.230.2022.12.01.10.03.56; Thu, 01 Dec 2022 10:04:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ispras.ru header.s=default header.b=jgYoo7Jc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230016AbiLARea (ORCPT + 82 others); Thu, 1 Dec 2022 12:34:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229468AbiLARe1 (ORCPT ); Thu, 1 Dec 2022 12:34:27 -0500 Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3E6692A0F; Thu, 1 Dec 2022 09:34:26 -0800 (PST) Received: from localhost.localdomain (unknown [81.5.110.16]) by mail.ispras.ru (Postfix) with ESMTPSA id 2605440D4004; Thu, 1 Dec 2022 17:34:22 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru 2605440D4004 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ispras.ru; s=default; t=1669916062; bh=1Yld3/6UrtN3Zfgf3UojbyOQXGmtYGVa6e3vHIqgirg=; h=From:To:Cc:Subject:Date:From; b=jgYoo7JcltneHCFmNbgYXH8Hj+3mR2lkhRLFW/8ZWR34wZWSx15Wrg7GXFlQ5Ma42 vFiKki6aYExBWhk8jNAXeZnYqbMkj0zSXq45MN93DaX8Y2fhC/Qoc7XH056YlMfJFy rCNa7PeHrXr4HgxiRJj/gcHMJqjjvmf8u9c7DVH0= From: Valentina Goncharenko To: "David S. Miller" Cc: Valentina Goncharenko , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jon Ringle , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: [PATCH 1/2] net: encx24j600: Add parentheses to fix precedence Date: Thu, 1 Dec 2022 20:34:07 +0300 Message-Id: <20221201173408.26954-1-goncharenko.vp@ispras.ru> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In functions regmap_encx24j600_phy_reg_read() and regmap_encx24j600_phy_reg_write() in the conditions of the waiting cycles for filling the variable 'ret' it is necessary to add parentheses to prevent wrong assignment due to logical operations precedence. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: d70e53262f5c ("net: Microchip encx24j600 driver") Signed-off-by: Valentina Goncharenko --- drivers/net/ethernet/microchip/encx24j600-regmap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/microchip/encx24j600-regmap.c b/drivers/net/ethernet/microchip/encx24j600-regmap.c index 81a8ccca7e5e..2e337c7a5773 100644 --- a/drivers/net/ethernet/microchip/encx24j600-regmap.c +++ b/drivers/net/ethernet/microchip/encx24j600-regmap.c @@ -359,7 +359,7 @@ static int regmap_encx24j600_phy_reg_read(void *context, unsigned int reg, goto err_out; usleep_range(26, 100); - while ((ret = regmap_read(ctx->regmap, MISTAT, &mistat) != 0) && + while (((ret = regmap_read(ctx->regmap, MISTAT, &mistat)) != 0) && (mistat & BUSY)) cpu_relax(); @@ -397,7 +397,7 @@ static int regmap_encx24j600_phy_reg_write(void *context, unsigned int reg, goto err_out; usleep_range(26, 100); - while ((ret = regmap_read(ctx->regmap, MISTAT, &mistat) != 0) && + while (((ret = regmap_read(ctx->regmap, MISTAT, &mistat)) != 0) && (mistat & BUSY)) cpu_relax(); -- 2.25.1