Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp979648rwb; Thu, 1 Dec 2022 10:41:01 -0800 (PST) X-Google-Smtp-Source: AA0mqf625DzHTdfPLindSF3++NhFiP9/C0hZY5LGQiWZeOcqhUvCB9b6uxG0zp5TRSmab/JfgXJU X-Received: by 2002:a62:f94c:0:b0:56e:174e:efdf with SMTP id g12-20020a62f94c000000b0056e174eefdfmr68524424pfm.29.1669920061269; Thu, 01 Dec 2022 10:41:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669920061; cv=none; d=google.com; s=arc-20160816; b=km4A9AxRti/Ct1JeujuVbm94j+kgrkPTBc2H06syVi78MRtbqSmPXN5t5RNfnY2OWR VYgy2hHV8OyULzceIFIvpICVuTLV42dcazL6Ux34k6P/TBJwwSBWBWAXVr+cv6RkXSVd C62kFmW49+PHkV7PiM0Z2XPC1IC2k0PfZYG524eZ8pjyxKlil3zV7khCulDHHr+xU+DV 3Jj8VhRbhTtCXRzSL0ZXN5RxEOs35PZZ+kOTq8lMAvvdYPTR2gSMTmec8Z1ByJUCD0k0 nv0gwqzsfcbjdfCrd8DnRC52sDuwov2VJvlzKSBKpnS/qD3YqK1BddKnhIPV38yI507L mFvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=ph7MPGrfzunQQt/4eI+BDAhPTHgqrwSTx7Qab2zu/54=; b=Ir2zNAIKT4Y+cUl/ZTFmE0Lq+7ZC6doU+I+sxIyu0rn9471GP72y0k6XB+7n/1qQE1 AkFX9OVLWyT2Iwyo4ZhXLqUwiJCvQUVY74cHsSve8c44MM+t9SGVxIGMc97ffIO/WcX7 NM90iQSP4DpfYMGkiMcshOc2HNhQJ2Jqw36PW4YJH3DsNbt+HWGW6goCLIXHDtlg3TcN WyjHGl026p9DU2yhMRuV0YcRM08BMRyQTpZSpD6455tQ1sVvbZbQ9bD4vexeBeTjmmzl 3SlP2m2d7ejVWescw2MlhW0q1fKRTnfrlPEyc3vlgK0VB0dEkRBLHRbRfz0jgwHbBAsl ZrEA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gateworks-com.20210112.gappssmtp.com header.s=20210112 header.b=uW3WAUUt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m188-20020a6326c5000000b004774a024588si5081685pgm.719.2022.12.01.10.40.50; Thu, 01 Dec 2022 10:41:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gateworks-com.20210112.gappssmtp.com header.s=20210112 header.b=uW3WAUUt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230419AbiLAS0X (ORCPT + 82 others); Thu, 1 Dec 2022 13:26:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229793AbiLAS0W (ORCPT ); Thu, 1 Dec 2022 13:26:22 -0500 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4AFCFABA30 for ; Thu, 1 Dec 2022 10:26:21 -0800 (PST) Received: by mail-pl1-x62a.google.com with SMTP id 4so2475738pli.0 for ; Thu, 01 Dec 2022 10:26:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gateworks-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ph7MPGrfzunQQt/4eI+BDAhPTHgqrwSTx7Qab2zu/54=; b=uW3WAUUtEquVeyqwSyCNiPA4ZE6LRad2EIeI/NOmUXA/ssB8kofL4AF/dCq9d0mj6s VwKpCbh88+eLrVZ7DI6sP3Lbr9sVe31XAOF+v3oKZudyPonlFsJpVJgmXIrMdJRF91zI 1leGCa6ps+dg/sE3nYrkNZ5XE7bZ2gyvrxZCs8sCX3mvFSW/1ObW+chwR2Zpz774GSNK s8X1mPJq6ACoJkNamddfcaBdVQdePtKTFiaUVujbOH1qzprOLEKzMcE6l0eJ6ELKaOF0 8zdwWbXUcrZs2TGb9KDv8ljxBztTwYX/WITZX7ANHya6M9o/xTAc86kTsEqWqX8g5rms fnwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ph7MPGrfzunQQt/4eI+BDAhPTHgqrwSTx7Qab2zu/54=; b=g0Q7KlLJNAbmNvyGzWWNJ3TDTVZ9p0LaukWXM+eYJhzB+I4eFmM7A/IRhNK2Pjhm4I b7adFEOZnM6aCEKqIKlB7Md+szWcurncjQGEwBYwqWDyolBOAz0GfYZ2/iviBgnK4n7y qElq38oJkZOnrHuIMZu7TvCmoxgK8/ml+yV85jBAY4ugynyUPuCWd8acRjhFceCj6/LW pUWHYgEJnXZVK8ufb523P4fso4x/SqfjjTJzcvMNTTIndQjMP1ZYtySq7iVAueFNMf5C Wi3keeQ/2pqFkdbRcyXqlH6/x1AxVFCy8dmSuYKihtw38W4ntkhzyxuX+vO7jGCv7wDH HzRw== X-Gm-Message-State: ANoB5pkJ6bFAssfXUtlrTrDCj/GstqhIO8X8aOk5v/AjCPd5/55IY4+/ /UV/7UMbM3wP1Nd22Bq5zRiHlJGkUtJ9YjNyv32gtFlNc9eASA== X-Received: by 2002:a17:90b:1095:b0:219:237c:7986 with SMTP id gj21-20020a17090b109500b00219237c7986mr26530907pjb.220.1669919180735; Thu, 01 Dec 2022 10:26:20 -0800 (PST) MIME-Version: 1.0 References: <20221118001548.635752-1-tharvey@gateworks.com> In-Reply-To: From: Tim Harvey Date: Thu, 1 Dec 2022 10:26:09 -0800 Message-ID: Subject: Re: [PATCH 0/3] add dt configuration for dp83867 led modes To: Ansuel Smith Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, Heiner Kallweit , Russell King , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Rob Herring , Krzysztof Kozlowski , Andrew Lunn Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 20, 2022 at 3:35 PM Andrew Lunn wrote: > > On Fri, Nov 18, 2022 at 11:57:00AM -0800, Tim Harvey wrote: > > On Fri, Nov 18, 2022 at 5:11 AM Andrew Lunn wrote: > > > > > > > Andrew, > > > > > > > > I completely agree with you but I haven't seen how that can be done > > > > yet. What support exists for a PHY driver to expose their LED > > > > configuration to be used that way? Can you point me to an example? > > > > > > Nobody has actually worked on this long enough to get code merged. e.g. > > > https://lore.kernel.org/netdev/20201004095852.GB1104@bug/T/ > > > https://lists.archive.carbon60.com/linux/kernel/3396223 > > > > > > This is probably the last attempt, which was not too far away from getting merged: > > > https://patches.linaro.org/project/linux-leds/cover/20220503151633.18760-1-ansuelsmth@gmail.com/ > > > > > > I seem to NACK a patch like yours every couple of months. If all that > > > wasted time was actually spent on a common framework, this would of > > > been solved years ago. > > > > > > How important is it to you to control these LEDs? Enough to finish > > > this code and get it merged? > > > > > > > Andrew, > > > > Thanks for the links - the most recent attempt does look promising. > > For whatever reason I don't have that series in my mail history so > > it's not clear how I can respond to it. > > apt-get install b4 > > > Ansuel, are you planning on posting a v7 of 'Adds support for PHY LEDs > > with offload triggers' [1]? > > > > I'm not all that familiar with netdev led triggers. Is there a way to > > configure the default offload blink mode via dt with your series? I > > didn't quite follow how the offload function/blink-mode gets set. > > The idea is that the PHY LEDs are just LEDs in the Linux LED > framework. So read Documentation/devicetree/bindings/leds/common.yaml. > The PHY should make use of these standard DT properties, including > linux,default-trigger. > > Andrew Ansuel, Are you planning on posting a v7 of 'Adds support for PHY LEDs with offload triggers' [1]? Best Regards, Tim [1] https://patches.linaro.org/project/linux-leds/list/?series=174704