Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp995423rwb; Thu, 1 Dec 2022 10:54:53 -0800 (PST) X-Google-Smtp-Source: AA0mqf4A/uYbvei+fhmdxZk3PLIDs2c4ln36YSRW3aMHpKfyuIoCu2SzwAfF7DM5x56PL9u5mcfD X-Received: by 2002:a63:d84c:0:b0:478:6bad:dc4 with SMTP id k12-20020a63d84c000000b004786bad0dc4mr5467371pgj.405.1669920893495; Thu, 01 Dec 2022 10:54:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669920893; cv=none; d=google.com; s=arc-20160816; b=YT7Qlm/g67iWGVknJJXqaxGq3mBvB1+9lpJeWs3Gr/Fk4t/pxHL9m7RlcnDTP7w/5l FHDRD23Hm3TfjrCNcgu4nWtWQiW1LZlD5Kx8c7Sl1FuAvQCI0wWg9ichRCStQx/HtXxh dC50GIZ5zWoI95UbNqRIJJdfsJo3MFyLo1KooOjz7xM9SlINFunaAzdGCMySq5ckJYCZ 5Gfmmcya/TcYqCc3BZ/6iwYu4zKq9FbfnbLp45LvjKbJJBUFClb58pw8/TnVXVVsY0+Y CAo0bgD7uSXq5o9k5CIgpNNw64NKnEggx3JekHCSN0r3peeIathiH43XYqo61A2A6MvR bKcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=RBHRoVLdDEVQPc3DT8VGSf/7MD/6ywN/0hVLKPO7OLo=; b=fJOkLPLeKcxT7lhVg1zVf+aLtQQ2OyjGS99wbxqs7Ti2QMheH0TcCf4YWfcA35ESbo dUDvMXS26dy4YNak0QSFda///JfOgJcsL5DkVVMwvvJbemb0FelfwwzVJjwi0xfOydXO J6FkJ3X9XJNEEad8v+YgVvpwIpZ7w+Ypl7Sh6/ZFUc4BkFVliZBWmzZYjGooptncam52 JbnLtCguwyJemNqTmSNXS0FCLH5svCuiVDqZtVZ19ig1LCni+5Wl2dVURB7c0wPsiVMF tgIwz1uIUs7TKMBb+/ukir/LMnjj4+eKN6JzCMVRCPA0a7A6rfAULPy9YpnESweIyGP9 CQPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NDOMZl4g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r16-20020a63fc50000000b00477a32da0a9si5195368pgk.455.2022.12.01.10.54.39; Thu, 01 Dec 2022 10:54:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NDOMZl4g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230500AbiLARrf (ORCPT + 82 others); Thu, 1 Dec 2022 12:47:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229629AbiLARq5 (ORCPT ); Thu, 1 Dec 2022 12:46:57 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F302FBBBEA for ; Thu, 1 Dec 2022 09:45:42 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 524FAB81FC7 for ; Thu, 1 Dec 2022 17:45:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC88FC433D6; Thu, 1 Dec 2022 17:45:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669916740; bh=xi727nDNhDZVe/pLE/3xYfRh/jN3YKblRfCd6X5uJoo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NDOMZl4gjnlzxDB5VdRKSxJBTvTvOCxUXl0/kbnRsZmdOSmaBVxO71raoOhTLea72 ylTadXG8ssFsRA0kSQLujmGpAx2rJJ8iFb609pGjsRy/4uBBV+bj0llHIZHj0iUzXG Xj6N7cys0Kb/Vco4SyfxJTP5lAOuvba0oc0I+BgVcim2vo4BbtOcb9wwjwYqNqgP// RWd9zMkrUvotuekWlTD831c+9b3NKdkX/icuLyzVDTHQT+jsnUYhgDjUboYszZB4C7 mgG0kIsL32J7CCr0zEae6rmcF6pJG0TemdPZihyVWsDZUhHCCPtIMQJ/O4ZVo+k6kd lYDTZf8eoaGmQ== Date: Thu, 1 Dec 2022 17:45:35 +0000 From: Will Deacon To: Anshuman Khandual Cc: linux-arm-kernel@lists.infradead.org, mark.rutland@arm.com, Catalin Marinas , linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm_pmu: Drop redundant armpmu->map_event() in armpmu_event_init() Message-ID: <20221201174534.GA28865@willie-the-truck> References: <20221130083350.264583-1-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221130083350.264583-1-anshuman.khandual@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 30, 2022 at 02:03:50PM +0530, Anshuman Khandual wrote: > __hw_perf_event_init() already calls armpmu->map_event() callback, and also > returns its error code including -ENOENT, along with a debug callout. Hence > an additional armpmu->map_event() check for -ENOENT is redundant. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Mark Rutland > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual > --- > This applies on v6.1-rc6 Doesn't apply against for-next/perf Will