Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9801fa7f-5971-1f5f-1b63-0d672c32fcf1@intel.com>
Date:   Thu, 1 Dec 2022 10:12:29 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.5.0
Subject: Re: [PATCH v4 4/5] selftests/resctrl: Cleanup properly when an error
 occurs in CAT test
Content-Language: en-US
To:     "Shaopeng Tan (Fujitsu)" <tan.shaopeng@fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Shuah Khan <shuah@kernel.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "Shuah Khan" <skhan@linuxfoundation.org>
References: <20221117010541.1014481-1-tan.shaopeng@jp.fujitsu.com>
 <20221117010541.1014481-5-tan.shaopeng@jp.fujitsu.com>
 <af1b4e59-2b4b-ddbb-2218-0e2808b718a3@intel.com>
 <TYAPR01MB6330CDB2C59C58EE77B912538B0F9@TYAPR01MB6330.jpnprd01.prod.outlook.com>
 <ba5a9ef2-b4ca-5c90-cc03-2296586455a6@intel.com>
 <TYAPR01MB63300F91A0755310E78D98308B159@TYAPR01MB6330.jpnprd01.prod.outlook.com>
 <ce549bc3-7e54-b1d3-7ec5-4cde66bd468f@intel.com>
 <TYAPR01MB6330FFB9E5BA7CCDC652EE3F8B149@TYAPR01MB6330.jpnprd01.prod.outlook.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <TYAPR01MB6330FFB9E5BA7CCDC652EE3F8B149@TYAPR01MB6330.jpnprd01.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NGhPaEMvYURnQ3BEaDRjcWE4d2EwamwvTnNEeitZMFlUL3pON3dwWGpBSmYy?=
 =?utf-8?B?dVhqMjZuZlU1MERLTkRFSW84V09lTEtVYlhmbXFqSGRSVHJFa2wzc3NRVVAv?=
 =?utf-8?B?bG0yR3RkNFlCQzFrQll1MG9vL2hUcmdvRWNFVmN2dUJLNTBIUndlM2ttUjFH?=
 =?utf-8?B?UWZRdmF4dGQySHNQejgzWUJER3VTYWVmWUM3QWE3QXlZM2l2V1Bvd0dPVkhU?=
 =?utf-8?B?ei9ESFZyT0FyNU1WVkJ3ek9ScGhZdDVlS2Y0K2h2dWQzbG85M0J4VW5zdlND?=
 =?utf-8?B?Q3ZHUDFZRS8ydm1zUnhCMzRrWGx4eHI1Ri95NlpLSGR2dG04RHhjZXZIWGRz?=
 =?utf-8?B?REx2UjdHd2d1Ymt2T1pMQWdLbWxDeXU0YytXc1ZHaHQrK05UZGRXTHo1RHMv?=
 =?utf-8?B?WnVGZXRLM050amViYnBtUVRiUFlBQUlwTjlEdzVLeFV0dzVGanlWZGRlaGxO?=
 =?utf-8?B?K1ZxbWxKaU02bEtDTDVMVXVOVDUwWG1TZzZWeVVNaEdMdU5KR1JoMjcvaDl2?=
 =?utf-8?B?NXhwOUkrd2ZQNWh2R1RmczRnL0RvcTl4RUdpYWtzOTBxdWlBbXZ6YnczYU92?=
 =?utf-8?B?R0oxdEdUZjZ4QVFyWnJHTnk2STJNNGgrOVpoWUVJOGlZYnovMUV3N3Jlam1P?=
 =?utf-8?B?MTRCcnkwU0ZmbUQxTU1XYmg1RGFWeVUrdTM2MXovcTNyUmQzTlFDeTZtaS9s?=
 =?utf-8?B?RkhIUlJnTXhlalJsd3AxVGYzRWpVZW5qak5HQSszVnR5RmhkNnVIWkJ5R1FJ?=
 =?utf-8?B?aWdidGJVUmd5bEIzZ3Nmc215bkYyZEQ1R2VabFY5V0ovUkRRKzdKT2hTalNN?=
 =?utf-8?B?dE44SjI3T0kxeExBWEtEUE9qRW5MU0xWbkxndHRUWUNCN0t2OGxBamlGcGRY?=
 =?utf-8?B?Y3lVd0xJODBTcmZLOWlzMXZwdlpGUDNRRjQrSGZvU3VjMmpJV2lIMHpBaldj?=
 =?utf-8?B?MkgxcG05cFIzZnhMcnk2aVdIM0tFZTlwRXNnUHpWMFRQTTZwRXJ2ZmJaY3Yx?=
 =?utf-8?B?VXlSamQxL3ZEby9BdE9HdmQrQ1d3ZHJVcW9iY3ZNL3dEL3M3SnNqUk9YbmE1?=
 =?utf-8?B?Mnc0QUVzaDNMN2R2THVZQ2pkWTBzMjVXU3BRWHNqOEhadjFMYnhOckw3VitO?=
 =?utf-8?B?SjdZY0hPeWlSSm9PQXRvOVpIN2FmRnl5Y004UFlUaG9sZUEwcVdkZGw0dDRk?=
 =?utf-8?B?bkh6QkNkc01oZE1uL2lCS1FpeDh6aHFQQzFpaHdqR1VDQVVsRmoyemlrUEtR?=
 =?utf-8?B?TWNtV1NPUTI3NjQvMktVczBYazZSNmJqajFQcktHaXR3YUhDTVA5MGJmNENP?=
 =?utf-8?B?Qjg0ZGNNb251Zlg5NmRSeHd0RDhmbnJUaVV4S2Y4elkzM2Z1WmR6NEMvWXd0?=
 =?utf-8?B?TWd4V3ltTnlaclJ2YXEweVRETjA4U2I5WGszWEJNUm9ZSU5GSGd0NkZwWEZy?=
 =?utf-8?B?RGdoRzUyNkJoQUt3SkFUU2l1VUh1ZWV6OVVMT3hrWWk1SnBVQkM3TUZzWUxl?=
 =?utf-8?B?WkVpdUNFaDA1Q3dIY0Z2akloR044elFRSXZWbGkvVzJaUWEzalhZZVV4NDY1?=
 =?utf-8?B?ZFNJS0pJcXhaU0VRRzVSdk94UTV0bmcrMDNudU5UTEtvc1BCbjZJOUh2K3g5?=
 =?utf-8?B?eHU0Qk1uS0xsamR4a0xhM2xacUZnRUZobVlGN3liVGVpVEtDdHpndS81dkM0?=
 =?utf-8?B?dkxZSmpRODUrYVRqUkZhNm1TTzFRdmh1bllLaU1aaG9pek5pQnJqRktDVzJw?=
 =?utf-8?B?TGlOTENLV21mblQ1dG1iL2VuUHN5dVlENW5uWlprM2Z5enZXVXp6L3plMzdB?=
 =?utf-8?B?T0Q1cHJtaERtbUxUTlZsMy9WUk5VaFBsRXZSdUR4Wm5QMHQ1cktPZEozVjJp?=
 =?utf-8?B?Q0oxb2pXVzQ2MmptY0dGR1BjTFpBUFNFWWgwVWlEbnhBMkR0cEtzYi9RT29V?=
 =?utf-8?B?K2VGaEhHTUpleWJMNDZ0Wklzek9tc3N1NTA1bU8xNkJXTytlclh4M0V3NTFt?=
 =?utf-8?B?eEhiRmE1N0x6OHQ0c2RYYmduSU1zdGJ1Rk5EVi9EWU9uclhxVXB3YTQ2blJJ?=
 =?utf-8?B?ZFBsbmNpZkNxRVVrM1Z6ZmhhNHFjZDg5djU0NHB5MGdWc2c2YllLVlN1T2tu?=
 =?utf-8?B?aTFNMUNSWWdoa1pFYlNtU2IydUpMbldXUy96MTh4amhQcDUzUTRlRzQ1dkdS?=
 =?utf-8?B?V1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0fdf7e76-f437-4c3b-cf04-08dad3c79d5b
X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1867.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2022 18:12:32.9587
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: u3myWc77wMBafDyOIwFyAVXQE20dXCh/LQeZtcLLsnE/OzyzEuwazxfhdWRQXFFL0w6cHJA9PDqCIoAq8qRG1klKaFU4+8HVdqHasJtoeXs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6433
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Shaopeng,

On 12/1/2022 12:20 AM, Shaopeng Tan (Fujitsu) wrote:
> Hi Reinette,
> 
>> On 11/30/2022 12:32 AM, Shaopeng Tan (Fujitsu) wrote:
>>
>>> Removing ctrl_handler() is only part of the fix in the next version(v5).
>>> All fixes as follows.
>>>
>>> --- a/tools/testing/selftests/resctrl/cat_test.c
>>> +++ b/tools/testing/selftests/resctrl/cat_test.c
>>> @@ -98,12 +98,17 @@ void cat_test_cleanup(void)
>>>         remove(RESULT_FILE_NAME2);
>>>  }
>>>
>>> +static void ctrlc_handler_child(int signum, siginfo_t *info, void
>>> +*ptr) {
>>> +       exit(EXIT_SUCCESS);
>>> +}
>>> +
>>
>> Could you please elaborate why this is necessary?
> 
> If enter "ctrl-c" when running "resctrl_tests -t cat",
> SIGINT will be sent to all processes (parent&child).
> 
> At this time, the child process receives a SIGINT signal, but does not take any action.
> In this case the parent process may not call ctrlc_handler() as expected.

Apologies, but I am not able to follow. My understanding is that the
ideal in working an failing case is for the parent to kill the child.
Could you please elaborate why the ctrlc_handler() may not be called?

> Therefore, ctrlc_handler_child() is necessary.
> 
> It may be better to ignore the signal, then code can be simple as follows.
> ----
>         if (bm_pid == 0) {
>                 param.mask = l_mask_1;
>                 strcpy(param.ctrlgrp, "c1");
>                 strcpy(param.mongrp, "m1");
>                 param.span = cache_size * n / count_of_bits;
>                 strcpy(param.filename, RESULT_FILE_NAME1);
>                 param.num_of_runs = 0;
>                 param.cpu_no = sibling_cpu_no;
>                 /* Ignore the signal,and wait to be cleaned up by the parent process */
>                 sigfillset(&sigact.sa_mask);
>                 sigact.sa_handler = SIG_IGN;
>                 //sigact.sa_sigaction = ctrlc_handler_child;  //delete
>                 if (sigaction(SIGINT, &sigact, NULL) ||
>                     sigaction(SIGTERM, &sigact, NULL) ||
>                     sigaction(SIGHUP, &sigact, NULL))
>                         perror("# sigaction");
>         } else {

Reinette