Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 1 Dec 2022 11:29:12 -0800
From:   Eric Biggers <ebiggers@kernel.org>
To:     Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Cc:     "Theodore Y. Ts o" <tytso@mit.edu>,
        Jaegeuk Kim <jaegeuk@kernel.org>,
        Jonathan Corbet <corbet@lwn.net>, Jens Axboe <axboe@kernel.dk>,
        Ard Biesheuvel <ardb@kernel.org>,
        Bagas Sanjaya <bagasdotme@gmail.com>,
        linux-fscrypt@vger.kernel.org, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH v4 0/2] Add SM4 XTS symmetric algorithm for blk-crypto
 and fscrypt
Message-ID: <Y4kAiKhZL4Ucv3MI@sol.localdomain>
References: <20221201125819.36932-1-tianjia.zhang@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221201125819.36932-1-tianjia.zhang@linux.alibaba.com>
Precedence: bulk

On Thu, Dec 01, 2022 at 08:58:17PM +0800, Tianjia Zhang wrote:
> SM4 is widely used in China's data encryption software and hardware.
> these algoritms are mandatory in many scenarios. This serial of
> patches enables the SM4-XTS algorithm in blk-crypto and enables the
> SM4-XTS/CTS algorithm in fscrypt to encrypt file content and filename.
> 
> v4 changes:
>   - only allow the SM4 XTS/CTS algorithm in policy v2 for fscrypt
>   - update git commit message
> 
> v3 change:
>   - update git commit message
> 
> v2 change:
>   - As Eric said, the new FSCRYPT_MODE is defined for the unused numbers 7 and 8
> 
> Tianjia Zhang (2):
>   blk-crypto: Add support for SM4-XTS blk crypto mode
>   fscrypt: Add SM4 XTS/CTS symmetric algorithm support
> 
>  Documentation/filesystems/fscrypt.rst |  1 +
>  block/blk-crypto.c                    |  6 ++++++
>  fs/crypto/keysetup.c                  | 15 +++++++++++++++
>  fs/crypto/policy.c                    |  5 +++++
>  include/linux/blk-crypto.h            |  1 +
>  include/uapi/linux/fscrypt.h          |  2 ++
>  6 files changed, 30 insertions(+)

Applied.  I don't think anyone should actually use this, but with the SM*
algorithms turning up everywhere these days, and people seemingly being totally
okay with that for some reason, I don't think it's fair for me to reject this.

- Eric